Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Horia Geanta <horia.geanta@nxp.com>
To:     Iuliana Prodan <iuliana.prodan@nxp.com>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        Aymen Sghaier <aymen.sghaier@nxp.com>
CC:     "David S. Miller" <davem@davemloft.net>,
        "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        dl-linux-imx <linux-imx@nxp.com>
Subject: Re: [PATCH v3 1/2] crypto: caam - fix pkcs1pad(rsa-caam, sha256)
 failure because of invalid input
Thread-Topic: [PATCH v3 1/2] crypto: caam - fix pkcs1pad(rsa-caam, sha256)
 failure because of invalid input
Thread-Index: AQHVEj+CGyNNQHQJmUKR+9DV1yltFQ==
Date:   Mon, 27 May 2019 16:37:15 +0000
Message-ID: <VI1PR0402MB34853A1681A83D311AD74599981D0@VI1PR0402MB3485.eurprd04.prod.outlook.com>
References: <1558709189-7237-1-git-send-email-iuliana.prodan@nxp.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 9f6df39d-02e3-4507-29f7-08d6e2c1938a
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 May 2019 16:37:15.0355
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: horia.geanta@nxp.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3792
Sender: linux-crypto-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

On 5/24/2019 5:46 PM, Iuliana Prodan wrote:=0A=
> @@ -1030,17 +1076,26 @@ int caam_pkc_init(struct device *ctrldev)=0A=
>  	if (!pk_inst)=0A=
>  		return 0;=0A=
>  =0A=
> +	/* allocate zero buffer, used for padding input */=0A=
> +	zero_buffer =3D kzalloc(CAAM_RSA_MAX_INPUT_SIZE - 1, GFP_DMA |=0A=
> +			      GFP_KERNEL);=0A=
> +	if (!zero_buffer)=0A=
> +		err =3D -ENOMEM;=0A=
Either return -ENOMEM or jump to a label before return err.=0A=
=0A=
> +=0A=
>  	err =3D crypto_register_akcipher(&caam_rsa);=0A=
> -	if (err)=0A=
> +	if (err) {=0A=
> +		kfree(zero_buffer);=0A=
>  		dev_warn(ctrldev, "%s alg registration failed\n",=0A=
>  			 caam_rsa.base.cra_driver_name);=0A=
> -	else=0A=
> +	} else {=0A=
>  		dev_info(ctrldev, "caam pkc algorithms registered in /proc/crypto\n");=
=0A=
> +	}=0A=
>  =0A=
>  	return err;=0A=
>  }=0A=
>  =0A=
>  void caam_pkc_exit(void)=0A=
>  {=0A=
> +	kfree(zero_buffer);=0A=
>  	crypto_unregister_akcipher(&caam_rsa);=0A=
>  }=0A=
=0A=
Regards,=0A=
Horia=0A=