Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp4145723ybi; Mon, 27 May 2019 12:06:39 -0700 (PDT) X-Google-Smtp-Source: APXvYqyyCVdcFbXJYfhLguuUjTiqPZMtjIfDZeN3MzSfR+3ZOvYBT7JSI9u6xosUQry965Ek/8rw X-Received: by 2002:a63:4d5d:: with SMTP id n29mr19601954pgl.235.1558983999020; Mon, 27 May 2019 12:06:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558983999; cv=none; d=google.com; s=arc-20160816; b=vaI85lMsP9XlieuuuEUS9VspuyjxOkw4Lp/iAsRtcvrefgplJTj0EmLsaWX4kLul4S jnAIHd4AZnWNFRCyNjHnYuJUhcJpdMSpTJTt+QAe0hNu8NQLsb/w3ahWY7AEURcx/o5N cAw+gi1Ga8oFp+aY/qhOEj3ekCcj+YmKsiMmMH3hAmF/hw26iKJubCkwIyiwAqL0GvSB L1vCSnS0nYT4JICD74gQ9M6dH39AE2Afmxupm+zBA85S7pZxvBQErsyr7idwahI9bcoX 9GKG3KRqXcSjAubLQ2PMuvywUZgTkiXmWaWhU84DO9kH6qIobQvMzUruMYEyJmeoZ90U XxtA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=rhufDIboKVChDbkIK0YFIaJjdJYi0Pr0tqafEUHwVaQ=; b=WHE/h3inJuZwcJd7bI7jx9oIfEDL1+7KCjhdYfWcKru4wZqN5jFkzZHndik5++OIu0 BukPyUdkHLpHTcSUJ8knJ1rIC5E3bVeb2Qr0EIjg0FC1XkGD/RJS7GEtY9h4nP543a5R 3CJy+G/5YJMYjG8/Md6vQiuZiOMtm5sDhJ28JtAkNXSc7HtUzSh0rx0KixZMKB4wfn3p sI6VS1pEt0ZSZLnEVsh4seS6YmQ5e/t7anpMQSFukHAE9uuFnQTD744/YZNBrAbg0rhV THHDuxMhEvn0hdmHRI+fUV+zkDahGmJfQjyFqMvsvL83XkajXZQ0BZBbmvIjaPEZjig+ hMTA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=scvVUhxv; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d2si19675996pld.90.2019.05.27.12.06.20; Mon, 27 May 2019 12:06:38 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=scvVUhxv; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727103AbfE0TGN (ORCPT + 99 others); Mon, 27 May 2019 15:06:13 -0400 Received: from mail.kernel.org ([198.145.29.99]:47302 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726931AbfE0TGN (ORCPT ); Mon, 27 May 2019 15:06:13 -0400 Received: from sol.localdomain (c-24-5-143-220.hsd1.ca.comcast.net [24.5.143.220]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9C58F20859; Mon, 27 May 2019 19:06:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1558983972; bh=lraj2dgvhVGkENZ+SetPaacf8Hlq5WoOdtIC/alYObk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=scvVUhxvxhsmHivcsplQ6YzbNISOlG4+brRSjhTTzT9I/IRXSxAjPhTxNIfX+yn5M NgbKiKxOrUk65nGK/UcAhvxlHYhWMWLcKl9A8CSLJ73422fSbvxVqtCzGRUT6EHE7/ 4rnnyiAEmQXAt63x7u3iSy1+M2ZZmz1eEMQQaE78= Date: Mon, 27 May 2019 12:06:11 -0700 From: Eric Biggers To: Nikolay Borisov Cc: herbert@gondor.apana.org.au, davem@davemloft.net, linux-crypto@vger.kernel.org, terrelln@fb.com, jthumshirn@suse.de Subject: Re: [PATCH] crypto: xxhash - Implement xxhash support Message-ID: <20190527190610.GB9394@sol.localdomain> References: <20190527142810.31472-1-nborisov@suse.com> <20190527183932.GA9394@sol.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190527183932.GA9394@sol.localdomain> User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Mon, May 27, 2019 at 11:39:33AM -0700, Eric Biggers wrote: > > Similarly, the 'out' array might be misaligned. And conventionally the same > bytes are output on all architectures. So I suggest: > > put_unaligned_u64(xxh64_digest(&ctx->xxhstate), out); > I meant to write put_unaligned_le64. - Eric