Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Pascal Van Leeuwen <pvanleeuwen@insidesecure.com>
To:     "antoine.tenart@bootlin.com" <antoine.tenart@bootlin.com>
CC:     Riku Voipio <riku.voipio@linaro.org>,
        "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>
Subject: RE: crypto: inside_secure - call for volunteers
Thread-Topic: crypto: inside_secure - call for volunteers
Thread-Index: AdT/U6NOlHK52506RKGw2EuTDrqaWQABLx+AAAA8mJAAAMUMAALn8IMwAmg1TgAADGhXgA==
Date:   Mon, 27 May 2019 21:06:48 +0000
Message-ID: <AM6PR09MB35237977C0E5FFB566CE3F33D21D0@AM6PR09MB3523.eurprd09.prod.outlook.com>
References: <DBBPR09MB352627DA3C425CECC763B99FD23A0@DBBPR09MB3526.eurprd09.prod.outlook.com>
 <20190430132653.GB3508@kwain>
 <DBBPR09MB352652D305657569DCA6E436D23A0@DBBPR09MB3526.eurprd09.prod.outlook.com>
 <20190430135542.GC3508@kwain>
 <AM6PR09MB3523E393D4EA082FDDBC9251D2090@AM6PR09MB3523.eurprd09.prod.outlook.com>
 <20190527150057.GD8900@kwain>
In-Reply-To: <20190527150057.GD8900@kwain>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: insidesecure.com does not
 designate permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 874b8a3a-78ac-4f68-3f80-08d6e2e73ba4
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 May 2019 21:06:48.5076
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3c07df58-7760-4e85-afd5-84803eac70ce
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: pvanleeuwen@insidesecure.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR09MB2231
Sender: linux-crypto-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

> -----Original Message-----
> From: antoine.tenart@bootlin.com [mailto:antoine.tenart@bootlin.com]
> Sent: Monday, May 27, 2019 5:01 PM
> To: Pascal Van Leeuwen <pvanleeuwen@insidesecure.com>
> Cc: antoine.tenart@bootlin.com; Riku Voipio <riku.voipio@linaro.org>; lin=
ux-
> crypto@vger.kernel.org
> Subject: Re: crypto: inside_secure - call for volunteers
>
<snip>
> Sorry about the looong delay. I did make a quick test of your series and
> had some issues:
> - You added use of PCI helpers, but this new dependency wasn't described
>   in Kconfig (leading to have build issues).
>
Ah OK, to be honest, I don't know a whole lot (or much of anything, actuall=
y)
about Kconfig, so I just hacked it a bit to be able to select the driver :-=
)
But it makes sense - the PCIE subsystem is obviously always present on an
x86 PC, so I'm getting that for free. I guess some Marvell board configs
don't include the PCIE stuff?

I guess the best approach would to config out the PCIE code if the
PCIE subsystem is not configured in (instead of adding the dependency).

> - Using an EIP197 and a MacchiatoBin many of the boot tests did not
>   pass (but I haven't look into it).
>
Actually, if you use driver code from before yesterday with Herbert's
crypto2.6 git tree, then the fuzzing tests would have failed.
I originally developed directly against Linus' 5.1 tree, which apparently
did not contain those fuzzing tests yet.

> I'll perform the test again to at least give you a trace :)
>
Please sync with my Git tree before trying, that should help a lot.

> Btw, I'm available on IRC (atenart on Freenode), that might be easier to
> have a discussion when debugging things.
>
I'll see if I can get some IRC client installed over here.
Haven't used IRC in over a decade, didn't know it still existed ...

Thanks,
Pascal van Leeuwen
Silicon IP Architect, Multi-Protocol Engines @ Inside Secure
www.insidesecure.com