Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Iuliana Prodan <iuliana.prodan@nxp.com>
To:     Herbert Xu <herbert@gondor.apana.org.au>
CC:     Ard Biesheuvel <ard.biesheuvel@linaro.org>,
        Eric Biggers <ebiggers@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Horia Geanta <horia.geanta@nxp.com>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" 
        <linux-crypto@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        dl-linux-imx <linux-imx@nxp.com>
Subject: Re: [PATCH] crypto: gcm - fix cacheline sharing
Thread-Topic: [PATCH] crypto: gcm - fix cacheline sharing
Thread-Index: AQHVFkF/PjPULMOhfkiEXDJZ6fiBzQ==
Date:   Thu, 30 May 2019 13:45:47 +0000
Message-ID: <VI1PR04MB444562A2352FE4BAD7F681258C180@VI1PR04MB4445.eurprd04.prod.outlook.com>
References: <1559149856-7938-1-git-send-email-iuliana.prodan@nxp.com>
 <20190529202728.GA35103@gmail.com>
 <CAKv+Gu-4KqcY=WhwY98JigTzeXaL5ggYEcu7+kNzNtpO2FLQXg@mail.gmail.com>
 <VI1PR04MB44459EEF7BCD3458BB3D143D8C180@VI1PR04MB4445.eurprd04.prod.outlook.com>
 <20190530133427.qrwjzctac2x6nsby@gondor.apana.org.au>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: fdc518eb-467f-48d6-18bc-08d6e5051ecb
X-MS-Exchange-CrossTenant-originalarrivaltime: 30 May 2019 13:45:47.2378
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: iuliana.prodan@nxp.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6304
Sender: linux-crypto-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

On 5/30/2019 4:34 PM, Herbert Xu wrote:=0A=
> On Thu, May 30, 2019 at 01:29:41PM +0000, Iuliana Prodan wrote:=0A=
>>=0A=
>> I've tried coping the IV before the extended descriptor allocation, but=
=0A=
>> is not working and to make it work will need to make more changes in=0A=
>> CAAM. We need the original iv, and if we move it before=0A=
>> skcipher_edesc_alloc we lose it.=0A=
>> The fix exclusively in CAAM drv, to copy iv before DMA map, is more comp=
lex.=0A=
> =0A=
> Why doesn't it work (apart from the fact that this only makes sense=0A=
> for CBC and yet you're doing it for everything including CTR)?=0A=
> =0A=
> Cheers,=0A=
> =0A=
=0A=
On the current structure of caamalg, to work, iv needs to be copied =0A=
before memcpy(iv, req->iv, ivsize), from skcipher_edesc_alloc function. =0A=
For this we need edesc, but this cannot be allocated before knowing how =0A=
much memory we need. So, to make it work, we'll need to modify more in CAAM=
.=0A=
=0A=
Thanks,=0A=
Iulia=0A=