Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Horia Geanta <horia.geanta@nxp.com>
To:     Iuliana Prodan <iuliana.prodan@nxp.com>,
        Ard Biesheuvel <ard.biesheuvel@linaro.org>,
        Herbert Xu <herbert@gondor.apana.org.au>
CC:     Eric Biggers <ebiggers@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        dl-linux-imx <linux-imx@nxp.com>
Subject: Re: [PATCH] crypto: gcm - fix cacheline sharing
Thread-Topic: [PATCH] crypto: gcm - fix cacheline sharing
Thread-Index: AQHVFkF+dOvdDzZqYUSH856vNqfARw==
Date:   Fri, 31 May 2019 05:54:37 +0000
Message-ID: <VI1PR0402MB34858358EB89E8DF051729E598190@VI1PR0402MB3485.eurprd04.prod.outlook.com>
References: <20190529202728.GA35103@gmail.com>
 <CAKv+Gu-4KqcY=WhwY98JigTzeXaL5ggYEcu7+kNzNtpO2FLQXg@mail.gmail.com>
 <VI1PR04MB44459EEF7BCD3458BB3D143D8C180@VI1PR04MB4445.eurprd04.prod.outlook.com>
 <20190530133427.qrwjzctac2x6nsby@gondor.apana.org.au>
 <VI1PR04MB444562A2352FE4BAD7F681258C180@VI1PR04MB4445.eurprd04.prod.outlook.com>
 <CAKv+Gu-jTWQP0Zp=QpuzX41v8Eb5Bvd0O9ajwSnFkDO-ijBf_A@mail.gmail.com>
 <CAKv+Gu9JoC+GKJ6mMAE25mr_k2gbznh-83jApT4=FZsAW=jd8w@mail.gmail.com>
 <20190530142734.qlhgzeal22zxfhk5@gondor.apana.org.au>
 <CAKv+Gu8jJQCZwiHFORUJUzRaAizWzBQ95EAgYe36sFrcvzb6vg@mail.gmail.com>
 <CAKv+Gu-KBgiyNY2Dypx6vqtmpTXNfOxxWxJf50BTiF2rCOFqnw@mail.gmail.com>
 <20190530143438.d62y3woaogyivqpm@gondor.apana.org.au>
 <CAKv+Gu87wkLkZZLfsJwc02yuKpDx7Sa=Nx+1YW8pPE4DoWXGRw@mail.gmail.com>
 <VI1PR04MB44453A74B90C08AF14CED7DE8C180@VI1PR04MB4445.eurprd04.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 362b3f52-8032-4ef8-0e1a-08d6e58c776c
X-MS-Exchange-CrossTenant-originalarrivaltime: 31 May 2019 05:54:37.9817
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: horia.geanta@nxp.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3806
Sender: linux-crypto-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

On 5/31/2019 1:00 AM, Iuliana Prodan wrote:=0A=
> On 5/30/2019 6:05 PM, Ard Biesheuvel wrote:=0A=
>> On Thu, 30 May 2019 at 16:34, Herbert Xu <herbert@gondor.apana.org.au> w=
rote:=0A=
>>>=0A=
>>> On Thu, May 30, 2019 at 04:31:09PM +0200, Ard Biesheuvel wrote:=0A=
>>>>=0A=
>>>> This might work:=0A=
>>>=0A=
>>> Looks good to me.=0A=
>>>=0A=
>>=0A=
>> Thanks Herbert,=0A=
>>=0A=
>> But given your remark regarding CBC being the only algo that has this=0A=
>> requirement, I wonder if this might be sufficient as well.=0A=
>>=0A=
>> diff --git a/drivers/crypto/caam/caamalg.c b/drivers/crypto/caam/caamalg=
.c=0A=
>> index c0ece44f303b..65b050e3742f 100644=0A=
>> --- a/drivers/crypto/caam/caamalg.c=0A=
>> +++ b/drivers/crypto/caam/caamalg.c=0A=
>> @@ -1844,7 +1844,7 @@ static int skcipher_decrypt(struct skcipher_reques=
t *req)=0A=
>>           * The crypto API expects us to set the IV (req->iv) to the las=
t=0A=
>>           * ciphertext block.=0A=
>>           */=0A=
>> -       if (ivsize)=0A=
>> +       if (ctx->cdata.algtype & OP_ALG_AAI_CBC)=0A=
>>                  scatterwalk_map_and_copy(req->iv, req->src, req->cryptl=
en -=0A=
>>                                           ivsize, ivsize, 0);=0A=
>>=0A=
>>=0A=
>> Iulia, Horia?=0A=
>>=0A=
> I can confirm that gcm (and ccm), with ctr-aes-caam, is passing with the =
=0A=
> above fix.=0A=
> =0A=
The check should be:=0A=
	if ((ctx->cdata.algtype & OP_ALG_AAI_MASK) =3D=3D OP_ALG_AAI_CBC)=0A=
=0A=
Having this workaround is probably ok, until we properly fix the IV update =
for=0A=
CTR mode.=0A=
=0A=
Thanks,=0A=
Horia=0A=