Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp4650840ybi; Mon, 3 Jun 2019 14:48:04 -0700 (PDT) X-Google-Smtp-Source: APXvYqzzxH7we7Y9aG/U+E+xNCKOf/AaqAnzBxsk4LfY3Up33RPSTZQckZMTwU6tv9rOm28F4Lt4 X-Received: by 2002:a17:90a:2201:: with SMTP id c1mr32805115pje.10.1559598484174; Mon, 03 Jun 2019 14:48:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559598484; cv=none; d=google.com; s=arc-20160816; b=P3FAT16PxZCj5HgeCTgl1960+fNKa4wNFCygxTnVKPW72v6tR5ioI2NLeYFYpPwT4X DWFsd789FOgRgJT15kxPNJuXrshRKg7x5RicASnjMi7FJrvTPVpNaQIwcOJBHfpNS5zd 7q2bYb2PSjYE/ztKunnHxPnEK/cvLNFbsT67Bh0jkw6k5cyXpOh/p0wv2O7AJrrrELq8 Doh59OpwX7bRLfft0KppzUIngZLXW6RPjBxxI2C1TzVbywz/2SG1s3x8hYRNNioNfv+7 9IZ8jHtBtUdwqA/au9zCfRkpR7xtKq3UwHmOVukzuWyizganUJQG0bIsOu6xaiMCbfxU kn2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=sCXxsnovqLIih6k+4oG252vB5441/yEZceVwE9165Hg=; b=DySH2gxEcAKussb+QWa+qnq63ffp+MmH1YZGO7ozRkfHZfXy5BaIdhjkRfXw9hm5yi tWHFnT8lgnePyUB1qTaqtDr7x9wnXRitBDii8JW9U/OOyxKEcx1X8v9UqPaghJW+H4kc 9/nfHeSF26d8kqWjGsx/NK1mWxmOXkeZXHkGk6bCXHqY5WqI3oMJpnph49+qmFIA+hz0 zGlrtV00giv17qTT/iJNeBf+eAW4/10iQS33HuSGMdVlZqUJtt+XSgwdBQ9sy9ZjvuXr 7LOl9lTZN6PGCrjdVVA6xbbY1fIrGaSbAZp7yhNQQLp6P40M3Ws9YPqBOCqRqphmsoYN izyw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=2cBL6VGl; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i1si19265783pgs.324.2019.06.03.14.47.44; Mon, 03 Jun 2019 14:48:04 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=2cBL6VGl; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726522AbfFCVra (ORCPT + 99 others); Mon, 3 Jun 2019 17:47:30 -0400 Received: from mail.kernel.org ([198.145.29.99]:37636 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726595AbfFCVr3 (ORCPT ); Mon, 3 Jun 2019 17:47:29 -0400 Received: from akpm3.svl.corp.google.com (unknown [104.133.8.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 16FFB23CB8; Mon, 3 Jun 2019 21:47:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559598449; bh=dDw/l+09r2MaBLjcFFfJjSPZLvE2heCBtLMWGhQ6pBg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=2cBL6VGl6XPWx4El6h15JzACuh5Z0gGbMRGYppoMPJRfkSGgQhgWdgORMBN9uih7i 9F+FK8cz+WhuxjRCYmkQ0JhZXMg6JqAzleSBlLqw3c1DAIKtJhW6bGZuFpNfX7x6LH a935NDfathGNEhNKsfhBdRJm7z4wEb2LJ9FlJvU4= Date: Mon, 3 Jun 2019 14:47:28 -0700 From: Andrew Morton To: Maninder Singh Cc: herbert@gondor.apana.org.au, davem@davemloft.net, keescook@chromium.org, gustavo@embeddedor.com, joe@perches.com, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, a.sahrawat@samsung.com, pankaj.m@samsung.com, v.narang@samsung.com Subject: Re: [PATCH 3/4] zstd: move params structure to global variable to reduce stack usage Message-Id: <20190603144728.1f89a4264170aa612365fc2a@linux-foundation.org> In-Reply-To: <1559552526-4317-4-git-send-email-maninder1.s@samsung.com> References: <1559552526-4317-1-git-send-email-maninder1.s@samsung.com> <1559552526-4317-4-git-send-email-maninder1.s@samsung.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Mon, 3 Jun 2019 14:32:05 +0530 Maninder Singh wrote: > > Subject: [PATCH 3/4] zstd: move params structure to global variable to reduce stack usage If this affected lib/zstd/ I'd be alarmed. But it's a client of lib/zstd that is choosing to have a single kernel-wide copy. I'll rewrite this patch title to "crypto/zstd.c: ...".