Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp5855449ybi; Tue, 4 Jun 2019 13:32:03 -0700 (PDT) X-Google-Smtp-Source: APXvYqxYZ9jZA5BqM7w/yzoY50BxWrvqf6eG9Y3K5zsRPeaLjdWp7+aRrAYyHzffNSOgt+YQ8r0n X-Received: by 2002:a62:5b81:: with SMTP id p123mr41057390pfb.158.1559680323865; Tue, 04 Jun 2019 13:32:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559680323; cv=none; d=google.com; s=arc-20160816; b=YdIEtsK7D4hSsCQDdnoSnrWMr6CNGSecLEeesQyrXi9k6ZlIp6S7ec8tN5/542p47Z NRjWlAp28wRwt7aopmnAJiNt2fq4V3hyNTOH7+rYHFxxpwJCeKoit/PKEqkHNNQwqfDS DjQG8mF6plobTMC2QmeD/R/Z8O/ZzUPhC5HDyiKzDrxf0aGCT9rXWMxVBPMwU/MjgTiE dO2aoUH52BwyGNs3nWVcWajBGd9S7atlXs1VTewnCQDd0cAa4NtekAWxPgk1WVkAleu0 g7jEmwUpuw/RBn/Mk+Crh+2+/dYaaKQCLyUrsuzcscAWLw99c/R9/+cJkDFgdpEI5Ujw nkDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=GzsSZ1ZIthsTf/ARuWnJotXGJcL1/H1KE/r2e1NtQfo=; b=GByS325DtXPLSuO7ukoj3Hl55zgfgmGiOGAT0NHnemZTSEJWgTuxmovJEEEX1Hd2qE J4yuh7MLbECIE3Up3H6NF6+6zabIKVtDBLcMjo5ZnbB3+bygInNJIuMxIbYAeFZEvjDU TLPLYjKabbc8ktGKHqCPAwK3fg2uz46rJzCxIMHlxfi9EckTXl7alTqpg0oXnVMsopZS xG84oOVahTg7TztQubjbYj1QfoJ7LlqrAPm6fbNofDvfn5qFxGgUHMu8U2b67OeyzUiB z8ZGlYAIQxfaaRKwFtsNbnBNpicZ449mDIJVKUEAKFYyAKTVt75Bja7jLYeyEijfXAfq x4mA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amazon.com header.s=amazon201209 header.b=GFf+gvPC; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amazon.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n11si25082363plp.361.2019.06.04.13.31.40; Tue, 04 Jun 2019 13:32:03 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@amazon.com header.s=amazon201209 header.b=GFf+gvPC; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amazon.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726238AbfFDUbe (ORCPT + 99 others); Tue, 4 Jun 2019 16:31:34 -0400 Received: from smtp-fw-4101.amazon.com ([72.21.198.25]:38164 "EHLO smtp-fw-4101.amazon.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726343AbfFDUbd (ORCPT ); Tue, 4 Jun 2019 16:31:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1559680292; x=1591216292; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version; bh=GzsSZ1ZIthsTf/ARuWnJotXGJcL1/H1KE/r2e1NtQfo=; b=GFf+gvPC5OjeN+RnHydK4L6zMymsVL+bhPh5KFU+KyXvxjnmbdxOfB03 cmS1f6ZMQb9oepK9iPv8sG5wgGloF/ghI1FNvDeyHZ+wiL2ewtxMjo3ac kz2ei5cuNgXpWx+PIUeVeVk0e6qEj/1kYpeB9RwIzcrQF282f0LuIiUvh Q=; X-IronPort-AV: E=Sophos;i="5.60,550,1549929600"; d="scan'208";a="768961315" Received: from iad6-co-svc-p1-lb1-vlan3.amazon.com (HELO email-inbound-relay-2c-168cbb73.us-west-2.amazon.com) ([10.124.125.6]) by smtp-border-fw-out-4101.iad4.amazon.com with ESMTP; 04 Jun 2019 20:31:30 +0000 Received: from EX13MTAUWB001.ant.amazon.com (pdx1-ws-svc-p6-lb9-vlan3.pdx.amazon.com [10.236.137.198]) by email-inbound-relay-2c-168cbb73.us-west-2.amazon.com (Postfix) with ESMTPS id 93C8CA2297; Tue, 4 Jun 2019 20:31:29 +0000 (UTC) Received: from EX13D02UWB004.ant.amazon.com (10.43.161.11) by EX13MTAUWB001.ant.amazon.com (10.43.161.207) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Tue, 4 Jun 2019 20:31:29 +0000 Received: from EX13MTAUWA001.ant.amazon.com (10.43.160.58) by EX13D02UWB004.ant.amazon.com (10.43.161.11) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Tue, 4 Jun 2019 20:31:29 +0000 Received: from dev-dsk-alisaidi-i31e-4ac69482.us-east-1.amazon.com (10.200.136.151) by mail-relay.amazon.com (10.43.160.118) with Microsoft SMTP Server id 15.0.1367.3 via Frontend Transport; Tue, 4 Jun 2019 20:31:29 +0000 Received: by dev-dsk-alisaidi-i31e-4ac69482.us-east-1.amazon.com (Postfix, from userid 5131138) id A3E6847DE7; Tue, 4 Jun 2019 20:31:28 +0000 (UTC) From: Ali Saidi To: , , CC: Catalin Marinas , Will Deacon , Matt Mackall , Herbert Xu , Arnd Bergmann , "Greg Kroah-Hartman" , Ali Saidi , Ron Rindjunsky , Benjamin Herrenschmidt , David Woodhouse Subject: [PATCH 3/3] hwrng: Add support for AWS Graviton TRNG Date: Tue, 4 Jun 2019 20:31:00 +0000 Message-ID: <20190604203100.15050-4-alisaidi@amazon.com> X-Mailer: git-send-email 2.15.3.AMZN In-Reply-To: <20190604203100.15050-1-alisaidi@amazon.com> References: <20190604203100.15050-1-alisaidi@amazon.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org AWS Graviton based systems provide an Arm SMC call in the vendor defined hypervisor region to read random numbers from a TRNG and return them to the guest. Co-developed-by: Ron Rindjunsky Signed-off-by: Ali Saidi Signed-off-by: Ron Rindjunsky --- MAINTAINERS | 6 ++ drivers/char/hw_random/Kconfig | 13 ++++ drivers/char/hw_random/Makefile | 1 + drivers/char/hw_random/graviton-rng.c | 130 ++++++++++++++++++++++++++++++++++ 4 files changed, 150 insertions(+) create mode 100644 drivers/char/hw_random/graviton-rng.c diff --git a/MAINTAINERS b/MAINTAINERS index 005902ea1450..e9c490e3fd9d 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2771,6 +2771,12 @@ S: Maintained F: Documentation/devicetree/bindings/iio/adc/avia-hx711.txt F: drivers/iio/adc/hx711.c +AWS GRAVITON TRNG DRIVER +M: Ali Saidi +L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers) +S: Supported +F: drivers/char/hw_random/graviton-rng.c + AX.25 NETWORK LAYER M: Ralf Baechle L: linux-hams@vger.kernel.org diff --git a/drivers/char/hw_random/Kconfig b/drivers/char/hw_random/Kconfig index 25a7d8ffdb5d..7ca7386a1ac4 100644 --- a/drivers/char/hw_random/Kconfig +++ b/drivers/char/hw_random/Kconfig @@ -439,6 +439,19 @@ config HW_RANDOM_OPTEE If unsure, say Y. +config HW_RANDOM_GRAVITON + tristate "AWS Graviton Random Number Generator support" + depends on HW_RANDOM && ACPI && (ARM64 || COMPILE_TEST) + default HW_RANDOM + help + This driver provides kernel-side support for the Random Number + Generator SMC found on AWS Graviton systems. + + To compile this driver as a module, choose M here: the + module will be called graviton-rng. + + If unsure, say Y. + endif # HW_RANDOM config UML_RANDOM diff --git a/drivers/char/hw_random/Makefile b/drivers/char/hw_random/Makefile index 7c9ef4a7667f..d1fa72670e98 100644 --- a/drivers/char/hw_random/Makefile +++ b/drivers/char/hw_random/Makefile @@ -39,3 +39,4 @@ obj-$(CONFIG_HW_RANDOM_MTK) += mtk-rng.o obj-$(CONFIG_HW_RANDOM_S390) += s390-trng.o obj-$(CONFIG_HW_RANDOM_KEYSTONE) += ks-sa-rng.o obj-$(CONFIG_HW_RANDOM_OPTEE) += optee-rng.o +obj-$(CONFIG_HW_RANDOM_GRAVITON) += graviton-rng.o diff --git a/drivers/char/hw_random/graviton-rng.c b/drivers/char/hw_random/graviton-rng.c new file mode 100644 index 000000000000..898c8bb98a20 --- /dev/null +++ b/drivers/char/hw_random/graviton-rng.c @@ -0,0 +1,130 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * AWS Graviton TRNG driver + * + * Copyright (C) 2019 Amazon Corp. + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#define AWS_GRAVITON_UUID \ + ARM_SMCCC_CALL_VAL(ARM_SMCCC_FAST_CALL, ARM_SMCCC_SMC_32, \ + ARM_SMCCC_OWNER_VENDOR_HV, 0xFF01) +#define AWS_GRAVITON_GET_VER \ + ARM_SMCCC_CALL_VAL(ARM_SMCCC_FAST_CALL, ARM_SMCCC_SMC_32, \ + ARM_SMCCC_OWNER_VENDOR_HV, 0xFF03) +#define AWS_GRAVITON_GET_RND \ + ARM_SMCCC_CALL_VAL(ARM_SMCCC_FAST_CALL, ARM_SMCCC_SMC_64, \ + ARM_SMCCC_OWNER_VENDOR_HV, 0) + +/** + * UID of the Graviton TRNG API: 1b64036c-badc-483e-99d23e283f067bdd + */ +#define GRVTN_TRNG_UUID_0 0x6c03641b +#define GRVTN_TRNG_UUID_1 0x3e48dcba +#define GRVTN_TRNG_UUID_2 0x283ed299 +#define GRVTN_TRNG_UUID_3 0xdd7b063f + +static void grvtn_smccc_conduit(u64 call_id, struct arm_smccc_res *res) +{ + if (acpi_psci_use_hvc()) + arm_smccc_1_1_hvc(call_id, res); + else + arm_smccc_1_1_smc(call_id, res); +} + +static int grvtn_trng_read(struct hwrng *trng, void *buf, size_t max, bool wait) +{ + struct arm_smccc_res res; + int err = 0; + /* timeout after one waiting period */ + int iter_remain = 2; + size_t count = max > sizeof(ulong) * 2 ? sizeof(ulong) * 2 : max; + size_t total = count; + + do { + if (err && wait) + /* Nominal wait is 5us */ + udelay(err); + + grvtn_smccc_conduit(AWS_GRAVITON_GET_RND, &res); + err = (int) res.a0; + + if (err < 0) + return err; + + iter_remain--; + } while (iter_remain && err && wait); + + if (err) + return 0; + + if (count > sizeof(ulong)) { + memcpy(buf, &res.a1, sizeof(ulong)); + count -= sizeof(ulong); + buf += sizeof(ulong); + } + memcpy(buf, &res.a2, count); + return total; +} + +static int grvtn_trng_probe(struct platform_device *pdev) +{ + int err; + struct arm_smccc_res res; + static struct hwrng ops = { + .name = "graviton", + .read = grvtn_trng_read, + .quality = 1024, /* all bits are sourced from a HW TRNG */ + }; + + grvtn_smccc_conduit(AWS_GRAVITON_UUID, &res); + + if (res.a0 != GRVTN_TRNG_UUID_0 || res.a1 != GRVTN_TRNG_UUID_1 || + res.a2 != GRVTN_TRNG_UUID_2 || res.a3 != GRVTN_TRNG_UUID_3) { + dev_err(&pdev->dev, "failed to match UUID\n"); + return -ENXIO; + } + + grvtn_smccc_conduit(AWS_GRAVITON_GET_VER, &res); + dev_info(&pdev->dev, "Graviton TRNG, SMC version %d.%d\n", + (u32)res.a0, (u32)res.a1); + + platform_set_drvdata(pdev, &ops); + err = devm_hwrng_register(&pdev->dev, &ops); + if (err) + dev_err(&pdev->dev, "failed to register hwrng"); + return err; +} + +static const struct acpi_device_id grvtn_trng_acpi_match[] = { + { "AMZN0010", }, + {} +}; + +MODULE_DEVICE_TABLE(acpi, grvtn_trng_acpi_match); + +static struct platform_driver grvtn_trng_driver = { + .probe = grvtn_trng_probe, + .driver = { + .name = "graviton-rng", + .owner = THIS_MODULE, + .acpi_match_table = ACPI_PTR(grvtn_trng_acpi_match), + }, +}; + +module_platform_driver(grvtn_trng_driver); + +MODULE_AUTHOR("Amazon.com, Inc. or it's affiliates"); +MODULE_DESCRIPTION("Graviton TRNG driver"); +MODULE_LICENSE("GPL v2"); -- 2.15.3.AMZN