Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp5734722ybi; Wed, 12 Jun 2019 07:36:19 -0700 (PDT) X-Google-Smtp-Source: APXvYqwlEUYvib3GfgSU16kHa67h3lbWK8WDlxo7hQTIF0Fs22KkvEKvsi+GJakxQqcUhk3d6a2O X-Received: by 2002:a17:902:306:: with SMTP id 6mr83078419pld.148.1560350179228; Wed, 12 Jun 2019 07:36:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560350179; cv=none; d=google.com; s=arc-20160816; b=eAxjQqj1NPb0ZUgcl1fYX77TaUFw2VP7CdW2o6VfpfzZILAN3bfmRVD+hbMONeBQFp CL6hwZjhxPi1MMJHcogaO9gZmnO2Rexmp3mJnMA++UB1cRo0MeeL/fD28rl27NA5vvnz uRi6UMGViWb7YIvfVnsjQBl4YrFgwWvlXB0F9+h7FjagMbNpKDp5na06fsY9PRxdo3f2 bWCqsHF0DJzsyIpkc9lfnXxg2vUEcwQp2+S5TXkFWVr6AZRxYtMs4oXkPct10NRn46CT QwapIxiL5oV0rAwsU22py2L7WPsoa6fIF6A57uFw00G8cPtYcOiCSCE1GOBHoKCx/VRq mG/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=gYTDF8qqiBZLIUMP2GXzObWmc8hhmW0Ct8AbgeJYzlI=; b=YsnX5kNswqRTYzkL4/vxG6Lz37f70ehf39F1vgcKuTMYBbSpyo1Moc3B+SXZseUehB 3yDctVlZwZ0/ZLuwhgVUe+O8O9tcqZzXCrtAk0ZmszvjKuxyIs39vI3kf4AuNBdVI8lq 9YaBNVQI1CutJ4uD7rtGVKjCOPylg9D4KI4xyYnddVoAtTk1JTI3GRgIO76gIFDVOce2 uEePG/GaRME97vXtB/Glv+J+cRpoOGQs8nYBfgJDVbao4W4qK8/Cc6WWGG7aIGs8GUQI s4B2RWUIL+lqtyQ3aPcefB8b8GBhYraI6/CrGS4hXDFXQZZznPfw9YzdXUOHeWlA2F7p 2xFQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o9si16168264pfe.126.2019.06.12.07.36.04; Wed, 12 Jun 2019 07:36:19 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2408075AbfFLKXA (ORCPT + 99 others); Wed, 12 Jun 2019 06:23:00 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33240 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2407987AbfFLKW7 (ORCPT ); Wed, 12 Jun 2019 06:22:59 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 792A82F8BD6; Wed, 12 Jun 2019 10:22:59 +0000 (UTC) Received: from t460s.redhat.com (ovpn-116-159.ams2.redhat.com [10.36.116.159]) by smtp.corp.redhat.com (Postfix) with ESMTP id 56FA160CCC; Wed, 12 Jun 2019 10:22:57 +0000 (UTC) From: David Hildenbrand To: linux-kernel@vger.kernel.org Cc: linux-s390@vger.kernel.org, linux-crypto@vger.kernel.org, David Hildenbrand , Herbert Xu , "David S. Miller" , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Harald Freudenberger , Cornelia Huck Subject: [PATCH v2 3/4] s390/crypto: prng: Use -ENODEV instead of -EOPNOTSUPP Date: Wed, 12 Jun 2019 12:22:47 +0200 Message-Id: <20190612102248.18903-4-david@redhat.com> In-Reply-To: <20190612102248.18903-1-david@redhat.com> References: <20190612102248.18903-1-david@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Wed, 12 Jun 2019 10:22:59 +0000 (UTC) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Let's use the error value that is typically used if HW support is not available when trying to load a module - this is also what systemd's systemd-modules-load.service expects. Signed-off-by: David Hildenbrand --- arch/s390/crypto/prng.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/s390/crypto/prng.c b/arch/s390/crypto/prng.c index 12cca467af7d..d977643fa627 100644 --- a/arch/s390/crypto/prng.c +++ b/arch/s390/crypto/prng.c @@ -824,7 +824,7 @@ static int __init prng_init(void) /* check if the CPU has a PRNG */ if (!cpacf_query_func(CPACF_KMC, CPACF_KMC_PRNG)) - return -EOPNOTSUPP; + return -ENODEV; /* check if TRNG subfunction is available */ if (cpacf_query_func(CPACF_PRNO, CPACF_PRNO_TRNG)) @@ -837,7 +837,7 @@ static int __init prng_init(void) if (prng_mode == PRNG_MODE_SHA512) { pr_err("The prng module cannot " "start in SHA-512 mode\n"); - return -EOPNOTSUPP; + return -ENODEV; } prng_mode = PRNG_MODE_TDES; } else -- 2.21.0