Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp5734791ybi; Wed, 12 Jun 2019 07:36:24 -0700 (PDT) X-Google-Smtp-Source: APXvYqyI8148MXjb/YnAfcbPzbhnG+ziJCLI3sE6sBjtU4/4q5rVxJN/soqpmPbq5+4Agbt2MPg3 X-Received: by 2002:a63:db4e:: with SMTP id x14mr26416578pgi.119.1560350184494; Wed, 12 Jun 2019 07:36:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560350184; cv=none; d=google.com; s=arc-20160816; b=Gd9JJIpJpBOeraSe5+2tniE6/rgL2ilgzSDpB+h9CO6yL4uuj8zh28tFf7DtcMpwGH LRjXL4dKn4Rt2V9Ct6+gXrx9XLFPq5f2De7MnP+t1B6thTgcQXYOL8cQNZteo0MiubG5 VJs9PAIjfE7xPFpLzG/2pPE1gU8efYCFtqKsMSaS4B5yFAGcYxgQtRywPmf8ftSSQEmy ik1dTmCBqXlH7O41yKG0oL1wvIlgYr8gJBzX1oA/ZS4PORkpoW+OTgDm73X0luB9KlCN 6s9Ws1ZqLXt8utqFkmKhRaGz5owJOfzbV3wJrxB5fbsPGk7GQ0ur4zq2DEK7ct7z5y84 SOAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=A/a4mZS/tUlINtdSSK9z1ic7Y/4uF2SoLDiMyImbmQE=; b=bLpLh5gYsxYLdB85dyRX0YT2s37h1oGlaCkI3n2bwalnFidUGQ7wWkmff10NTisTiv pfLXOkA75xuJU4TX19KA9PtoCn9/w8gb+dv3LgSOMweXcOfKwSiBDH3KxRb4MVtcrJh3 TTsUBR5FV3oSsVN1axphDB3tI7w3sLWNr33QTCU5/2VOPRcOCpzvZm6wl5LfQi0FE1gD vr45NjqK2yAvBdNIMA0Dx6gGQ0VzJHUGtrmgIJDyDOm9vBITMktMBc4aTBnBYwG/KKGa izg1IlQlLLSV7mVlOC6C1aoI8NSxzeLr4RZrmqyAY/Mr86NVqhFUODX/SIh4yTPhXcrE uRfQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id cd17si18014961plb.210.2019.06.12.07.36.10; Wed, 12 Jun 2019 07:36:24 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2407987AbfFLKXF (ORCPT + 99 others); Wed, 12 Jun 2019 06:23:05 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44202 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2407254AbfFLKXE (ORCPT ); Wed, 12 Jun 2019 06:23:04 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 21158C0587F5; Wed, 12 Jun 2019 10:23:04 +0000 (UTC) Received: from t460s.redhat.com (ovpn-116-159.ams2.redhat.com [10.36.116.159]) by smtp.corp.redhat.com (Postfix) with ESMTP id C4D3560CCC; Wed, 12 Jun 2019 10:22:59 +0000 (UTC) From: David Hildenbrand To: linux-kernel@vger.kernel.org Cc: linux-s390@vger.kernel.org, linux-crypto@vger.kernel.org, David Hildenbrand , Herbert Xu , "David S. Miller" , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Harald Freudenberger , Cornelia Huck Subject: [PATCH v2 4/4] s390/crypto: sha: Use -ENODEV instead of -EOPNOTSUPP Date: Wed, 12 Jun 2019 12:22:48 +0200 Message-Id: <20190612102248.18903-5-david@redhat.com> In-Reply-To: <20190612102248.18903-1-david@redhat.com> References: <20190612102248.18903-1-david@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Wed, 12 Jun 2019 10:23:04 +0000 (UTC) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Let's use the error value that is typically used if HW support is not available when trying to load a module - this is also what systemd's systemd-modules-load.service expects. Signed-off-by: David Hildenbrand --- arch/s390/crypto/sha1_s390.c | 2 +- arch/s390/crypto/sha256_s390.c | 2 +- arch/s390/crypto/sha512_s390.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/s390/crypto/sha1_s390.c b/arch/s390/crypto/sha1_s390.c index 009572e8276d..7c15542d3685 100644 --- a/arch/s390/crypto/sha1_s390.c +++ b/arch/s390/crypto/sha1_s390.c @@ -86,7 +86,7 @@ static struct shash_alg alg = { static int __init sha1_s390_init(void) { if (!cpacf_query_func(CPACF_KIMD, CPACF_KIMD_SHA_1)) - return -EOPNOTSUPP; + return -ENODEV; return crypto_register_shash(&alg); } diff --git a/arch/s390/crypto/sha256_s390.c b/arch/s390/crypto/sha256_s390.c index 62833a1d8724..af7505148f80 100644 --- a/arch/s390/crypto/sha256_s390.c +++ b/arch/s390/crypto/sha256_s390.c @@ -117,7 +117,7 @@ static int __init sha256_s390_init(void) int ret; if (!cpacf_query_func(CPACF_KIMD, CPACF_KIMD_SHA_256)) - return -EOPNOTSUPP; + return -ENODEV; ret = crypto_register_shash(&sha256_alg); if (ret < 0) goto out; diff --git a/arch/s390/crypto/sha512_s390.c b/arch/s390/crypto/sha512_s390.c index be589c340d15..ad29db085a18 100644 --- a/arch/s390/crypto/sha512_s390.c +++ b/arch/s390/crypto/sha512_s390.c @@ -127,7 +127,7 @@ static int __init init(void) int ret; if (!cpacf_query_func(CPACF_KIMD, CPACF_KIMD_SHA_512)) - return -EOPNOTSUPP; + return -ENODEV; if ((ret = crypto_register_shash(&sha512_alg)) < 0) goto out; if ((ret = crypto_register_shash(&sha384_alg)) < 0) -- 2.21.0