Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp5742480ybi; Wed, 12 Jun 2019 07:44:20 -0700 (PDT) X-Google-Smtp-Source: APXvYqxzyoW0I4aRGDHeWkqRCH6xgOU5AzvZuhmCh8BGM+eLaA4iHwgsuVpBdjlhcXWdBu523iqP X-Received: by 2002:a17:902:2a28:: with SMTP id i37mr80030228plb.52.1560350660527; Wed, 12 Jun 2019 07:44:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560350660; cv=none; d=google.com; s=arc-20160816; b=bdN80qHx3qlFiT9hk6N0a+/FxhK6eiWff+aMM/pfqllhZkMhaY2dlyJr+AChZiv8mq t6fpx5GaVcbneucMONzN/RW3MuBv1zNlGsUGjJvGFP3maOnyZwnZoeZT0Bfx7vgqAAZ2 HVwe2RE4bUsm001SbP+cR4jQx/4O1oUt5b4Aad4H+ngFfC3bkiDtkvMq4QGIeyec3o4o FR8pfZ1YWo1Rh2VcT3Qkkwo1fbj/AeeyUwjxMEe+T2IxMg0zSCfz+qnNbKmhtrKLZ6Ay LLtEh2p7uqXiSJNGoZRIfzzPhtuplnVgkBKeygpan+20x625qjcgHy7jHj7NdTpV6loE u/IA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :from:references:cc:to:subject; bh=KR9AnoMyycDc1bbgIt0gxOgwUdNvZqFSOnpjQ+Bu4PE=; b=iZGaauHt9c4N9pwBOoCzi8ALxlxuadR83hRwndc83RJGrgd8ijfPQvFImqXVfz0dCn 3LNeS9/V99QDY4+oGtL12SdEOTDT6LyM2h2U17vyoseP5LAm2bKdz89QBwCW1JNIKFT1 yMcToArBncmiBq5EOzppMHm5WFpwimnaq7Hm4YUf4yfgTZNQDovwZW5DqKPvHbB4ZCbd jgABaoagH5Mc8PDs8rFI/P5ORGw/CMMtm7igzpnF1LluR2drVjfNKwLnNpGXvojYBsDK MRjSlmm8kZcfDcaUr/GayH82OQMMDsLCPqKE3BuBfHn4WP5DhUmMGSLNzWkGqIeKBRds hQEw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i41si79894pje.45.2019.06.12.07.44.06; Wed, 12 Jun 2019 07:44:20 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732255AbfFLKbv (ORCPT + 99 others); Wed, 12 Jun 2019 06:31:51 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:50714 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732253AbfFLKbv (ORCPT ); Wed, 12 Jun 2019 06:31:51 -0400 Received: from pps.filterd (m0098394.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x5CATG2w069284 for ; Wed, 12 Jun 2019 06:31:50 -0400 Received: from e06smtp03.uk.ibm.com (e06smtp03.uk.ibm.com [195.75.94.99]) by mx0a-001b2d01.pphosted.com with ESMTP id 2t2x8wuu7p-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 12 Jun 2019 06:31:49 -0400 Received: from localhost by e06smtp03.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 12 Jun 2019 11:31:47 +0100 Received: from b06cxnps3075.portsmouth.uk.ibm.com (9.149.109.195) by e06smtp03.uk.ibm.com (192.168.101.133) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Wed, 12 Jun 2019 11:31:44 +0100 Received: from d06av24.portsmouth.uk.ibm.com (mk.ibm.com [9.149.105.60]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x5CAVgJZ36307046 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 12 Jun 2019 10:31:42 GMT Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A87224204B; Wed, 12 Jun 2019 10:31:42 +0000 (GMT) Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1D4D342049; Wed, 12 Jun 2019 10:31:42 +0000 (GMT) Received: from [10.0.2.15] (unknown [9.145.62.239]) by d06av24.portsmouth.uk.ibm.com (Postfix) with ESMTP; Wed, 12 Jun 2019 10:31:42 +0000 (GMT) Subject: Re: [PATCH v2 2/4] s390/crypto: ghash: Use -ENODEV instead of -EOPNOTSUPP To: David Hildenbrand , linux-kernel@vger.kernel.org Cc: linux-s390@vger.kernel.org, linux-crypto@vger.kernel.org, Herbert Xu , "David S. Miller" , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Cornelia Huck References: <20190612102248.18903-1-david@redhat.com> <20190612102248.18903-3-david@redhat.com> From: Harald Freudenberger Date: Wed, 12 Jun 2019 12:31:42 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190612102248.18903-3-david@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US X-TM-AS-GCONF: 00 x-cbid: 19061210-0012-0000-0000-00000328731B X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19061210-0013-0000-0000-000021617A67 Message-Id: <9853af8c-fa55-8128-fffb-b48579174e67@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-06-12_05:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1906120073 Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On 12.06.19 12:22, David Hildenbrand wrote: > Let's use the error value that is typically used if HW support is not > available when trying to load a module - this is also what systemd's > systemd-modules-load.service expects. > > Signed-off-by: David Hildenbrand > --- > arch/s390/crypto/ghash_s390.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/s390/crypto/ghash_s390.c b/arch/s390/crypto/ghash_s390.c > index 86aed30fad3a..eeeb6a7737a4 100644 > --- a/arch/s390/crypto/ghash_s390.c > +++ b/arch/s390/crypto/ghash_s390.c > @@ -137,7 +137,7 @@ static struct shash_alg ghash_alg = { > static int __init ghash_mod_init(void) > { > if (!cpacf_query_func(CPACF_KIMD, CPACF_KIMD_GHASH)) > - return -EOPNOTSUPP; > + return -ENODEV; > > return crypto_register_shash(&ghash_alg); > } fine with me Reviewed-by: Harald Freudenberger