Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp5746198ybi; Wed, 12 Jun 2019 07:48:12 -0700 (PDT) X-Google-Smtp-Source: APXvYqy/b7jGkKuMDGGTNoJDaJX2J94VXct2h9lf+Enf3xAQlfmcKD25cYLo8u7k+wr6MUV9J4fK X-Received: by 2002:a65:518d:: with SMTP id h13mr24310135pgq.186.1560350892149; Wed, 12 Jun 2019 07:48:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560350892; cv=none; d=google.com; s=arc-20160816; b=fXtueG0n2pOfXxpyaXkULlMc3GRDznJKrb6gh3hEcRPY91S2xcLUjyd6QNl3qEzYIA nm0qUXgi30MZQVt4Ru13N3qTLv/eNIbyq2nSXk+NVokNZ0JI2Wa8MFOyRyIGbXmbkM5S a4RqIiUbUOUKCBHZy1ksHMibess81IDYayNkyCaiqU3OVmj7rVeQ8Ozv2Q2Wl/I5Wqi4 eaei5A9ACE1Lfo8tQ1UND4Y2H0UzkKFYaES1UlrhRDvkgu86r1IkPeh8bTTe9fvukkRo KuZfv0BVeUA1zbksOjxaeKPoyX3aaMky1g1kJUFu5RBJ92LR5jkX6oZrbYvfba8JIVfb IBDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:organization:autocrypt:openpgp:from:references:cc:to :subject; bh=+Ypr65is1vMmkHdUIqNyBjZKZGzAQWYmCNA6VERx8cY=; b=iNOjrfRZiHlXYuO5JZ1gZ+gRPGzqb6X0xd88U6mtqHxPQOhyBqXWrWWfyAy6DX8F70 e4uauNChANdq0T9AmcG8vib4QX06Fnf6H0DYd7OFk4xjtxnWqDoQuHeeok5riR7xbEGS XTVbeEVPt6h0D5Ac3dZA8JJd9kAca/4rR6Fd3wWw9nrpVkEQfAVpjOx0vTiGKXm6Rg8g RfpaUAIWeuqv7KLmLu6zD5UP33PmPyDWCeZXcL5bdmiJs4oqL053tLSTichYymBcuIYm etvMTkPhlvPN/+3f22JMSkqGznGRqzIs1bQgTtHZF5LJAsPa0MGfdZziT+4+wxJbkiqD Kvhw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v188si1422pfb.132.2019.06.12.07.47.58; Wed, 12 Jun 2019 07:48:12 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2407095AbfFLKlY (ORCPT + 99 others); Wed, 12 Jun 2019 06:41:24 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44276 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2403978AbfFLKlX (ORCPT ); Wed, 12 Jun 2019 06:41:23 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id EB605307D863; Wed, 12 Jun 2019 10:41:22 +0000 (UTC) Received: from [10.36.116.159] (ovpn-116-159.ams2.redhat.com [10.36.116.159]) by smtp.corp.redhat.com (Postfix) with ESMTP id C09621001B0D; Wed, 12 Jun 2019 10:41:20 +0000 (UTC) Subject: Re: [PATCH v2 1/4] s390/pkey: Use -ENODEV instead of -EOPNOTSUPP To: Harald Freudenberger , linux-kernel@vger.kernel.org Cc: linux-s390@vger.kernel.org, linux-crypto@vger.kernel.org, Herbert Xu , "David S. Miller" , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Cornelia Huck References: <20190612102248.18903-1-david@redhat.com> <20190612102248.18903-2-david@redhat.com> <7f313d87-f9ea-e291-49e2-8da29cf41680@linux.ibm.com> From: David Hildenbrand Openpgp: preference=signencrypt Autocrypt: addr=david@redhat.com; prefer-encrypt=mutual; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwX4EEwECACgFAljj9eoCGwMFCQlmAYAGCwkI BwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEE3eEPcA/4Na5IIP/3T/FIQMxIfNzZshIq687qgG 8UbspuE/YSUDdv7r5szYTK6KPTlqN8NAcSfheywbuYD9A4ZeSBWD3/NAVUdrCaRP2IvFyELj xoMvfJccbq45BxzgEspg/bVahNbyuBpLBVjVWwRtFCUEXkyazksSv8pdTMAs9IucChvFmmq3 jJ2vlaz9lYt/lxN246fIVceckPMiUveimngvXZw21VOAhfQ+/sofXF8JCFv2mFcBDoa7eYob s0FLpmqFaeNRHAlzMWgSsP80qx5nWWEvRLdKWi533N2vC/EyunN3HcBwVrXH4hxRBMco3jvM m8VKLKao9wKj82qSivUnkPIwsAGNPdFoPbgghCQiBjBe6A75Z2xHFrzo7t1jg7nQfIyNC7ez MZBJ59sqA9EDMEJPlLNIeJmqslXPjmMFnE7Mby/+335WJYDulsRybN+W5rLT5aMvhC6x6POK z55fMNKrMASCzBJum2Fwjf/VnuGRYkhKCqqZ8gJ3OvmR50tInDV2jZ1DQgc3i550T5JDpToh dPBxZocIhzg+MBSRDXcJmHOx/7nQm3iQ6iLuwmXsRC6f5FbFefk9EjuTKcLMvBsEx+2DEx0E UnmJ4hVg7u1PQ+2Oy+Lh/opK/BDiqlQ8Pz2jiXv5xkECvr/3Sv59hlOCZMOaiLTTjtOIU7Tq 7ut6OL64oAq+zsFNBFXLn5EBEADn1959INH2cwYJv0tsxf5MUCghCj/CA/lc/LMthqQ773ga uB9mN+F1rE9cyyXb6jyOGn+GUjMbnq1o121Vm0+neKHUCBtHyseBfDXHA6m4B3mUTWo13nid 0e4AM71r0DS8+KYh6zvweLX/LL5kQS9GQeT+QNroXcC1NzWbitts6TZ+IrPOwT1hfB4WNC+X 2n4AzDqp3+ILiVST2DT4VBc11Gz6jijpC/KI5Al8ZDhRwG47LUiuQmt3yqrmN63V9wzaPhC+ xbwIsNZlLUvuRnmBPkTJwwrFRZvwu5GPHNndBjVpAfaSTOfppyKBTccu2AXJXWAE1Xjh6GOC 8mlFjZwLxWFqdPHR1n2aPVgoiTLk34LR/bXO+e0GpzFXT7enwyvFFFyAS0Nk1q/7EChPcbRb hJqEBpRNZemxmg55zC3GLvgLKd5A09MOM2BrMea+l0FUR+PuTenh2YmnmLRTro6eZ/qYwWkC u8FFIw4pT0OUDMyLgi+GI1aMpVogTZJ70FgV0pUAlpmrzk/bLbRkF3TwgucpyPtcpmQtTkWS gDS50QG9DR/1As3LLLcNkwJBZzBG6PWbvcOyrwMQUF1nl4SSPV0LLH63+BrrHasfJzxKXzqg rW28CTAE2x8qi7e/6M/+XXhrsMYG+uaViM7n2je3qKe7ofum3s4vq7oFCPsOgwARAQABwsFl BBgBAgAPBQJVy5+RAhsMBQkJZgGAAAoJEE3eEPcA/4NagOsP/jPoIBb/iXVbM+fmSHOjEshl KMwEl/m5iLj3iHnHPVLBUWrXPdS7iQijJA/VLxjnFknhaS60hkUNWexDMxVVP/6lbOrs4bDZ NEWDMktAeqJaFtxackPszlcpRVkAs6Msn9tu8hlvB517pyUgvuD7ZS9gGOMmYwFQDyytpepo YApVV00P0u3AaE0Cj/o71STqGJKZxcVhPaZ+LR+UCBZOyKfEyq+ZN311VpOJZ1IvTExf+S/5 lqnciDtbO3I4Wq0ArLX1gs1q1XlXLaVaA3yVqeC8E7kOchDNinD3hJS4OX0e1gdsx/e6COvy qNg5aL5n0Kl4fcVqM0LdIhsubVs4eiNCa5XMSYpXmVi3HAuFyg9dN+x8thSwI836FoMASwOl C7tHsTjnSGufB+D7F7ZBT61BffNBBIm1KdMxcxqLUVXpBQHHlGkbwI+3Ye+nE6HmZH7IwLwV W+Ajl7oYF+jeKaH4DZFtgLYGLtZ1LDwKPjX7VAsa4Yx7S5+EBAaZGxK510MjIx6SGrZWBrrV TEvdV00F2MnQoeXKzD7O4WFbL55hhyGgfWTHwZ457iN9SgYi1JLPqWkZB0JRXIEtjd4JEQcx +8Umfre0Xt4713VxMygW0PnQt5aSQdMD58jHFxTk092mU+yIHj5LeYgvwSgZN4airXk5yRXl SE+xAvmumFBY Organization: Red Hat GmbH Message-ID: <53936c66-ca09-98a7-4c3c-eae8c6024887@redhat.com> Date: Wed, 12 Jun 2019 12:41:19 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <7f313d87-f9ea-e291-49e2-8da29cf41680@linux.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.48]); Wed, 12 Jun 2019 10:41:23 +0000 (UTC) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On 12.06.19 12:39, Harald Freudenberger wrote: > On 12.06.19 12:22, David Hildenbrand wrote: >> systemd-modules-load.service automatically tries to load the pkey module >> on systems that have MSA. >> >> Pkey also requires the MSA3 facility and a bunch of subfunctions. >> Failing with -EOPNOTSUPP makes "systemd-modules-load.service" fail on >> any system that does not have all needed subfunctions. For example, >> when running under QEMU TCG (but also on systems where protected keys >> are disabled via the HMC). >> >> Let's use -ENODEV, so systemd-modules-load.service properly ignores >> failing to load the pkey module because of missing HW functionality. >> >> Reviewed-by: Cornelia Huck >> Signed-off-by: David Hildenbrand >> --- >> drivers/s390/crypto/pkey_api.c | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/s390/crypto/pkey_api.c b/drivers/s390/crypto/pkey_api.c >> index 45eb0c14b880..ddfcefb47284 100644 >> --- a/drivers/s390/crypto/pkey_api.c >> +++ b/drivers/s390/crypto/pkey_api.c >> @@ -1695,15 +1695,15 @@ static int __init pkey_init(void) >> * are able to work with protected keys. >> */ >> if (!cpacf_query(CPACF_PCKMO, &pckmo_functions)) >> - return -EOPNOTSUPP; >> + return -ENODEV; >> >> /* check for kmc instructions available */ >> if (!cpacf_query(CPACF_KMC, &kmc_functions)) >> - return -EOPNOTSUPP; >> + return -ENODEV; >> if (!cpacf_test_func(&kmc_functions, CPACF_KMC_PAES_128) || >> !cpacf_test_func(&kmc_functions, CPACF_KMC_PAES_192) || >> !cpacf_test_func(&kmc_functions, CPACF_KMC_PAES_256)) >> - return -EOPNOTSUPP; >> + return -ENODEV; >> >> pkey_debug_init(); >> > You missed one match in this file. Function pkey_clr2protkey() > also does a cpacf_test_func() and may return -EOPNOTSUPP. > I checked the call chain, it's save to change the returncode there also. That's unrelated to module loading (if I am not wrong), shall we still include this change here? Thanks! > If done, Thanks and add my > reviewed-by: Harald Freudenberger > -- Thanks, David / dhildenb