Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp5939319ybi; Wed, 12 Jun 2019 11:03:41 -0700 (PDT) X-Google-Smtp-Source: APXvYqwTMrvGLWv/SLsv2BCHpSldw8NTvj/rhGya6CjJZ6yKN70k00h4ejh8e5LzhmUHDKfsdevq X-Received: by 2002:a17:902:a60d:: with SMTP id u13mr14313947plq.144.1560362621820; Wed, 12 Jun 2019 11:03:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560362621; cv=none; d=google.com; s=arc-20160816; b=UgaJfmW0qXlAE1LqWMM1cj+paxN32SLpL3vMQL190IFC6qWRR+hrHJxInE4gccyX8B 5HmPIILQt5xpmEXzus9xvTLnrEFefDVD+BIJYAFORKq9oaOCKS9Hiy0Zq2EsdPmLjo2O 5Kty0HBdCnHpHR67kUOZX9Hqp3fNMe6Og9AH8EyXeGHdc6fby1foQ0DXEltYhuVhQfJm eYiRGW5hpSYihHlm57xP8CQZQRVPi8brn8tmQfkmDqZryHEEx8YeDEtcR12DHpJwOMkH ripH77VRwP2xjrYKo3Ersm/ljxynIcCOEKy3xsUhnJq53E+uIgtJlZ4D5vwM3zopI5Y8 Ov3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:in-reply-to :content-disposition:mime-version:references:subject:cc:to:from:date; bh=aKDILxbCfuCF6MEVOzo7LkODOidro3O3aJngjxi/ytU=; b=rnG8LzAdWBvrj1xBtRepLyyq8QVMF35CjQH0GGCNTYZ1uL6G5zDCUkSnLuMb2PODlD Xuikj82FreihfTfSQwDDZlquvPMWDU6qUNXjuMrzmEQRdJVut+MZaVHAbDQj2/l0WAle uxjaY+0fS3bwLAcB/bl0662EZruzof41ZoykHOj4ZBl/cLucU1XwQjde06ZaKQJFKyav 3LZa7KJ7JQ1OJMzvDKhi1U9hmNpvOuLCNi0R4EpdIAKlYEujF6PSYqZVr1nNDjBJWPAk 9b6AC1Eaq6EephchQLCUg7/9qCqB72V42+xuCVHr76SPDNjQfpYRP5OJDbjSoeS6UH+Y vQ+w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c138si398895pfc.285.2019.06.12.11.03.27; Wed, 12 Jun 2019 11:03:41 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2439977AbfFLPKe (ORCPT + 99 others); Wed, 12 Jun 2019 11:10:34 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:50210 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2436492AbfFLPKd (ORCPT ); Wed, 12 Jun 2019 11:10:33 -0400 Received: from pps.filterd (m0098421.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x5CFAW2Q128163 for ; Wed, 12 Jun 2019 11:10:32 -0400 Received: from e06smtp02.uk.ibm.com (e06smtp02.uk.ibm.com [195.75.94.98]) by mx0a-001b2d01.pphosted.com with ESMTP id 2t33mt8h1e-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 12 Jun 2019 11:09:11 -0400 Received: from localhost by e06smtp02.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 12 Jun 2019 16:09:09 +0100 Received: from b06cxnps3074.portsmouth.uk.ibm.com (9.149.109.194) by e06smtp02.uk.ibm.com (192.168.101.132) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Wed, 12 Jun 2019 16:08:53 +0100 Received: from d06av21.portsmouth.uk.ibm.com (d06av21.portsmouth.uk.ibm.com [9.149.105.232]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x5CF8qKU27787328 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 12 Jun 2019 15:08:52 GMT Received: from d06av21.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 214F85204E; Wed, 12 Jun 2019 15:08:52 +0000 (GMT) Received: from osiris (unknown [9.152.212.21]) by d06av21.portsmouth.uk.ibm.com (Postfix) with ESMTPS id AFDCF52052; Wed, 12 Jun 2019 15:08:51 +0000 (GMT) Date: Wed, 12 Jun 2019 17:08:50 +0200 From: Heiko Carstens To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, linux-crypto@vger.kernel.org, Herbert Xu , "David S. Miller" , Vasily Gorbik , Christian Borntraeger , Harald Freudenberger , Cornelia Huck Subject: Re: [PATCH v3 0/4] s390/crypto: Use -ENODEV instead of -EOPNOTSUPP References: <20190612133306.10231-1-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190612133306.10231-1-david@redhat.com> X-TM-AS-GCONF: 00 x-cbid: 19061215-0008-0000-0000-000002F327F4 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19061215-0009-0000-0000-000022602A52 Message-Id: <20190612150850.GA4038@osiris> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-06-12_09:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=857 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1906120102 Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Wed, Jun 12, 2019 at 03:33:02PM +0200, David Hildenbrand wrote: > s390x crypto is one of the rare modules that returns -EOPNOTSUPP instead of > -ENODEV in case HW support is not available. > > Convert to -ENODEV, so e.g., systemd's systemd-modules-load.service > ignores this error properly. > > v2 -> v3: > - "s390/pkey: Use -ENODEV instead of -EOPNOTSUPP" > -- Also convert pkey_clr2protkey() as requested by Harald > - Add r-b's (thanks!) > > v1 -> v2: > - Include > -- "s390/crypto: ghash: Use -ENODEV instead of -EOPNOTSUPP" > -- "s390/crypto: prng: Use -ENODEV instead of -EOPNOTSUPP" > -- "s390/crypto: sha: Use -ENODEV instead of -EOPNOTSUPP" > > Cc: Herbert Xu > Cc: "David S. Miller" > Cc: Heiko Carstens > Cc: Vasily Gorbik > Cc: Christian Borntraeger > Cc: Harald Freudenberger > Cc: Cornelia Huck > > David Hildenbrand (4): > s390/pkey: Use -ENODEV instead of -EOPNOTSUPP > s390/crypto: ghash: Use -ENODEV instead of -EOPNOTSUPP > s390/crypto: prng: Use -ENODEV instead of -EOPNOTSUPP > s390/crypto: sha: Use -ENODEV instead of -EOPNOTSUPP Should I pick these up so they can go upstream via the s390 tree?