Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190614140122.20934-1-ard.biesheuvel@linaro.org>
 <CANn89iKP2fQ6Tc0jBW_WdLq3kYQx7NsdVDB5S3y453T+6yp86g@mail.gmail.com> <dcae85a5-9782-ab4c-c079-1d06675ea4b7@akamai.com>
In-Reply-To: <dcae85a5-9782-ab4c-c079-1d06675ea4b7@akamai.com>
From:   Eric Dumazet <edumazet@google.com>
Date:   Fri, 14 Jun 2019 08:51:33 -0700
Message-ID: <CANn89iKUtN3gO1rndW-2yNsOZian4OngnLUxLWqfo4VRb73-kA@mail.gmail.com>
Subject: Re: [PATCH v2] net: ipv4: move tcp_fastopen server side code to
 SipHash library
To:     Jason Baron <jbaron@akamai.com>
Cc:     Ard Biesheuvel <ard.biesheuvel@linaro.org>,
        netdev <netdev@vger.kernel.org>, linux-crypto@vger.kernel.org,
        Herbert Xu <herbert@gondor.apana.org.au>, ebiggers@kernel.org,
        David Miller <davem@davemloft.net>,
        Christoph Paasch <cpaasch@apple.com>,
        David Laight <David.Laight@aculab.com>,
        Yuchung Cheng <ycheng@google.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-crypto-owner@vger.kernel.org
Precedence: bulk

On Fri, Jun 14, 2019 at 8:44 AM Jason Baron <jbaron@akamai.com> wrote:
>
>
>
>
> The inconsistencies coming from kernel version skew with some servers
> being on the old hash and some on the newer one? Or is there another
> source for the inconsistency you are referring to?
>

The servers still using the old crypto hash, and the new servers using
the new siphash,
will generate different fastopen cookies, even if fed with the same
key (shared secret
among all the server farm)