Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp2298876ybi; Mon, 17 Jun 2019 02:21:22 -0700 (PDT) X-Google-Smtp-Source: APXvYqwkv/WH5Wgo+oEzDbYQfyGAuS5y/5DVgsHQl+pdt3t7yDAGZAphSb/tBxAbypRR1qGdZnbH X-Received: by 2002:a63:d415:: with SMTP id a21mr29839352pgh.229.1560763282009; Mon, 17 Jun 2019 02:21:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560763282; cv=none; d=google.com; s=arc-20160816; b=csHftqHJbnVSWVqpMj28muBRwtrrKbtOCBRBNHwg3QaR5NmJi0fX52DFL+0D9rYVVl Rk3/xJAFqjY5pXlAPOR/KanNrqCpzNR+BcRn8xe+ROOxj6ndphnPA/ggoKgBMnRTrRCv FaFO0upfmbCGpA0tZQXprVeMjdLsKOQ7Cp6Y/YacgzKu5oMnBqZ1nvWAeZ/k3Hzz4eNM 9nvIaF+wNGd8U4nuCf0AW6VoZoiCTyedICQ03HAzqoywZbHt/wVj4bi6O/G/6Nb7MZ7v HBTO8ZowRP9KdU7iTIT9v3ZaRfIMcKjLXPug2k/XgDOHa1VBpriPNuVkiYj7HTwbWPws sq9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=GLHlJooBgdt3MVSmrXUUYDNhkSJMsf+C3VylkPWIRcs=; b=rkidXp0//nZiG4UklNoEmzJLb/hkFmUNfXeWe8Q9WMPsYRkPAQiiHKghAhyLA9ex0f 3jMUo3ZvXB5oTRf2JHEHkIgX1v64SvmS1AAcTBUvhsPWUTwtN/UVYnHz/Y5P2/SlGz2j f7nAmHRopRC+4JjzeRbd1qFHC8zlO7TyezjZ92r+Q4M27g7KQzwkaKexrTS/6YXX9KRx LELVf2l+OJsQbJZjZJYxPkuYBpo7EVkDmqZPlIHNjN2vhGWXbJ0Vy/0zQhWtQ64TtXr8 kEORfmHezXzrWeCrRpqnRzkPv/8wyz90ljjxF/x5fOxjyPnm4h3IckxE7k2SqyPN0oNm dIkA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r17si10241136pga.205.2019.06.17.02.21.07; Mon, 17 Jun 2019 02:21:21 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727829AbfFQJUY (ORCPT + 99 others); Mon, 17 Jun 2019 05:20:24 -0400 Received: from helcar.hmeau.com ([216.24.177.18]:50208 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726286AbfFQJUY (ORCPT ); Mon, 17 Jun 2019 05:20:24 -0400 Received: from gondobar.mordor.me.apana.org.au ([192.168.128.4] helo=gondobar) by deadmen.hmeau.com with esmtps (Exim 4.89 #2 (Debian)) id 1hcnoF-0002oC-C3; Mon, 17 Jun 2019 17:20:15 +0800 Received: from herbert by gondobar with local (Exim 4.89) (envelope-from ) id 1hcnoD-0002j8-1s; Mon, 17 Jun 2019 17:20:13 +0800 Date: Mon, 17 Jun 2019 17:20:13 +0800 From: Herbert Xu To: Ard Biesheuvel Cc: Gilad Ben-Yossef , Eric Biggers , Linux Crypto Mailing List , device-mapper development , linux-fscrypt@vger.kernel.org Subject: Re: [RFC PATCH 0/3] crypto: switch to shash for ESSIV generation Message-ID: <20190617092012.gk7wrazxh7bwfmjk@gondor.apana.org.au> References: <20190614083404.20514-1-ard.biesheuvel@linaro.org> <20190616204419.GE923@sol.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Mon, Jun 17, 2019 at 11:15:01AM +0200, Ard Biesheuvel wrote: > > Ah yes, thanks for reminding me. There was some debate in the past > about this, but I don't remember the details. I think there were some controversy regarding whether the resulting code lived in drivers/md or crypto. I think as long as drivers/md is the only user of the said code then having it in drivers/md should be fine. However, if we end up using/reusing the same code for others such as fs/crypto then it might make more sense to have them in crypto. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt