Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Leonard Crestez <leonard.crestez@nxp.com>
To:     Andrey Smirnov <andrew.smirnov@gmail.com>,
        "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
        Horia Geanta <horia.geanta@nxp.com>
CC:     Chris Spencer <christopher.spencer@sea.co.uk>,
        Cory Tusar <cory.tusar@zii.aero>,
        Chris Healy <cphealy@gmail.com>,
        Lucas Stach <l.stach@pengutronix.de>,
        Aymen Sghaier <aymen.sghaier@nxp.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 4/5] crypto: caam - simplfy clock initialization
Thread-Topic: [PATCH v3 4/5] crypto: caam - simplfy clock initialization
Thread-Index: AQHVJSZJSx98FK+FPUqkFei6+EQfcQ==
Date:   Mon, 17 Jun 2019 19:48:05 +0000
Message-ID: <VI1PR04MB50556DE0057E1B5802E0DAA1EEEB0@VI1PR04MB5055.eurprd04.prod.outlook.com>
References: <20190617160339.29179-1-andrew.smirnov@gmail.com>
 <20190617160339.29179-5-andrew.smirnov@gmail.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 255a00c3-ff97-4223-f7f1-08d6f35cb751
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Jun 2019 19:48:05.5888
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: leonard.crestez@nxp.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7056
Sender: linux-crypto-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

On 6/17/2019 7:04 PM, Andrey Smirnov wrote:=0A=
> Simplify clock initialization code by converting it to use clk-bulk,=0A=
> devres and soc_device_match() match table. No functional change=0A=
> intended.=0A=
=0A=
Subject is misspelled.=0A=
=0A=
> +struct clk_bulk_caam {=0A=
> +	const struct clk_bulk_data *clks;=0A=
> +	int num_clks;=0A=
> +};=0A=
=0A=
clks could be an array[0] at the end to avoid an additional allocation.=0A=
=0A=
> +static void disable_clocks(void *private)=0A=
> +{=0A=
> +	struct clk_bulk_caam *context =3D private;=0A=
> +=0A=
> +	clk_bulk_disable_unprepare(context->num_clks,=0A=
> +				   (struct clk_bulk_data *)context->clks);=0A=
> +}=0A=
=0A=
Not sure using devm for this is worthwhile. Maybe someday CAAM clks will =
=0A=
be enabled dynamically?=0A=
=0A=
It would be make sense to reference "clk" instead of "clocks".=0A=
=0A=
> +static int init_clocks(struct device *dev,=0A=
> +		       const struct clk_bulk_caam *data)=0A=
> +{=0A=
> +	struct clk_bulk_data *clks;=0A=
> +	struct clk_bulk_caam *context;=0A=
> +	int num_clks;=0A=
> +	int ret;=0A=
> +=0A=
> +	num_clks =3D data->num_clks;=0A=
> +	clks =3D devm_kmemdup(dev, data->clks,=0A=
> +			    data->num_clks * sizeof(data->clks[0]),=0A=
> +			    GFP_KERNEL);=0A=
> +	if (!clks)=0A=
> +		return -ENOMEM;=0A=
> +=0A=
> +	ret =3D devm_clk_bulk_get(dev, num_clks, clks);=0A=
> +	if (ret) {=0A=
> +		dev_err(dev,=0A=
> +			"Failed to request all necessary clocks\n");=0A=
> +		return ret;=0A=
> +	}=0A=
> +=0A=
> +	ret =3D clk_bulk_prepare_enable(num_clks, clks);=0A=
> +	if (ret) {=0A=
> +		dev_err(dev,=0A=
> +			"Failed to prepare/enable all necessary clocks\n");=0A=
> +		return ret;=0A=
> +	}=0A=
> +=0A=
> +	context =3D devm_kzalloc(dev, sizeof(*context), GFP_KERNEL);=0A=
> +	if (!context)=0A=
> +		return -ENOMEM;=0A=
=0A=
Aren't clks left enabled if this fails? Can move this allocation higher.=0A=
=0A=
> +	context->num_clks =3D num_clks;=0A=
> +	context->clks =3D clks;=0A=
> +=0A=
> +	ret =3D devm_add_action_or_reset(dev, disable_clocks, context);=0A=
> +	if (ret)=0A=
> +		return ret;=0A=
> +=0A=
> +	return 0;=0A=
> +}=0A=
=0A=
>   static int caam_probe(struct platform_device *pdev)=0A=
>   {=0A=
>   	int ret, ring, gen_sk, ent_delay =3D RTSDCTL_ENT_DLY_MIN;=0A=
>   	u64 caam_id;=0A=
> -	static const struct soc_device_attribute imx_soc[] =3D {=0A=
> -		{.family =3D "Freescale i.MX"},=0A=
> -		{},=0A=
> -	};=0A=
> +	const struct soc_device_attribute *soc_attr;=0A=
=0A=
This "soc_attr" is difficult to understand, maybe rename to something =0A=
like "imx_soc_match"?=0A=