Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp2994010ybi; Mon, 17 Jun 2019 14:15:29 -0700 (PDT) X-Google-Smtp-Source: APXvYqysvNGvaNc3bLn+yiEuSTxSNzEjV4YVGWzoOEVIy0NPmlThVdPOPNTKazWuyIOkVUKcaeMq X-Received: by 2002:a17:90a:9bc5:: with SMTP id b5mr1077644pjw.109.1560806129509; Mon, 17 Jun 2019 14:15:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560806129; cv=none; d=google.com; s=arc-20160816; b=Oux8b/8hX8Y67tB80RUcfFXfSyyF0qYmh9DRzhyDB6+Yj8pAFauGFJjQ9uE5/5SdYK 5lxJr5X/qjvIUSUmzPT/E4M5GDq75rDVt5S60wso6ngAPLhCLc9oyLOdgOwkfbz7J4nv kjfiPHRs4vacpX6tAQOf/ktghCf05V5hcfZ9rujO7+e+GgeV2CMDlu7JuGnlpPbKIBJI 4RzfQBnKIxKYVpDe7uU5fwskDoOf0Gpv1yf5JYTXIADaoMHrcTlomMzIXDju717VLuSy KhLfBPCCi3yIRehfGEtUXQAJT71IazvjOhA5iNOFI0Nw3kPhoREnB8BYZPsHlZJ3PGvs LdCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:cc:to:subject:from:message-id :dkim-signature; bh=Uizg+dGN8017PnN4ZAyywblqDxVcxym+3ZkN7RKGtQM=; b=ZLNqU+OTtexzacev5SlbGW2FlaOiuHsz5UEv8aUemShdOpY7ryPVp95MlS0iUa1dSx kQ7ttBJswBC0xEHJRtOQEg068u8of/RsDmCVxwhkQWnyDckVWWQhUC9ai3drfn2H9wUV IGU9Y9/BfVLS6nZtaic+dVWoJcs/U2VfY2VA4f7ti+MMtu2UpboYKVHfsODmLdv8TOz0 23kNGEh9Jgvt5dq/GumltJaDoHBRTJy+IITdp3CUh19MRSQlTVdC3nw9TbAPEMkCtLTO 72rRT64qXyZkrhGWEWKl6ZvnxFnPqCgh7vognl8Z+mMTL0sm5r9MJBtBn2kAn+YuUU7g Iuyg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@c-s.fr header.s=mail header.b=pgd9wIX3; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g90si11112726plb.282.2019.06.17.14.15.15; Mon, 17 Jun 2019 14:15:29 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@c-s.fr header.s=mail header.b=pgd9wIX3; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727057AbfFQVPF (ORCPT + 99 others); Mon, 17 Jun 2019 17:15:05 -0400 Received: from pegase1.c-s.fr ([93.17.236.30]:61005 "EHLO pegase1.c-s.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725497AbfFQVPE (ORCPT ); Mon, 17 Jun 2019 17:15:04 -0400 Received: from localhost (mailhub1-int [192.168.12.234]) by localhost (Postfix) with ESMTP id 45SP9y2mTMz9v32g; Mon, 17 Jun 2019 23:15:02 +0200 (CEST) Authentication-Results: localhost; dkim=pass reason="1024-bit key; insecure key" header.d=c-s.fr header.i=@c-s.fr header.b=pgd9wIX3; dkim-adsp=pass; dkim-atps=neutral X-Virus-Scanned: Debian amavisd-new at c-s.fr Received: from pegase1.c-s.fr ([192.168.12.234]) by localhost (pegase1.c-s.fr [192.168.12.234]) (amavisd-new, port 10024) with ESMTP id dkqtFHq9PhHm; Mon, 17 Jun 2019 23:15:02 +0200 (CEST) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase1.c-s.fr (Postfix) with ESMTP id 45SP9y1h31z9v32f; Mon, 17 Jun 2019 23:15:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=c-s.fr; s=mail; t=1560806102; bh=Uizg+dGN8017PnN4ZAyywblqDxVcxym+3ZkN7RKGtQM=; h=From:Subject:To:Cc:Date:From; b=pgd9wIX3TC3d2tQIcoTE6XBcruTzMiQ22GOMyP7r9jRjXz1sm49tvTcQgkPH55dYO t6C8oMR1a0VGHUEM8/ujTd9eOdpqkfwFSF1MGPp+TvbifclfiiFzOa61vVp3LQX5WE t/WYtpQfcBrMw1frxmG+DhXph+VUwt18/uPS53G8= Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 743E78B84B; Mon, 17 Jun 2019 23:15:02 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id ybEdG8lFwJWw; Mon, 17 Jun 2019 23:15:02 +0200 (CEST) Received: from po16838vm.idsi0.si.c-s.fr (unknown [192.168.4.90]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 3BA818B7FF; Mon, 17 Jun 2019 23:15:02 +0200 (CEST) Received: by localhost.localdomain (Postfix, from userid 0) id E4AC8682B3; Mon, 17 Jun 2019 21:15:01 +0000 (UTC) Message-Id: From: Christophe Leroy Subject: [PATCH v4 0/4] Additional fixes on Talitos driver To: Herbert Xu , "David S. Miller" , horia.geanta@nxp.com Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Date: Mon, 17 Jun 2019 21:15:01 +0000 (UTC) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org This series is the last set of fixes for the Talitos driver. We now get a fully clean boot on both SEC1 (SEC1.2 on mpc885) and SEC2 (SEC2.2 on mpc8321E) with CONFIG_CRYPTO_MANAGER_EXTRA_TESTS: [ 3.385197] bus: 'platform': really_probe: probing driver talitos with device ff020000.crypto [ 3.450982] random: fast init done [ 12.252548] alg: No test for authenc(hmac(md5),cbc(aes)) (authenc-hmac-md5-cbc-aes-talitos-hsna) [ 12.262226] alg: No test for authenc(hmac(md5),cbc(des3_ede)) (authenc-hmac-md5-cbc-3des-talitos-hsna) [ 43.310737] Bug in SEC1, padding ourself [ 45.603318] random: crng init done [ 54.612333] talitos ff020000.crypto: fsl,sec1.2 algorithms registered in /proc/crypto [ 54.620232] driver: 'talitos': driver_bound: bound to device 'ff020000.crypto' [ 1.193721] bus: 'platform': really_probe: probing driver talitos with device b0030000.crypto [ 1.229197] random: fast init done [ 2.714920] alg: No test for authenc(hmac(sha224),cbc(aes)) (authenc-hmac-sha224-cbc-aes-talitos) [ 2.724312] alg: No test for authenc(hmac(sha224),cbc(aes)) (authenc-hmac-sha224-cbc-aes-talitos-hsna) [ 4.482045] alg: No test for authenc(hmac(md5),cbc(aes)) (authenc-hmac-md5-cbc-aes-talitos) [ 4.490940] alg: No test for authenc(hmac(md5),cbc(aes)) (authenc-hmac-md5-cbc-aes-talitos-hsna) [ 4.500280] alg: No test for authenc(hmac(md5),cbc(des3_ede)) (authenc-hmac-md5-cbc-3des-talitos) [ 4.509727] alg: No test for authenc(hmac(md5),cbc(des3_ede)) (authenc-hmac-md5-cbc-3des-talitos-hsna) [ 6.631781] random: crng init done [ 11.521795] talitos b0030000.crypto: fsl,sec2.2 algorithms registered in /proc/crypto [ 11.529803] driver: 'talitos': driver_bound: bound to device 'b0030000.crypto' v2: dropped patch 1 which was irrelevant due to a rebase weirdness. Added Cc to stable on the 2 first patches. v3: - removed stable reference in patch 1 - reworded patch 1 to include name of patch 2 for the dependency. - mentionned this dependency in patch 2 as well. - corrected the Fixes: sha1 in patch 4 v4: - using scatterwalk_ffwd() instead of opencodying SG list forwarding. - Added a patch to fix sg_copy_to_buffer() when sg->offset() is greater than PAGE_SIZE, otherwise sg_copy_to_buffer() fails when the list has been forwarded with scatterwalk_ffwd(). - taken the patch "crypto: talitos - eliminate unneeded 'done' functions at build time" out of the series because it is independent. - added a helper to find the header field associated to a request in flush_channe() Christophe Leroy (4): lib/scatterlist: Fix mapping iterator when sg->offset is greater than PAGE_SIZE crypto: talitos - move struct talitos_edesc into talitos.h crypto: talitos - fix hash on SEC1. crypto: talitos - drop icv_ool drivers/crypto/talitos.c | 102 +++++++++++++++++++---------------------------- drivers/crypto/talitos.h | 28 +++++++++++++ lib/scatterlist.c | 9 ++++- 3 files changed, 76 insertions(+), 63 deletions(-) -- 2.13.3