Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp3549866ybi; Tue, 18 Jun 2019 02:37:49 -0700 (PDT) X-Google-Smtp-Source: APXvYqxTmOn4RVzD4f92zd1x08cmMTkIZ8F6JOr5gMSB13UQgIgUmQ+onEYv1DtyU/oqVFoxSFwh X-Received: by 2002:a65:5945:: with SMTP id g5mr1788906pgu.169.1560850669652; Tue, 18 Jun 2019 02:37:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560850669; cv=none; d=google.com; s=arc-20160816; b=CGf2y8TuCEO410FMESU4nAz2L19sNKy6fl9s/hkbM1PFH9tdgi4oW8H4BdswOHZ3vT lNys4UXAlyvi94CRFfg3sg7diBSRDeQ8z81ibWlYg86aX6gWSFTFKwMIw2t+HgXk0gug D099Wi4BvtcmncFvsb5nKruvmcN7U/1+qa30mrxKczIpbgi8lKt+QjDEKj2wEo+xgPdx SlAxJEy0CIhJubOjVF+wP/hoS4vbym/fVU5efj3SDcK+CCYNlWvW3q4YCsbDfZrg02bv G7WptsnDR0C64Tlny1ugwYIiwPMbkl70/fOgZhOCAjJdWrOXAF4yMcYUohq87VLPEUA6 Xdeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=KnB6xK4HiQoJS5/13fsK8xxNIgyVPR5SQYTgXV9IFVg=; b=uoYZkQdy1TuQULUjL1IpOA8QxXUnWJE7wspYmceyZrOpGVad+CFqSCb6dFz6zP+ysC n/CDqVoLaChUQp3dnkfWVQtkmWHyt9WPxoWdXJnNh0ZnZr7cktAbsZAEze7w8Vs5MD9/ rXxPNXipk1kn9f7ZFIJEsRyEbuq8vHrLIDbUHjU4l1Kf9MsYDENSnp4kDiKuXzvXwkO+ 6dz7/wkNvbAnbtGFIQnYKsDiSMbQmZabU6ZvjRRkTpVbGs20V8Dj0P7/zghGFlY+sXAS MFQdhxRPLRW0pBo63zkkkHK5g5AfjV93ad5mIX96+PjoQYOHeyy4gnfd9Ote5AS3Kz+R HYcw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=WLhARJow; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b5si1887034pjo.26.2019.06.18.02.37.34; Tue, 18 Jun 2019 02:37:49 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=WLhARJow; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729267AbfFRJh3 (ORCPT + 99 others); Tue, 18 Jun 2019 05:37:29 -0400 Received: from mail-yb1-f193.google.com ([209.85.219.193]:34167 "EHLO mail-yb1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729113AbfFRJh3 (ORCPT ); Tue, 18 Jun 2019 05:37:29 -0400 Received: by mail-yb1-f193.google.com with SMTP id x32so1509235ybh.1 for ; Tue, 18 Jun 2019 02:37:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=KnB6xK4HiQoJS5/13fsK8xxNIgyVPR5SQYTgXV9IFVg=; b=WLhARJowtoGMcEvJRAnKSywn8KHofN+Bj8GZJT2bzMsrTwt/5+QY8YHcQ89VdWvqi1 Cfz9SoLmtn7gwCmULSi9859h6+B8KTAOdC2J6iQC5TkBwlDgkTqkTgkCZng+feqgRqh/ K1YXPkWJ59jMZed7P8fvjOuAJBB36/YgwRpRQEdhn/NnWcyb5clNX5wRaflHcMIV+XS+ 5rmkHC4f9CVjoLNdAPU0fPLaDsP4/XjfI9eptJLWFs/W5woXifjhmRzIyhMk1PQypij0 lkZ4e46ttOu0dkjwIdEGYzpMr5iVnhcmf6YC7yIEJsdCRae1Caw6hvvxGXvIZHZorxWl /blw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KnB6xK4HiQoJS5/13fsK8xxNIgyVPR5SQYTgXV9IFVg=; b=UQazXW8Vs8G2kDuEvNhqmh6AMwJVV9htX9nIT2/NYkqK2eqtX0kYRJEv4YsbFE3cbB kCKihSAb18Tyu2X5V1C8WR8I9ZuIqQjOu79F4sRZdus69qG4Ts6S7TAIeAapYjjwqnoF GD6cz3D4mojsiFeme81wARNi/XH2abydQ9I8aBwnU7Q7I6YgZbJJK9dy0S6kl6d2eh0n jMj7zK0A8c4LA4cO/rEILM28d/J8REn2EaK86QC+WukKLW3w3wHF9J61Ljb6RIhFhINb +gQo2LRIvoSPa4WOr88K1ppZxTDuJmK5Ou+FNbmRJvoM/u/RobfUnThz93gdqwHO4ody dedg== X-Gm-Message-State: APjAAAUVhT3JCnsvnF1KGYGgkWiAzJZffDDGyshh9LSUYtG95Nj0EPwc 78NU5F/kz5DkiH/9jE05vfP/MhA8Z7l8JKQ/ir9C2w== X-Received: by 2002:a25:4557:: with SMTP id s84mr56059096yba.504.1560850648071; Tue, 18 Jun 2019 02:37:28 -0700 (PDT) MIME-Version: 1.0 References: <20190618093207.13436-1-ard.biesheuvel@linaro.org> In-Reply-To: <20190618093207.13436-1-ard.biesheuvel@linaro.org> From: Eric Dumazet Date: Tue, 18 Jun 2019 02:37:16 -0700 Message-ID: Subject: Re: [PATCH 0/2] net: fastopen: follow-up tweaks for SipHash switch To: Ard Biesheuvel Cc: netdev , Eric Biggers , linux-crypto@vger.kernel.org, Herbert Xu , David Miller , Alexey Kuznetsov , Hideaki YOSHIFUJI , Jason Baron , Christoph Paasch , David Laight , Yuchung Cheng Content-Type: text/plain; charset="UTF-8" Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Tue, Jun 18, 2019 at 2:32 AM Ard Biesheuvel wrote: > > A pair of tweaks for issues spotted by Eric Biggers. Patch #1 is > mostly cosmetic, since the error check it adds is unreachable in > practice, and the other changes are syntactic cleanups. Patch #2 > adds endian swabbing of the SipHash output for big endian systems > so that the in-memory representation is the same as on little > endian systems. > Please always add net or net-next in your patches for netdev@ ( Documentation/networking/netdev-FAQ.rst ) Thanks.