Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 20 Jun 2019 16:07:55 +0200
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Christian Lamparter <chunkeey@gmail.com>
Cc:     Hauke Mehrtens <hauke@hauke-m.de>, herbert@gondor.apana.org.au,
        davem@davemloft.net, stable <stable@vger.kernel.org>,
        linux-crypto@vger.kernel.org, Amit Pundir <amit.pundir@linaro.org>
Subject: Re: crypto: crypto4xx - properly set IV after de- and encrypt breaks
 kernel 4.4
Message-ID: <20190620140755.GC7117@kroah.com>
References: <9d744c3b-d4ff-b84b-527b-fc050794499b@hauke-m.de>
 <4226536.PGTo7a8ESG@debian64>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4226536.PGTo7a8ESG@debian64>
User-Agent: Mutt/1.12.1 (2019-06-15)
Sender: linux-crypto-owner@vger.kernel.org
Precedence: bulk

On Thu, Jun 20, 2019 at 02:07:27PM +0200, Christian Lamparter wrote:
> On Thursday, June 20, 2019 11:36:50 AM CEST Hauke Mehrtens wrote:
> > Hi,
> > 
> > The patch "crypto: crypto4xx - properly set IV after de- and encrypt"
> > causes a compile error on kernel 4.4.
> 
> 3.18 as well.
> > 
> > When I revert this commit it compiles for me again:
> > https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=e9a60ab1609a7d975922adad1bf9c46ac6954584
> > 
> > I do not have hardware to test if it is really working.
> 
> I have a few APM821XX. But please note drivers without
> 
> commit b66c685a482117d4e9ee987d252ca673689a5302
> Author: Christian Lamparter <chunkeey@gmail.com>
> Date:   Fri Dec 22 21:18:36 2017 +0100
> 
>     crypto: crypto4xx - support Revision B parts
> 
> don't work on those and I do have my doubts that 460EX
> series (and older) would either. I also don't believe that
> the inital driver as it was submitted would have worked.
> >From what I've seen in their SDK, they patched the testmgr
> at the time to either disable tests or provided their own...
> so, might as well revert these patches for 4.4 and 3.18.

Now reverted from both, thanks.

greg k-h