Received: by 2002:a25:f815:0:0:0:0:0 with SMTP id u21csp2096490ybd; Mon, 24 Jun 2019 00:21:08 -0700 (PDT) X-Google-Smtp-Source: APXvYqwUjYVpR4siS27VmB4yiN8NTA1blXX+0t47UiVH/Ntmet2PYfQ3l1T+1W8+ILQ6o5gQotoO X-Received: by 2002:a65:6495:: with SMTP id e21mr30911223pgv.383.1561360868012; Mon, 24 Jun 2019 00:21:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561360868; cv=none; d=google.com; s=arc-20160816; b=rDofRncEeJxUa4f3UvakjF6zjFxrFw31ZM3hckiROUUaDyuLPVR16mVkWVxZ8TIJvs oHX3TjmLjS3EwThiPA7VAKVR/LUwtSiJ8L3f31Y/k+XBmEmZhUVqp7Muf1jcu7OrYrRF Kt4Z6aaoE6MLirx9xjmv9Wynl+4b50qjXsgrlTWu3Qq+OUbKF2nW/QADmbCM+zwoCGhV /+L7+2Zta1pXoPZ14aFRMBoaeiQpkZXYKmB+jJT9W685H6dZQiBMCgyhTRTeK2dZl0N2 i9VZ9DRWYXmxCvyDmJ/HAvvZsBI96X8/EEmnX/9aZ2bW5RuzH/t2yR8thk/8M+fl3lYQ /yZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:cc:to:subject:from:message-id :dkim-signature; bh=uqSyYAuIgffBR0A50tqUgIECoBVIQIvOhmxv2zbmqbg=; b=bViuT+f07H+EwbAMD0IqJLVcVUxHYmEywMKCLCy7KkqM3v8vxNlVzZDOv3b12KtWFL JmT5smIRmUwRNXhUo5XR5XMT0nJ6AXY36Sx2TJ8nlMSk9djNzY51gvjdRmoj4m7KUK0M Jt+8/49d4PEAF09O+XOR0TCozcOsgUqYXmk+kS/fLeWjFlpceqNY0KqhIokBdq8UL1YM q/T6V+qaWrm5YmM8+IbfM0SDrlP0TOZL2htMUqHbFgzFRRbL2QP4U2V/bDQOe0ACwds5 EssLkck5nIwAy9/ba5ipGSpAg44dl3sEBDi2Rv5mk2m4bMHxoVSB2czJDusAuBB7CGaP GxNw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@c-s.fr header.s=mail header.b=s19ZDSn5; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d5si9257939pgc.596.2019.06.24.00.20.54; Mon, 24 Jun 2019 00:21:07 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@c-s.fr header.s=mail header.b=s19ZDSn5; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727176AbfFXHUQ (ORCPT + 99 others); Mon, 24 Jun 2019 03:20:16 -0400 Received: from pegase1.c-s.fr ([93.17.236.30]:29730 "EHLO pegase1.c-s.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726077AbfFXHUQ (ORCPT ); Mon, 24 Jun 2019 03:20:16 -0400 Received: from localhost (mailhub1-int [192.168.12.234]) by localhost (Postfix) with ESMTP id 45XLKP3N1fz9vBml; Mon, 24 Jun 2019 09:20:09 +0200 (CEST) Authentication-Results: localhost; dkim=pass reason="1024-bit key; insecure key" header.d=c-s.fr header.i=@c-s.fr header.b=s19ZDSn5; dkim-adsp=pass; dkim-atps=neutral X-Virus-Scanned: Debian amavisd-new at c-s.fr Received: from pegase1.c-s.fr ([192.168.12.234]) by localhost (pegase1.c-s.fr [192.168.12.234]) (amavisd-new, port 10024) with ESMTP id xldeek0ewHOc; Mon, 24 Jun 2019 09:20:09 +0200 (CEST) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase1.c-s.fr (Postfix) with ESMTP id 45XLKP22hNz9vBmR; Mon, 24 Jun 2019 09:20:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=c-s.fr; s=mail; t=1561360809; bh=uqSyYAuIgffBR0A50tqUgIECoBVIQIvOhmxv2zbmqbg=; h=From:Subject:To:Cc:Date:From; b=s19ZDSn5W/iLhp9qcgc83xHYMkjAx4y1dNQgPh4SA1NxYlgcYC11NChUC8peLAiZ3 o+iQGQNFpMj91CRj0q9va+uqsUhEbv/NRBqQy4EYv9TQCNf3wKa5Cg/+Fo55M7ivYT j1Rwg8ZPwarLO7MbxoBm8If8N4dw6qopNdtiPsrw= Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id D62E68B78B; Mon, 24 Jun 2019 09:20:13 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id HLL_7-DMmVsO; Mon, 24 Jun 2019 09:20:13 +0200 (CEST) Received: from po16838vm.idsi0.si.c-s.fr (po15451.idsi0.si.c-s.fr [172.25.230.101]) by messagerie.si.c-s.fr (Postfix) with ESMTP id B6E9D8B787; Mon, 24 Jun 2019 09:20:13 +0200 (CEST) Received: by po16838vm.idsi0.si.c-s.fr (Postfix, from userid 0) id 7CFA767424; Mon, 24 Jun 2019 07:20:13 +0000 (UTC) Message-Id: From: Christophe Leroy Subject: [PATCH v5 0/4] *** SUBJECT HERE *** To: Herbert Xu , "David S. Miller" , horia.geanta@nxp.com Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Date: Mon, 24 Jun 2019 07:20:13 +0000 (UTC) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org This series is the last set of fixes for the Talitos driver. We now get a fully clean boot on both SEC1 (SEC1.2 on mpc885) and SEC2 (SEC2.2 on mpc8321E) with CONFIG_CRYPTO_MANAGER_EXTRA_TESTS: [ 3.385197] bus: 'platform': really_probe: probing driver talitos with device ff020000.crypto [ 3.450982] random: fast init done [ 12.252548] alg: No test for authenc(hmac(md5),cbc(aes)) (authenc-hmac-md5-cbc-aes-talitos-hsna) [ 12.262226] alg: No test for authenc(hmac(md5),cbc(des3_ede)) (authenc-hmac-md5-cbc-3des-talitos-hsna) [ 43.310737] Bug in SEC1, padding ourself [ 45.603318] random: crng init done [ 54.612333] talitos ff020000.crypto: fsl,sec1.2 algorithms registered in /proc/crypto [ 54.620232] driver: 'talitos': driver_bound: bound to device 'ff020000.crypto' [ 1.193721] bus: 'platform': really_probe: probing driver talitos with device b0030000.crypto [ 1.229197] random: fast init done [ 2.714920] alg: No test for authenc(hmac(sha224),cbc(aes)) (authenc-hmac-sha224-cbc-aes-talitos) [ 2.724312] alg: No test for authenc(hmac(sha224),cbc(aes)) (authenc-hmac-sha224-cbc-aes-talitos-hsna) [ 4.482045] alg: No test for authenc(hmac(md5),cbc(aes)) (authenc-hmac-md5-cbc-aes-talitos) [ 4.490940] alg: No test for authenc(hmac(md5),cbc(aes)) (authenc-hmac-md5-cbc-aes-talitos-hsna) [ 4.500280] alg: No test for authenc(hmac(md5),cbc(des3_ede)) (authenc-hmac-md5-cbc-3des-talitos) [ 4.509727] alg: No test for authenc(hmac(md5),cbc(des3_ede)) (authenc-hmac-md5-cbc-3des-talitos-hsna) [ 6.631781] random: crng init done [ 11.521795] talitos b0030000.crypto: fsl,sec2.2 algorithms registered in /proc/crypto [ 11.529803] driver: 'talitos': driver_bound: bound to device 'b0030000.crypto' v2: dropped patch 1 which was irrelevant due to a rebase weirdness. Added Cc to stable on the 2 first patches. v3: - removed stable reference in patch 1 - reworded patch 1 to include name of patch 2 for the dependency. - mentionned this dependency in patch 2 as well. - corrected the Fixes: sha1 in patch 4 v4: - using scatterwalk_ffwd() instead of opencodying SG list forwarding. - Added a patch to fix sg_copy_to_buffer() when sg->offset() is greater than PAGE_SIZE, otherwise sg_copy_to_buffer() fails when the list has been forwarded with scatterwalk_ffwd(). - taken the patch "crypto: talitos - eliminate unneeded 'done' functions at build time" out of the series because it is independent. - added a helper to find the header field associated to a request in flush_channe() v5: - Replacing the while loop by a direct shift/mask operation, as suggested by Herbert in patch 1. Christophe Leroy (4): lib/scatterlist: Fix mapping iterator when sg->offset is greater than PAGE_SIZE crypto: talitos - move struct talitos_edesc into talitos.h crypto: talitos - fix hash on SEC1. crypto: talitos - drop icv_ool drivers/crypto/talitos.c | 102 +++++++++++++++++++---------------------------- drivers/crypto/talitos.h | 28 +++++++++++++ lib/scatterlist.c | 9 +++-- 3 files changed, 74 insertions(+), 65 deletions(-) -- 2.13.3