Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp3494844ybi; Tue, 2 Jul 2019 08:41:50 -0700 (PDT) X-Google-Smtp-Source: APXvYqx7Ol9VEO1hjc6p6xJZMM2CI2uspNLYBUE1vUiEquchNiO/wmblECmV9VkLXlevlgqCdco6 X-Received: by 2002:a17:902:1101:: with SMTP id d1mr36307885pla.212.1562082110572; Tue, 02 Jul 2019 08:41:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1562082110; cv=none; d=google.com; s=arc-20160816; b=K8CtfD92TPX+OOaGuSJIw2kzqGJvpGZDQQFMUDc3BxrBKBz6DQmZZIS4BDG+8GdF+5 tQyCdjS+Dsilqb6+H3z9Pr3NvpKGGxVbVhXHXnG4EdSm9qEn+NiD80zLBFlngffgW6cB 7TsizC3DbWepi3X13Is0a0CmR/9A7sdnQ4Tz2+z6qEBP02vI1QjcfoWBr77u8fomobs9 q0gzymqiWhEBR6AZSFXaDwCKfpHKtxvdQyuU1JR+xGI0RzUNaDnHJtmmg3+Ws51fsWEW mZlKtQcn9XCCN/+0QJoRHBRJ9KjfsSma7T+tkxb9Dw9LHLB5xwdRyNa6KFzXzvD+mqv1 q8+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :content-id:content-language:accept-language:in-reply-to:references :message-id:date:thread-index:thread-topic:subject:cc:to:from :dkim-signature; bh=5iMY03FxnNPk9Bvi0MCYQ80rze6xHLN/U7cSyGSkjHA=; b=dMv4Gl6wTcTe7G0cHEY6Y5zw1GPUnww5CEl2XkikE1ye0E24YMaQl4lD1lPURv9NOm bWW2lhka5HqLdBfwrAGANsuoHDHZwpsg+YeER4YRRs2JJLyk+JRF242tWt3IONnLkHOr cZZ0i4Is1lKUKZ0o/A/G40m0UjKrukUzINkvSXk98xhLxmC6SjxbPs6IS5SxBafVwzjx wEP8LixS7Skliw7pAiGznmC/YSyDDtY4mVNtLlUhovVHSOkCykp62C2+xcZ2OQ0ykjyz OFq3xZjz1/RyQulbwoLKI/5pKwrFk+wZraLWeEmXAlfU+RFsYR8CWX5SHyqMR3MVF3P5 gstw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amdcloud.onmicrosoft.com header.s=selector1-amdcloud-onmicrosoft-com header.b=h7w+7gNS; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j1si13885221pfr.52.2019.07.02.08.41.28; Tue, 02 Jul 2019 08:41:50 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@amdcloud.onmicrosoft.com header.s=selector1-amdcloud-onmicrosoft-com header.b=h7w+7gNS; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725858AbfGBPlZ (ORCPT + 99 others); Tue, 2 Jul 2019 11:41:25 -0400 Received: from mail-eopbgr750045.outbound.protection.outlook.com ([40.107.75.45]:24708 "EHLO NAM02-BL2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725780AbfGBPlZ (ORCPT ); Tue, 2 Jul 2019 11:41:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector1-amdcloud-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5iMY03FxnNPk9Bvi0MCYQ80rze6xHLN/U7cSyGSkjHA=; b=h7w+7gNSugd1vsyDM81hUuWjRpVa4lrMWI8sAswlWRl7CWuVPh728B+lJubjFXLaDkDQwMEvd2DcS4wpd2Arz3RDi4mQ4xROrjYR8D7PwQd81BwVcaW7M8X8TDOd2TkBAKsGWOTH7+TZSkt5n2Yr0Id7AYTQUV58dWK2ClmKRH4= Received: from DM5PR12MB1449.namprd12.prod.outlook.com (10.172.40.14) by DM5PR12MB1483.namprd12.prod.outlook.com (10.172.38.148) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2032.20; Tue, 2 Jul 2019 15:41:23 +0000 Received: from DM5PR12MB1449.namprd12.prod.outlook.com ([fe80::180c:ff0c:37e6:a482]) by DM5PR12MB1449.namprd12.prod.outlook.com ([fe80::180c:ff0c:37e6:a482%10]) with mapi id 15.20.2032.019; Tue, 2 Jul 2019 15:41:23 +0000 From: Gary R Hook To: Eric Biggers , Cfir Cohen CC: "Lendacky, Thomas" , "Hook, Gary" , Herbert Xu , David Rientjes , "linux-kernel@vger.kernel.org" , "linux-crypto@vger.kernel.org" Subject: Re: [PATCH] crypto: ccp/gcm - use const time tag comparison. Thread-Topic: [PATCH] crypto: ccp/gcm - use const time tag comparison. Thread-Index: AQHVMGlxe9at0dFonUmGbCxN6WOFAKa2eHIAgAD/6wA= Date: Tue, 2 Jul 2019 15:41:23 +0000 Message-ID: <1eea04e4-ac19-241d-695b-61be43640509@amd.com> References: <20190702000132.88836-1-cfir@google.com> <20190702002522.GA693@sol.localdomain> In-Reply-To: <20190702002522.GA693@sol.localdomain> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: SN6PR0102CA0002.prod.exchangelabs.com (2603:10b6:805:1::15) To DM5PR12MB1449.namprd12.prod.outlook.com (2603:10b6:4:10::14) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Gary.Hook@amd.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [165.204.78.1] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a873109a-2af5-4bfc-7700-08d6ff03bc35 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020);SRVR:DM5PR12MB1483; x-ms-traffictypediagnostic: DM5PR12MB1483: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4303; x-forefront-prvs: 008663486A x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(4636009)(376002)(136003)(396003)(346002)(39860400002)(366004)(189003)(199004)(11346002)(6512007)(316002)(31696002)(6436002)(6486002)(4326008)(446003)(186003)(36756003)(256004)(3846002)(53936002)(478600001)(2906002)(31686004)(54906003)(6116002)(110136005)(229853002)(66066001)(6246003)(26005)(6506007)(5660300002)(66446008)(66946007)(25786009)(486006)(7736002)(71190400001)(53546011)(8936002)(68736007)(386003)(102836004)(71200400001)(76176011)(81156014)(99286004)(52116002)(8676002)(2616005)(73956011)(81166006)(66556008)(476003)(14454004)(64756008)(305945005)(72206003)(14444005)(66476007);DIR:OUT;SFP:1101;SCL:1;SRVR:DM5PR12MB1483;H:DM5PR12MB1449.namprd12.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: amd.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: BDVIK6/i6LDK76vYEGSOmtcP95b6Hl743w0DFaA6QIHtQlEyGeX2uenuEmFLVHmVwZYtp3wbqqA9/zVH5Aer8rgEjKaZ9/gANip3ipeaq7axRtNEs/4xfdCrFsDhBCwR4VpYnxT8QrBu0vGtENSCHjuWSMnATmE2Xgroe9TEphcH+1PBKmluTijZxWsGDhfXj4h9CWXBEZNJFmLxzob3wiq8AnvtZnAtffwZ9RMOUDaVfr+hakcxfudCZ2fuD0mZyObJEGpbD9rorpLq+0K9EO91yCoTYclXonN4DqINRB5IdOQo/LeyYcjOmQtpoy+PqjDCU/NVuds7l84a/dVoaJ51X/ZoxxLUOp3atDiwZxi6+3oNplRovL+1Tgu4j0lGoOzUCcnpaaMxjkyoySu4W25Q37eBDna6FNx+Eat1PLg= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: a873109a-2af5-4bfc-7700-08d6ff03bc35 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Jul 2019 15:41:23.5115 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ghook@amd.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1483 Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org T24gNy8xLzE5IDc6MjUgUE0sIEVyaWMgQmlnZ2VycyB3cm90ZToNCj4gT24gTW9uLCBKdWwgMDEs IDIwMTkgYXQgMDU6MDE6MzJQTSAtMDcwMCwgQ2ZpciBDb2hlbiB3cm90ZToNCj4+IEF2b2lkIGxl YWtpbmcgR0NNIHRhZyB0aHJvdWdoIHRpbWluZyBzaWRlIGNoYW5uZWwuDQo+Pg0KPj4gU2lnbmVk LW9mZi1ieTogQ2ZpciBDb2hlbiA8Y2ZpckBnb29nbGUuY29tPg0KPj4gLS0tDQo+PiAgIGRyaXZl cnMvY3J5cHRvL2NjcC9jY3Atb3BzLmMgfCAzICsrLQ0KPj4gICAxIGZpbGUgY2hhbmdlZCwgMiBp bnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pDQo+Pg0KPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMv Y3J5cHRvL2NjcC9jY3Atb3BzLmMgYi9kcml2ZXJzL2NyeXB0by9jY3AvY2NwLW9wcy5jDQo+PiBp bmRleCBkYjhkZTg5ZDk5MGYuLjYzMzY3MDIyMGY2YyAxMDA2NDQNCj4+IC0tLSBhL2RyaXZlcnMv Y3J5cHRvL2NjcC9jY3Atb3BzLmMNCj4+ICsrKyBiL2RyaXZlcnMvY3J5cHRvL2NjcC9jY3Atb3Bz LmMNCj4+IEBAIC04NDAsNyArODQwLDggQEAgc3RhdGljIGludCBjY3BfcnVuX2Flc19nY21fY21k KHN0cnVjdCBjY3BfY21kX3F1ZXVlICpjbWRfcSwNCj4+ICAgCQlpZiAocmV0KQ0KPj4gICAJCQln b3RvIGVfdGFnOw0KPj4gICANCj4+IC0JCXJldCA9IG1lbWNtcCh0YWcuYWRkcmVzcywgZmluYWxf d2EuYWRkcmVzcywgQUVTX0JMT0NLX1NJWkUpOw0KPj4gKwkJcmV0ID0gY3J5cHRvX21lbW5lcSh0 YWcuYWRkcmVzcywgZmluYWxfd2EuYWRkcmVzcywNCj4+ICsJCQkJICAgIEFFU19CTE9DS19TSVpF KSA/IC1FQkFETVNHIDogMDsNCj4+ICAgCQljY3BfZG1fZnJlZSgmdGFnKTsNCj4+ICAgCX0NCj4+ ICAgDQo+PiAtLSANCj4+IDIuMjIuMC40MTAuZ2Q4ZmRiZTIxYjUtZ29vZw0KPj4NCj4gDQo+IExv b2tzIGxpa2UgdGhpcyBuZWVkczoNCj4gDQo+IAlGaXhlczogMzZjZjUxNWI5YmJlICgiY3J5cHRv OiBjY3AgLSBFbmFibGUgc3VwcG9ydCBmb3IgQUVTIEdDTSBvbiB2NSBDQ1BzIikNCj4gCUNjOiA8 c3RhYmxlQHZnZXIua2VybmVsLm9yZz4gIyB2NC4xMisNCg0KDQpZZXMsIGl0IGRvZXMuIEZvciBj bGFyaXR5LCBkb2VzIHRoYXQgbWVhbiB5b3UndmUgdGFrZW4gY2FyZSBvZiB0aGlzPw0KDQo=