Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp3521264ybi; Tue, 2 Jul 2019 09:06:36 -0700 (PDT) X-Google-Smtp-Source: APXvYqylaU3TmALEIaMHZAAAP4dtAwRqOW//Z1jZYbBLl8Vn4BV/q3OHwJ/grkXRSsVZOHALTn0R X-Received: by 2002:a62:584:: with SMTP id 126mr26132pff.73.1562083596844; Tue, 02 Jul 2019 09:06:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1562083596; cv=none; d=google.com; s=arc-20160816; b=mkkvmj9JwbcfSMJPEvh2D5jnpKtW3etUnKoyhRYgHh6QBE7vz9R9uKt9hQ2ud6s7aM A9ylgfAUiTKOGEMYTXq3SQ5BIYLXaJNu2pBJkCn7dX1j2reBFqj/mhOIhO0tV68Mt5sf WD5pw+E+57CEtbl2jxbp5pcu6R300TIWhNl78gcQ4aUXomuliPWW1rsxWyZjUAm9IBbM o5YQQt8FRvEE8vDdITzEcdJoODlc+zfl4rmcuMcocQK0jVpVFJXb35Ymsg2jDMaBPmxT uImBp72K7Rc4PfvvKwdMC2oc3pjJZiQgkKsDzHrC08WlVXOPFWo51aiet8gA6TebgPu6 B/eQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:content-disposition :mime-version:message-id:subject:cc:to:from:date:dkim-signature; bh=smHqCexmoNhhjM+q80YiBjOrIYFIwoaiUCwKUaeejqk=; b=kXvm9xZxxc6Q0WsvzK2xtW6RCsDdlHc+2GZhpo82e97ZKSOCJBJfTtvVWzPOVlDjr1 Wg0n5YIkbaZd/VTSehBsrdNLKs/4eXs6KKS1IV1JtQ0TA8rdQSWib5q1Diue68PUkwok 0bwTs6n7kBTpzZ4zKLgX5UAKkJIkE+bniBg16GmG03k3ibe1ND4/bIJ25vlirGtkYtDp +uPfANAr1v2XTKbY4G/0PBrITryfva/Q641ViHGdJGhrpPmaFMAd1OOkSqLImDHHRLsU ecJJonwNITF3rVU+OINIYHjFErK7tVmac+ZqLjY5+W4RkDd0cF3bWpZ5z17tm2aMzlSG +LOg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Ytjd6MqS; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t2si12594568pgp.343.2019.07.02.09.06.19; Tue, 02 Jul 2019 09:06:36 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Ytjd6MqS; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725972AbfGBQGR (ORCPT + 99 others); Tue, 2 Jul 2019 12:06:17 -0400 Received: from mail.kernel.org ([198.145.29.99]:52550 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725858AbfGBQGR (ORCPT ); Tue, 2 Jul 2019 12:06:17 -0400 Received: from sol.localdomain (c-24-5-143-220.hsd1.ca.comcast.net [24.5.143.220]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 53ABD206A3; Tue, 2 Jul 2019 16:06:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1562083576; bh=NzUh+dGND0X6x1d2WK0u77MPzTq27D+4N0HJEZaArNI=; h=Date:From:To:Cc:Subject:From; b=Ytjd6MqSB/0TdW+HZLP8Fq6GuCp/NdjieGOAA0087SN2qVdgTK+Y6HVeHMpHIE/Ge RpTltODOTLSA+bEviOX5heOK/T1rOInLczw+wxBKQoObhOV8dzz7K+yI/v3mmYiYxI eItIGPA6nYj88JiXF5NwHkApy31gkP5FUKYVht6U= Date: Tue, 2 Jul 2019 09:06:14 -0700 From: Eric Biggers To: Tom Lendacky , Gary Hook Cc: linux-crypto@vger.kernel.org, Cfir Cohen , David Rientjes Subject: gcm-aes-ccp self-tests failure Message-ID: <20190702160614.GC895@sol.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Hi Tom and Gary, On latest cryptodev tree, I'm seeing the following self-test failure after I built a kernel with the AMD CCP driver and crypto self-tests enabled, and booted it on system with a Ryzen processor ("Threadripper 1950X"): [ 4.378985] alg: aead: gcm-aes-ccp encryption test failed (wrong result) on test vector 2, cfg="two even aligned splits" i.e., in some cases the AES-GCM implementation produces the wrong ciphertext and/or authentication tag. Is this is a known issue? When will it be fixed? The potentially relevant bits of my Kconfig are: CONFIG_CRYPTO_AES=y CONFIG_CRYPTO_GCM=y CONFIG_CRYPTO_DEV_CCP=y CONFIG_CRYPTO_DEV_CCP_DD=y CONFIG_CRYPTO_DEV_SP_CCP=y CONFIG_CRYPTO_DEV_CCP_CRYPTO=y CONFIG_CRYPTO_DEV_SP_PSP=y # CONFIG_CRYPTO_MANAGER_DISABLE_TESTS is not set CONFIG_DEBUG_KERNEL=y CONFIG_CRYPTO_MANAGER_EXTRA_TESTS=y - Eric