Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp8576793ybi; Tue, 9 Jul 2019 18:59:57 -0700 (PDT) X-Google-Smtp-Source: APXvYqzBQpfnKEDxl72g7O8aFoHuHjz5BHV+CvV0hFg6n91JAUu+ZyTH8d6+x+v3elkcI+VyCMLy X-Received: by 2002:a17:902:f213:: with SMTP id gn19mr36735336plb.35.1562723997714; Tue, 09 Jul 2019 18:59:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1562723997; cv=none; d=google.com; s=arc-20160816; b=XH/Kk4IhQtwo6+jJNKT6pBROl2qBhjF5w9agJhuHtbiEBvxnEqTX62Zz92oCCwukEH TaXdhS84/mk7nFzTSEmR7hCLzI8vGxTf1NgMfK77IxOp7BbkSuJnj/D5zzweSatmJZNA AwTSBYF279389vDONOO+LbbP+1GahZdVWniB0BmNP3iJ5dtUfFpMU/OsGIFVmICFnxri H9xc1Sr3aA10IwMsFm3ElQE+FzKqTQ77+rUtVRQl5RtpXY1+iINid735lxW9IlX7hwCu RTr7HYlFlbf7yz++2Qdynw4mwjLhz37ZK/FgOZtnvIpqnVhBxGMZCislz96z0883qvoT P35A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:mail-followup-to :message-id:subject:cc:to:from:date:dkim-signature; bh=36xS5y09+0ZB/f6Y+ssBz+9vor6NpGVoDnLIJTS5AQY=; b=VD4z+NV8PUFv2a8vALS4hAxzr/ljiBCV0GDBqLGo2GIZmWKphxhyLhhTJ46Db6PBjn vjvQJlj6dmfNt7NSHjCAsNUwn7hteMIEiEfy4Vv3d2phzeC10hebAZLVM2EST2tIL2gV ONrcV2457m/LVOZY/Mz/kSTB3zazvlLzrcfLefAcz3yxkNk1zEIqqf0TFEzumdRPYLQE xe2N/hLNlxSF48VLyIZyTYMMhQBR8ElP6MvvRN5Kzz7lU4UQdWPa0Ib9p+tti0D++rvN Fh3y7TGzaDQ0Z/y/vgAl4bKTLyVxweYSH/9aiXq4Lj5N8ahafPOa9k8J5d6mb+YnYqxP sKgw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=137KtHHr; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r4si666980pgb.245.2019.07.09.18.59.39; Tue, 09 Jul 2019 18:59:57 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=137KtHHr; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725989AbfGJB51 (ORCPT + 99 others); Tue, 9 Jul 2019 21:57:27 -0400 Received: from mail.kernel.org ([198.145.29.99]:50072 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725912AbfGJB51 (ORCPT ); Tue, 9 Jul 2019 21:57:27 -0400 Received: from sol.localdomain (c-24-5-143-220.hsd1.ca.comcast.net [24.5.143.220]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E88862081C; Wed, 10 Jul 2019 01:57:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1562723847; bh=4kmJxbSTwak7WxaS9zxyCTA7zuSBK7iwMUMRH5ekjEg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=137KtHHrUcBRIARG7MiMu6pVA24uD3bOSggDJpDHyneZyV4g7Vc4WybquSCmuYbjj RdO0m43P6O2UMh1i3B4V0bR0PO9J6dPl3tXArhTAGujxhf9VlolezEfdUzfJCj+NSG pu2Befw8bg/NocPWLTtOYMv3yVsu8RkUAaU7uSm8= Date: Tue, 9 Jul 2019 18:57:25 -0700 From: Eric Biggers To: "Hook, Gary" Cc: "linux-crypto@vger.kernel.org" , "herbert@gondor.apana.org.au" , "davem@davemloft.net" , "Lendacky, Thomas" Subject: Re: [PATCH v2] crypto: ccp - memset structure fields to zero before reuse Message-ID: <20190710015725.GA746@sol.localdomain> Mail-Followup-To: "Hook, Gary" , "linux-crypto@vger.kernel.org" , "herbert@gondor.apana.org.au" , "davem@davemloft.net" , "Lendacky, Thomas" References: <20190710000849.3131-1-gary.hook@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190710000849.3131-1-gary.hook@amd.com> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Wed, Jul 10, 2019 at 12:09:22AM +0000, Hook, Gary wrote: > The AES GCM function reuses an 'op' data structure, which members > contain values that must be cleared for each (re)use. > > This fix resolves a crypto self-test failure: > alg: aead: gcm-aes-ccp encryption test failed (wrong result) on test vector 2, cfg="two even aligned splits" > > Fixes: 36cf515b9bbe ("crypto: ccp - Enable support for AES GCM on v5 CCPs") > > Signed-off-by: Gary R Hook FYI, with this patch applied I'm still seeing another test failure: [ 2.140227] alg: aead: gcm-aes-ccp setauthsize unexpectedly succeeded on test vector "random: alen=264 plen=161 authsize=6 klen=32"; expected_error=-22 Are you aware of that one too, and are you planning to fix it? - Eric