Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp282702ybi; Thu, 11 Jul 2019 19:21:56 -0700 (PDT) X-Google-Smtp-Source: APXvYqwfXYEkCToCyciCM637RSdJjC+1wH/LQpueMwLXuovbxp92uVG8ViXnNP58sLMVpAcaZ6WM X-Received: by 2002:a63:455c:: with SMTP id u28mr8081890pgk.416.1562898116125; Thu, 11 Jul 2019 19:21:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1562898116; cv=none; d=google.com; s=arc-20160816; b=Q0evWBSynlwM+5SWDzoiwxXtN5Pu7SKubXyGfh6RkHl5GGyF0fA6KGrkw1K4xIryJg Q3W2cy30jVEOxrofi8bt5gZyhfBz5rnnPl6QNzWYWZlgWgQYnHTYWkfM5UTx4WDC572Y qBdG9kRFd7mp774P44cxEKHWCs/+S4th+bxtaOV+zMnVPnWfM3UyAalSZPeXwoic08P5 1zvLFpVDdvEB2mq9SVMjILs0HYou+IOskQSV/vVowf2tcPR173tGt+Ef3VlCqeTdvxW+ jppKsaCq+Db60Y6vDHjtL54EG/xhASXwPytUDZ5Xr14pici+4R/uamZLSv6akaTDiXE7 MJnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=qq8/pyPqPx89jEMsdEeYQ6yEiR+0vtjl2BSi9nOjwF8=; b=jdzOUzNUx9siBP6awB8ijsd5fihx3peKJC88v/0alVQDGf6kH5ohKTQF2QTEG+GeDt hjJ6WY3aWZGRiMZsVeH/mxIjlHq4YxsSmL3NxblFdBdQd2NWyGC26p3rGuQnYo6oJGHy T6FN9SO8cdb1eerJiLa2jBCnVHdtMYVfDZoeR9+br38jgVbfJSIv8b++q5cRg4Iuirhm 3bU5Nf5Qj3S2Q9IG/kpMnj76zQ+32kYS/UeZX6L6BAg1Du5/YJBMRoHnkaiznC11ZXWY B4udL7gRhkG+rOpOiY7HzCI8isYv4bqYNbbRHFwhMFOMwrfNRXz6uLW9cBxqZU5aozj8 lLmg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z142si6719972pfc.128.2019.07.11.19.21.43; Thu, 11 Jul 2019 19:21:56 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729399AbfGLCU7 (ORCPT + 99 others); Thu, 11 Jul 2019 22:20:59 -0400 Received: from helcar.hmeau.com ([216.24.177.18]:37410 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729395AbfGLCU6 (ORCPT ); Thu, 11 Jul 2019 22:20:58 -0400 Received: from gondobar.mordor.me.apana.org.au ([192.168.128.4] helo=gondobar) by deadmen.hmeau.com with esmtps (Exim 4.89 #2 (Debian)) id 1hllBA-0007Eg-Gw; Fri, 12 Jul 2019 10:20:56 +0800 Received: from herbert by gondobar with local (Exim 4.89) (envelope-from ) id 1hllB5-0007bd-E3; Fri, 12 Jul 2019 10:20:51 +0800 Date: Fri, 12 Jul 2019 10:20:51 +0800 From: Herbert Xu To: Gary R Hook Cc: "Hook, Gary" , "linux-crypto@vger.kernel.org" , "davem@davemloft.net" , "Lendacky, Thomas" Subject: Re: [PATCH v2] crypto: ccp - memset structure fields to zero before reuse Message-ID: <20190712022051.jpqpt46mzw625ewv@gondor.apana.org.au> References: <20190710000849.3131-1-gary.hook@amd.com> <20190710015725.GA746@sol.localdomain> <2875285f-d438-667e-52d9-801124ffba88@amd.com> <20190710203428.GC83443@gmail.com> <20190711004617.GA628@sol.localdomain> <7a4dfdce-41ca-2047-f9f2-77e0b7abedb3@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7a4dfdce-41ca-2047-f9f2-77e0b7abedb3@amd.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Thu, Jul 11, 2019 at 03:25:00PM +0000, Gary R Hook wrote: > > Our device only allows 16 byte tags. So I have to figure out how to set > up the driver to expose/enforce that limitation. That's where we go awry. You need to work around it by using a fallback. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt