Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp2990436ybi; Thu, 18 Jul 2019 18:49:31 -0700 (PDT) X-Google-Smtp-Source: APXvYqzARayaJLC+eLPT2j+1KFV9OxctXo7V15gVHDISgE7jsTMjzFEqYKwmG0QuSWKLBFM0i2E5 X-Received: by 2002:a63:c64b:: with SMTP id x11mr50874786pgg.319.1563500971461; Thu, 18 Jul 2019 18:49:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1563500971; cv=none; d=google.com; s=arc-20160816; b=rjwWa4qyuswfYCL1DqJ9XLxdPKSH8JczbdcBh5v1VDKLr79U+ay/ErspZh3+pcqOAm Wor69D9r5VFQX5IvzmiUg/m/Q03vtDCRGLg4Bt0R8wBu6N5gOeFy0hf/bmx4oNvDYpW6 Xgy1E6oEn5MXZyvSZcNKo0bdRpbkE4JqAjvNOM0BNdYiXvE5sqmO4HISI/TSwHBrlKfi LxmDsPVvdjNoUsWH0Kr6VB/IBSI/nindIy9TmddUxqvkZMx8h/E9o3DxCNx7j5+pB4fp jJ0X2iU5vbjKgNCaWoCDyE7cXNgplrnWFZ1xn+lOdt63uf2O3yr6o5purEAY4QEw/dzQ KpeQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=vY8ZgnmiLvB+WTNXSig/ZTSYJFtByiWR7ehYD/8We9A=; b=rwOdBYkyLCtSZjK3kxfjCfuLCJyAKWlxONYFRuD8O1PPsOiH26Kq4J+HeOe7NFTdNv P1CfmX5tUSjA8+wDXKqW6bwIvYmQhprRpL1JIU+S0QBltihyRiXSHIxFVxJIqOXNzfR7 DYO0DE9fdxqosp2bRA9JfkLUmVx2P6O288yO1SWs5e24Hgi3PeTREC1bXEnlj4KY+AY8 sDWgJ0fs2QZ1AhUUxiBe7fEN1cgfGCyfNgghD74bdIyrTukjU9qVDMWR4Cm8f8H5KfPp +WQpurZ3ZMMSADPmU7GhdczWGD2TV5YySKSWjye09ejkYbQZlmwj1IUhiomgTyEln9l2 nZ6Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l3si329415pgp.179.2019.07.18.18.49.09; Thu, 18 Jul 2019 18:49:31 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726092AbfGSBrk (ORCPT + 99 others); Thu, 18 Jul 2019 21:47:40 -0400 Received: from helcar.hmeau.com ([216.24.177.18]:38846 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726066AbfGSBrk (ORCPT ); Thu, 18 Jul 2019 21:47:40 -0400 Received: from gondobar.mordor.me.apana.org.au ([192.168.128.4] helo=gondobar) by deadmen.hmeau.com with esmtps (Exim 4.89 #2 (Debian)) id 1hoHzg-0004m2-W8; Fri, 19 Jul 2019 09:47:33 +0800 Received: from herbert by gondobar with local (Exim 4.89) (envelope-from ) id 1hoHza-0007Nw-NB; Fri, 19 Jul 2019 09:47:26 +0800 Date: Fri, 19 Jul 2019 09:47:26 +0800 From: Herbert Xu To: Pascal Van Leeuwen Cc: Milan Broz , Ard Biesheuvel , Horia Geanta , "linux-crypto@vger.kernel.org" , "dm-devel@redhat.com" Subject: Re: xts fuzz testing and lack of ciphertext stealing support Message-ID: <20190719014726.erp3bf26oi4rducm@gondor.apana.org.au> References: <20190718065223.4xaefcwjoxvujntw@gondor.apana.org.au> <20190718072154.m2umem24x4grbf6w@gondor.apana.org.au> <36e78459-1594-6d19-0ab4-95b03a6de036@gmail.com> <20190718152908.xiuze3kb3fdc7ov6@gondor.apana.org.au> <20190718155140.b6ig3zq22askmfpy@gondor.apana.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Thu, Jul 18, 2019 at 04:35:26PM +0000, Pascal Van Leeuwen wrote: > > Tthen there's still the issue of advancing that last tweak. From what I've seen, > the xts implementation does not output the last tweak so you would have to > recompute it locally in cts.c as block_cipher_enc(iv) * alpha^j. Which is wasteful. > Of course this could be solved by redefining xts to output the last tweak > like CBC/CTR output their last IV ... Which would probably give us HW guys > trouble again because our HW cannot do *that* ... (While the HW very likely > *does* implement the cipher text stealing properly, just to be able to boast > about IEEE P1619 compliance ...) If your hardware supports XTS properly then you wouldn't even need to use this new template. You would directly export the xts interface. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt