Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp3828992ybi; Fri, 19 Jul 2019 09:44:34 -0700 (PDT) X-Google-Smtp-Source: APXvYqxpMvgK0Rm71JHW9kfTl0cyNJbo1K3vmpqOycZDDsEZPyvlUnVAbIj+AMsUi7+g+ga1aSOT X-Received: by 2002:a17:902:8f81:: with SMTP id z1mr56725212plo.290.1563554674000; Fri, 19 Jul 2019 09:44:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1563554673; cv=none; d=google.com; s=arc-20160816; b=GvYo2aHpAL1HNqogKSIDeWdwui0DzaU8qk6IAn769Sf7OnlE8N6xq/3BchoQkPWxeh L/d9kpChteLcFMVQIc2yGBQ22wPwxn9vGlGaBKy6h5Yd8dkb/2egQvoPln86vmENMIOl tl0iYMMqlFCw3+iFIXTHkE/EonzMgDiIN0QF5YhlJctVOmBmimaNinMY4tEfsp/FIGH9 S3F1e/50UiIyyDqXyHxEZ/Sc2c2V0YNb862Ag2Ip4STO6wNtTX5QlwQgDZ6CMgV7YKvQ JiFz1EMx65nZYhRmCjhNpHCV17fy9Ddv3vfsVZ/2wbtq3GTdIbCQCgGHAviAr2sFCfAC IHxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=jO8dr4iS86DsiLvt9E4cATJwPUReGKDs/QIouzmBOvw=; b=aC1MJzPkiI969gWSibZ27cKdmSu8g5A/YoX7rJSDi6X7AUAH612eo13/hIocD1nnUb 78jdvOmGf/SMktAMM3d3OAQ6hRQS6bFJwpZh/jYn9EYRVH8Yktx3ZZ/XH9liR07mZSn9 XuOmcGx47sEeSdeMfCEz4eUlNW/C89m+tnwvdBZBuxUFh+TvqYGf+yGDxwuQVWpizHTc DyjHm18Y2M19AxZkuMtqvzRD0c6J4sx/6wa2mQduaQRqL4wXe6hIDMyRTMgbP27DegE+ EGVvGSTlVChogs9DTDt5ZrvjGrm9N9SGC+OYwosCsR/8qgupbomU6kI0xAftI9Jh/4EL mP6Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 1si212101plz.129.2019.07.19.09.44.05; Fri, 19 Jul 2019 09:44:33 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728058AbfGSO4C (ORCPT + 99 others); Fri, 19 Jul 2019 10:56:02 -0400 Received: from helcar.hmeau.com ([216.24.177.18]:56562 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726072AbfGSO4C (ORCPT ); Fri, 19 Jul 2019 10:56:02 -0400 Received: from gondobar.mordor.me.apana.org.au ([192.168.128.4] helo=gondobar) by deadmen.hmeau.com with esmtps (Exim 4.89 #2 (Debian)) id 1hoUIa-0002zi-L4; Fri, 19 Jul 2019 22:55:52 +0800 Received: from herbert by gondobar with local (Exim 4.89) (envelope-from ) id 1hoUIU-00089C-5q; Fri, 19 Jul 2019 22:55:46 +0800 Date: Fri, 19 Jul 2019 22:55:46 +0800 From: Herbert Xu To: Daniel Jordan Cc: Steffen Klassert , Andrea Parri , Boqun Feng , "Paul E . McKenney" , Peter Zijlstra , linux-arch@vger.kernel.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, Mathias Krause Subject: Re: [v2 PATCH] padata: Replace delayed timer with immediate workqueue in padata_reorder Message-ID: <20190719145546.hkpe77mevab3gzwq@gondor.apana.org.au> References: <20190716163253.24377-1-daniel.m.jordan@oracle.com> <20190717111147.t776zlyhdqyl5dhc@gondor.apana.org.au> <20190717183227.b3hqphukkndqumhw@ca-dmjordan1.us.oracle.com> <20190718033131.4m4ypbq7tiucqcsl@gondor.apana.org.au> <20190718142730.uhdkwx5onigdpxno@ca-dmjordan1.us.oracle.com> <20190718145634.xagjemdqpoe44xxh@gondor.apana.org.au> <20190718150146.bztw3uugd5sqhdvk@gondor.apana.org.au> <20190719143721.awtvjf2pk37f5zsv@ca-dmjordan1.us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190719143721.awtvjf2pk37f5zsv@ca-dmjordan1.us.oracle.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Fri, Jul 19, 2019 at 10:37:21AM -0400, Daniel Jordan wrote: > > If I'm not missing anything, still looks like get_cpu() and reorder_via_wq no > longer have an effect with this patch and can be removed. You're right that they're not needed. But we shouldn't mix clean-ups with substantial changes (in case we break something this would make bisection less efficient). So feel free to send a patch on top of this one to remove them. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt