Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp3830070ybi; Fri, 19 Jul 2019 09:45:40 -0700 (PDT) X-Google-Smtp-Source: APXvYqw1PD+mCul+cuylm5AW5RJchbHnWVh5uKc+qBTCvp7P1VEJ1D9T1tFT6cEiOu/XMqHZpnDS X-Received: by 2002:a17:90a:23ce:: with SMTP id g72mr27812078pje.77.1563554740557; Fri, 19 Jul 2019 09:45:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1563554740; cv=none; d=google.com; s=arc-20160816; b=0Wdm1vTNF/X+zTk7J7PwJ9jD8AvWypzhaSKOHZmmfSHYAeOzFwKvgzkMyzBPEXo5uw 5owLaaTKKumWefrCD64sLyO3X5KaKQmk0xJkUs+a/8KwiMqEL9Wz/hwdN9NRjPAnAOQw tR2K80NIOmkK6H1CKrwEeIZH6UoUJ8bx0KiWURFw+P08q92JfJNsed/T1f1RvmOCrLH4 m3mBHl4T8nboIED1Ow3a+hnRm+cqOkwy233U9VWFOLFpS9VfXuuojBvOK+gKfMJjFrwn w30I0gvdcaLvWKZI7EGQA6l4QiRgAHeREoH9j8OBPO9c0UWlPnX23MJCEvMmWrC0AK5J Vm5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=UrZ84Fb9VgBdzvd5tD0Y+4RFg49D3D5A+LNjSKaE4lk=; b=kiwKmVhNUM/4QwzCwrUw3t8hICrbhWITRBwEtFtlM5JYVm+ZqEIWoHZhmDEKo0w5t2 j6DK05K9IXyB81BgN8SnFz/px1SmNrvZ0q33TstvbiFOhzIN2ESxnPdt/8/4NPRR151v 5pqeo68/tw2kgAiL3AlZDmZwUcA5p/3EitT2FxJof293X6zxlszqmWA6BPljmWeCzQ4N QXPgiUDmmZAj2FmIWv4CBjVk26MQuRzSrJqYfxipKJmBm8xUJAb2r2cwwtziK9XPXWbo TXFsM+QsdifHznD6dIHagqzgRX34bPfgvIoenjhnDC+gdSjgUq5VDtCrdze6RcAcwmva NaGQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id cf7si2879645plb.435.2019.07.19.09.45.27; Fri, 19 Jul 2019 09:45:40 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728424AbfGSPP3 (ORCPT + 99 others); Fri, 19 Jul 2019 11:15:29 -0400 Received: from helcar.hmeau.com ([216.24.177.18]:58026 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726711AbfGSPP2 (ORCPT ); Fri, 19 Jul 2019 11:15:28 -0400 Received: from gondobar.mordor.me.apana.org.au ([192.168.128.4] helo=gondobar) by deadmen.hmeau.com with esmtps (Exim 4.89 #2 (Debian)) id 1hoUbX-0003JV-IN; Fri, 19 Jul 2019 23:15:27 +0800 Received: from herbert by gondobar with local (Exim 4.89) (envelope-from ) id 1hoUbW-0008Bk-3h; Fri, 19 Jul 2019 23:15:26 +0800 Date: Fri, 19 Jul 2019 23:15:26 +0800 From: Herbert Xu To: Horia Geanta Cc: Iuliana Prodan , Aymen Sghaier , "David S. Miller" , "linux-crypto@vger.kernel.org" , "linux-kernel@vger.kernel.org" , dl-linux-imx Subject: Re: [PATCH v2 06/14] crypto: caam - check assoclen Message-ID: <20190719151526.uqvg4q4pbpztojnv@gondor.apana.org.au> References: <1563494276-3993-1-git-send-email-iuliana.prodan@nxp.com> <1563494276-3993-7-git-send-email-iuliana.prodan@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Fri, Jul 19, 2019 at 03:06:38PM +0000, Horia Geanta wrote: > > Herbert, is it worth having these checks moved to crypto API, > so they could be shared b/w all implementations? Yes this should be turned into a inline helper. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt