Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp8986690ybi; Tue, 23 Jul 2019 19:31:04 -0700 (PDT) X-Google-Smtp-Source: APXvYqwOA3cIvxMqYL3nJs6npC41qLnLfApBK1LFa4MyUPp4XNtOWznS2ltTChM0TpLF30Vgo+nE X-Received: by 2002:a63:9a41:: with SMTP id e1mr80401721pgo.210.1563935464645; Tue, 23 Jul 2019 19:31:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1563935464; cv=none; d=google.com; s=arc-20160816; b=nbt/t/4utXT4NAeCxdwns1CRbKJhn0L3sHXNZtJYTwsUNp39n9w/fqGhQTiWFp/2bW yK+4lqXvye5x+K6kD2ku977bR1+nT7/OUNEJAy/gPe+Ey3mrKQY+OqtqkuFko3Ooyv6m 1rmAoaORv0Mq3HKb8cdCWIvhiPFHaXBcJyKyHWjLX9f0ap5q8EnDCv2k0vBHyZbVUs4P N6uMf0nOPfntBWrbVbt21rbU5/5dOezEFCo/XqtSXoJiJ8jlUI8Z30kmHzwV+HLOEXOH rRbjrVJqAGuG8xqJN4Owjd4FhFQiH0EjDzuNPIaH5RdYA0Av1i5+U+Y0lNmSNbUNcegE QMQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=MAiAHdI8iqd+O1xZOBVxWbAPjMbgMmfQoqtQMb7/9dY=; b=qpOOLAP9Ar/pf8KAzsBF7gVr97cfo8dBfLCUvNdpzZjzQfS7su9GVEAFqS5PtIwFP4 ESku/UbmDvJuIm5TGF0MqTvRjhuDsxYjVn9lBhl81ua4P2w7/vpeWgE85aBy0Wp1jx3w Dsbr84FcH/e3zHZdcDQk0xhHgEFM/qb3bCA+XCuAYg1/zFjP6BKGsdRW34DxsJZYaEER zxzm5othiRi91WHtW93ft0dlKY6KXrGIiL2GFjLrGLyDz1yVNwX8GzUC+InLVJ9CzGzW ZjBSsm+RTtNkfpboQy8PPJNS7iaO7xrQYdQWO2ffivBX6Gn0MIbxNJWewOq27btEmgbL 3wJg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=kJ8lRTX8; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f15si12198298plr.260.2019.07.23.19.30.51; Tue, 23 Jul 2019 19:31:04 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=kJ8lRTX8; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389245AbfGWVDi (ORCPT + 99 others); Tue, 23 Jul 2019 17:03:38 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:55810 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729084AbfGWVDi (ORCPT ); Tue, 23 Jul 2019 17:03:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=MAiAHdI8iqd+O1xZOBVxWbAPjMbgMmfQoqtQMb7/9dY=; b=kJ8lRTX8AB9F+NMYgfnZETBZt +IMESiEAf2nmfF16xStjt7BfjJjungHR+CGu2CRXauwgHY1YwJx62B3pTjd+aBI7/7KsqWyeFV2Z+ hTNct4d4QvyrO9XU/R/iNtmytjQaSgaT3uInXl1nLcBTF3/lheb+JLgzU5ePyKm1J4SkESXYAkROo 33zzrI5H6VLQNmzdHCz0tIjYkMPbBsiOEde86mSCV9XIC0dJetkK4NgfXCQQJS8Lg37a2MkOBERi6 xzJ18gGWKf2gy8MruIaf54lT5JNJMPkkdz5UKDYSEu5YKpHjMgm4lPTK1LP+WBzi7x0wiFMVx+jsT f3o3uomJw==; Received: from willy by bombadil.infradead.org with local (Exim 4.92 #3 (Red Hat Linux)) id 1hq1wf-0008BU-3W; Tue, 23 Jul 2019 21:03:37 +0000 Date: Tue, 23 Jul 2019 14:03:37 -0700 From: Matthew Wilcox To: Ira Weiny Cc: Andrew Morton , linux-mm@kvack.org, Atul Gupta , linux-crypto@vger.kernel.org Subject: Re: [PATCH v2 1/3] mm: Introduce page_size() Message-ID: <20190723210336.GP363@bombadil.infradead.org> References: <20190721104612.19120-1-willy@infradead.org> <20190721104612.19120-2-willy@infradead.org> <20190723004307.GB10284@iweiny-DESK2.sc.intel.com> <20190723160248.GK363@bombadil.infradead.org> <20190723175838.GA29729@iweiny-DESK2.sc.intel.com> <20190723181413.GN363@bombadil.infradead.org> <20190723204416.GA27491@iweiny-DESK2.sc.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190723204416.GA27491@iweiny-DESK2.sc.intel.com> User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Tue, Jul 23, 2019 at 01:44:16PM -0700, Ira Weiny wrote: > > > Side note: why 2 checks for !page? > > > > Because page is assigned to after the first check ... > > Ah yea duh! Sorry it is a bit hard to follow. This is one of those users who really wants the VM to fall back automatically to any page order block it has on hand. We talked about it a bit in the MM track this year; not sure whether you were in the room for it.