Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Iuliana Prodan <iuliana.prodan@nxp.com>
To:     Herbert Xu <herbert@gondor.apana.org.au>,
        Horia Geanta <horia.geanta@nxp.com>,
        Aymen Sghaier <aymen.sghaier@nxp.com>
CC:     "David S. Miller" <davem@davemloft.net>,
        "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        dl-linux-imx <linux-imx@nxp.com>
Subject: Re: [PATCH v4 10/14] crypto: caam - fix MDHA key derivation for
 certain user key lengths
Thread-Topic: [PATCH v4 10/14] crypto: caam - fix MDHA key derivation for
 certain user key lengths
Thread-Index: AQHVRsbnGt/UawgfPUat+h6bvvIJAw==
Date:   Tue, 30 Jul 2019 12:27:56 +0000
Message-ID: <VI1PR04MB4445047FD7ABADD93F3D70338CDC0@VI1PR04MB4445.eurprd04.prod.outlook.com>
References: <1564484805-28735-1-git-send-email-iuliana.prodan@nxp.com>
 <1564484805-28735-11-git-send-email-iuliana.prodan@nxp.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="iso-8859-2"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 0a43c3b2-a8d2-48e7-b857-08d714e95a11
X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Jul 2019 12:27:56.5431
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: iuliana.prodan@nxp.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4112
Sender: linux-crypto-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

On 7/30/2019 2:06 PM, Iuliana Prodan wrote:=0A=
> From: Horia Geant=E3 <horia.geanta@nxp.com>=0A=
> =0A=
> Fuzz testing uncovered an issue when |user key| > |derived key|.=0A=
> Derived key generation has to be fixed in two cases:=0A=
> =0A=
> 1. Era >=3D 6 (DKP is available)=0A=
> DKP cannot be used with immediate input key if |user key| > |derived key|=
,=0A=
> since the resulting descriptor (after DKP execution) would be invalid -=
=0A=
> having a few bytes from user key left in descriptor buffer=0A=
> as incorrect opcodes.=0A=
> =0A=
> Fix DKP usage both in standalone hmac and in authenc algorithms.=0A=
> For authenc the logic is simplified, by always storing both virtual=0A=
> and dma key addresses.=0A=
> =0A=
> 2. Era < 6=0A=
> The same case (|user key| > |derived key|) fails when DKP=0A=
> is not available.=0A=
> Make sure gen_split_key() dma maps max(|user key|, |derived key|),=0A=
> since this is an in-place (bidirectional) operation.=0A=
> =0A=
> Signed-off-by: Horia Geant=E3 <horia.geanta@nxp.com>=0A=
> ---=0A=
Reviewed-by: Iuliana Prodan <iuliana.prodan@nxp.com>=0A=
=0A=
Thanks,=0A=
Iulia=0A=