Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp5961161ybi; Wed, 31 Jul 2019 06:08:50 -0700 (PDT) X-Google-Smtp-Source: APXvYqyvU1KN2OB/Xql+0k+PqN/Uk7A1xT8NxKdfVWC/YYupBjanHO8MepzOqAxwCeFH5AOc1MUX X-Received: by 2002:a65:448a:: with SMTP id l10mr88333522pgq.327.1564578529925; Wed, 31 Jul 2019 06:08:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564578529; cv=none; d=google.com; s=arc-20160816; b=FS1sOStriX+cX7XA6zLgyh1MNWD/8kikgsQOI8pg7isQvWEppuYrNvpWBifmtUxDNV asHFvSTKG8rLpms4EUMyNU27qQQTlEVBIk6bImh2OKjcGXClKyY6iVrYM0GKmUTN/g2U dsi7YDw3OPzDBUBFuwSek6jtKeb8EhHOK478qFr1seVH0HGUcmP3Vm3Cp2Um9X6lTAtd m0fJGacpCy+q69+rJlWKdu4fTm64Ypk/VTSfzOIsx5PCpjFohzLRkN1LK6FeyYtZmBJv Ma86uPMpxNwMZVZS4DKJrVfXGmwDCjTL5RFzWJOOym2xBVFRBs9Gm4p3X7iWK88Dikyu eRoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=URDnne2Pf4xuoMKmyzQxq4t0Fmkvu0iSrPBs3+6OWek=; b=T5J5xzlf97mqT2yn7QkeerfptHZSmUjCtntxOUf1YF4G0osCqBK/OKz58llVgUii3V KSSBcUs4+9KAecG3HD2MR6O/ZCFZmKlCYGPW/lIWylrUAv1qx2on7hnrxQmhOQyfXVRA A74V3AYkPA7WHdCkXE8VxqZfDMCgQhUZl0qNZ+Mmr0k9q9OlaM/hJK3OR5Khp87zbi7X 2r+OQitW9Ob0viYZut1sYolA9jOEDxrHjdJG6wvqsFBRqUfpiow5+aPuo0TD24jjBheX 8dlBxqMVYLDEypRGreVkXB6+e8J21bqqlhEcUXujYngFlOIFPTNJvwyFN2PGPj0/Zj1n 8xoQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y22si29334274plp.192.2019.07.31.06.08.36; Wed, 31 Jul 2019 06:08:49 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729231AbfGaNIX (ORCPT + 99 others); Wed, 31 Jul 2019 09:08:23 -0400 Received: from inva021.nxp.com ([92.121.34.21]:42690 "EHLO inva021.nxp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727768AbfGaNIW (ORCPT ); Wed, 31 Jul 2019 09:08:22 -0400 Received: from inva021.nxp.com (localhost [127.0.0.1]) by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id DEDD02009FA; Wed, 31 Jul 2019 15:08:20 +0200 (CEST) Received: from inva024.eu-rdc02.nxp.com (inva024.eu-rdc02.nxp.com [134.27.226.22]) by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id D1552200042; Wed, 31 Jul 2019 15:08:20 +0200 (CEST) Received: from lorenz.ea.freescale.net (lorenz.ea.freescale.net [10.171.71.5]) by inva024.eu-rdc02.nxp.com (Postfix) with ESMTP id 864DA205F3; Wed, 31 Jul 2019 15:08:20 +0200 (CEST) From: Iuliana Prodan To: Herbert Xu , Horia Geanta , Aymen Sghaier Cc: "David S. Miller" , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linux-imx Subject: [PATCH v5 00/14] crypto: caam - fixes for kernel v5.3 Date: Wed, 31 Jul 2019 16:08:01 +0300 Message-Id: <1564578495-9883-1-git-send-email-iuliana.prodan@nxp.com> X-Mailer: git-send-email 2.1.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Virus-Scanned: ClamAV using ClamSMTP Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org The series solves: - the failures found with fuzz testing; - resources clean-up on caampkc/caamrng exit path. The first 10 patches solve the issues found with CONFIG_CRYPTO_MANAGER_EXTRA_TESTS enabled. They modify the drivers to provide a valid error (and not the hardware error ID) to the user, via completion callbacks. They check key length, assoclen, authsize and input size to solve the fuzz tests that expect -EINVAL to be returned when these values are not valid. The next 4 patches check the algorithm registration for caampkc module and unregister it only if the registration was successful. Also, on caampkc/caamrng, the exit point function is executed only if the registration was successful to avoid double freeing of resources in case the initialization function failed. This patch depends on series: https://patchwork.kernel.org/project/linux-crypto/list/?series=153441 Changes since v4: - use, newly renamed, helper aes function, to validate keylen. Horia Geantă (5): crypto: caam/qi - fix error handling in ERN handler crypto: caam - fix return code in completion callbacks crypto: caam - update IV only when crypto operation succeeds crypto: caam - keep both virtual and dma key addresses crypto: caam - fix MDHA key derivation for certain user key lengths Iuliana Prodan (9): crypto: caam - check key length crypto: caam - check authsize crypto: caam - check assoclen crypto: caam - check zero-length input crypto: caam - update rfc4106 sh desc to support zero length input crypto: caam - free resources in case caam_rng registration failed crypto: caam - execute module exit point only if necessary crypto: caam - unregister algorithm only if the registration succeeded crypto: caam - change return value in case CAAM has no MDHA drivers/crypto/caam/Kconfig | 2 + drivers/crypto/caam/caamalg.c | 227 +++++++++++++++---------- drivers/crypto/caam/caamalg_desc.c | 47 ++++-- drivers/crypto/caam/caamalg_desc.h | 2 +- drivers/crypto/caam/caamalg_qi.c | 225 +++++++++++++++---------- drivers/crypto/caam/caamalg_qi2.c | 320 +++++++++++++++++++++++------------- drivers/crypto/caam/caamhash.c | 114 ++++++++----- drivers/crypto/caam/caamhash_desc.c | 5 +- drivers/crypto/caam/caamhash_desc.h | 2 +- drivers/crypto/caam/caampkc.c | 80 ++++++--- drivers/crypto/caam/caamrng.c | 17 +- drivers/crypto/caam/desc_constr.h | 34 ++-- drivers/crypto/caam/error.c | 61 ++++--- drivers/crypto/caam/error.h | 2 +- drivers/crypto/caam/key_gen.c | 14 +- drivers/crypto/caam/qi.c | 10 +- drivers/crypto/caam/regs.h | 1 + 17 files changed, 748 insertions(+), 415 deletions(-) -- 2.1.0