Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp683579ybi; Fri, 2 Aug 2019 02:33:47 -0700 (PDT) X-Google-Smtp-Source: APXvYqwybIsui3J16z1xdtzc0yOmR4f4hSEWX4+k2Xe98fHG59DKZcAIUxYDZ7R0mn/iGN4O2E1n X-Received: by 2002:a17:90a:7d09:: with SMTP id g9mr3434018pjl.38.1564738427639; Fri, 02 Aug 2019 02:33:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564738427; cv=none; d=google.com; s=arc-20160816; b=bQWMsRRc0PZCNpQHlrmKu1jusgVAdQ6YHlpTU9TTXAd59495VoG1i7xwc3Q5B5P75a ZApoKjX2yAXFSxtg82GHtF33QeXzCZkmPGcj0MjOrCf2ZeGQKIX+YcYDJM03HcRvpSCW yEY8jcPMN2e3CeuXpNCpxCoFBYx9aXxwUdrq7/nMXimbvtuccoEtULbUVhiF9FG3HV6+ CKFge6g9VEneBTIUQ5CJPVI8KtG2wKkKThotd6wQ/t+pIDtskLz3RGW3or8MvXY0LmQt 4xr58Lg6FkusE+e0wjSoiE7oPZAkKeDwdJZt5iBfwXVr+9Ebw3B90sOHwifjT4IasMOe NiqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=oQGkgX+xjP5mcvxvnZUNTJDjzsROZ8JGq6RAdmO4uPA=; b=Z5mtkRAnbSptRBaP9Tt6z25AhNetmXKJmDy7DK5n8Y3gNGDbTfmx3SQ7iTQsO7Eruj ewrbWNgTLYyFvZMVKEEnt6CbVeul79BwHGf5bOffNjsFXMSVlszhMuwxDIGhwvsa0Wn8 T1HPYx7qYpn04ftU0TmgBkbbohMGIUVS7lih/7lO0ADcfwSoXZndryZEEikRXwOzlmWZ PsYhX4qIQSH2wygu5DHgPnOR5iER3+xlnpq/sCAYjCrxkyaJ6YolJlZPNzLBqy/aSyGO zQFDIV0f8v3c3H2l7pnNI3HJMzhPUm87IeKTZWvpx6gNVJgnJgFDtw9HmcxLuQHT1rw1 0o0Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b=Kn7zyiwF; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d1si37607787pgq.540.2019.08.02.02.33.28; Fri, 02 Aug 2019 02:33:47 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b=Kn7zyiwF; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390621AbfHBIHW (ORCPT + 99 others); Fri, 2 Aug 2019 04:07:22 -0400 Received: from merlin.infradead.org ([205.233.59.134]:59956 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731650AbfHBIHV (ORCPT ); Fri, 2 Aug 2019 04:07:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=oQGkgX+xjP5mcvxvnZUNTJDjzsROZ8JGq6RAdmO4uPA=; b=Kn7zyiwFYY1w4GG19f5Z+fxXG rpdCjyayz/9gviyRYspgLpeSBWC2GfVoCY+63/ODQnmLa1Ss8JkqUpftu3V0chMAiw/KlU2kDYgEh oR5YKgy/zWb5/EAWdvNxCcTyybQ/h6IZloFk2u58KpdWjALZ6VxSlYgO9NyD6ORVH0k4+/SJs5gc5 s9u9DnNkq+UczyxB+jcY/9wLHc7m1xooYunausG0HwlgSx5YAgAGjYk+/D776D8302Y3gySch17HH NqaNqFjlPIzia2+bWk3vao3mV6/a02u4eJ9MN9jE/yE1oy7yiEOCMpBpQIwm2mrZk60vD3Q8D3Ve6 97+ImnTKw==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=hirez.programming.kicks-ass.net) by merlin.infradead.org with esmtpsa (Exim 4.92 #3 (Red Hat Linux)) id 1htSZZ-0007h0-0W; Fri, 02 Aug 2019 08:05:57 +0000 Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 8B3D42029F4CB; Fri, 2 Aug 2019 10:05:54 +0200 (CEST) Date: Fri, 2 Aug 2019 10:05:54 +0200 From: Peter Zijlstra To: john.hubbard@gmail.com Cc: Andrew Morton , Christoph Hellwig , Dan Williams , Dave Chinner , Dave Hansen , Ira Weiny , Jan Kara , Jason Gunthorpe , =?iso-8859-1?B?Suly9G1l?= Glisse , LKML , amd-gfx@lists.freedesktop.org, ceph-devel@vger.kernel.org, devel@driverdev.osuosl.org, devel@lists.orangefs.org, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-block@vger.kernel.org, linux-crypto@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-media@vger.kernel.org, linux-mm@kvack.org, linux-nfs@vger.kernel.org, linux-rdma@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-xfs@vger.kernel.org, netdev@vger.kernel.org, rds-devel@oss.oracle.com, sparclinux@vger.kernel.org, x86@kernel.org, xen-devel@lists.xenproject.org, John Hubbard Subject: Re: [PATCH 00/34] put_user_pages(): miscellaneous call sites Message-ID: <20190802080554.GD2332@hirez.programming.kicks-ass.net> References: <20190802021653.4882-1-jhubbard@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190802021653.4882-1-jhubbard@nvidia.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Thu, Aug 01, 2019 at 07:16:19PM -0700, john.hubbard@gmail.com wrote: > This is part a tree-wide conversion, as described in commit fc1d8e7cca2d > ("mm: introduce put_user_page*(), placeholder versions"). That commit > has an extensive description of the problem and the planned steps to > solve it, but the highlites are: That is one horridly mangled Changelog there :-/ It looks like it's partially duplicated. Anyway; no objections to any of that, but I just wanted to mention that there are other problems with long term pinning that haven't been mentioned, notably they inhibit compaction. A long time ago I proposed an interface to mark pages as pinned, such that we could run compaction before we actually did the pinning.