Received: by 2002:a25:b794:0:0:0:0:0 with SMTP id n20csp2956661ybh; Mon, 5 Aug 2019 09:32:24 -0700 (PDT) X-Google-Smtp-Source: APXvYqx7mi6YefZwmyGliltu5EClRceSFlLGPgCGbFq7NopEhk+jUbf8atNWSWQVGVJjxFVgG/DO X-Received: by 2002:a17:902:a409:: with SMTP id p9mr146632254plq.218.1565022744484; Mon, 05 Aug 2019 09:32:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565022744; cv=none; d=google.com; s=arc-20160816; b=tRBlJ88QG1Bmk9YNskU81sh7Mnk3Fy94OabXj+Q9JHv5vqJskDD3LqChQzh3DK8d8P 5PGp2HhGmKidj8lLCJ5qFvfu+bHS6yNevIXjrIe7ODEmV6Usa2UDZQDoH0ggq5wD4VWs uMKx0NDT/JX2z2KfzARHNp5flEReKrVCLeUzyPiuVi6SseHEBcPWcMDmjAQEpcg3PseP G8hK0KXCNq5sKJfGXNGEb6hEkcELUdgT+ykjQh/Zz7s3B3yQp3D+diMWQYc60OVVpsO0 0sJHAvOsxDhYmTFm50Gl+tD4T/g4oNG8L7wF0xfN4ZFn/QQhWKRbdailSK+mXr7tsn6Q wUPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=g+cTmbSEFfoz2KUZz+uvRnfYrlj//AwDFvYHV2OvsKQ=; b=e8qGvt9Mvyy0OwRbeMgRv92aBu6q3TgtjyChLG4bmV5bRA3IMGZlweXWuOnxDMFtvc NKLXWQfs0OfL/hntVBY/WX+uup6WtHDVdtfKnAy/ccA1YVsCi/rmKmCYOriwAahMvA7c sjxb9w3UsYq/hqubrkLm9JQExBPUvqaV0BP70oN7BGHMNaZPkpQz/cPFb+axTghhY4uu ykRXEaHmzjWjoyRthsl9g2O5mHr3UlHypO2yFr0drNhKkKDMs/SrctMUI14F8f+9QcHw CgtYIzGd6vb0bKLpwkYcpJ3j+tBNGDbtO1vB6APZh23/2voW2nZFq+3glZnuc+o8jVC8 ARQw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=YwSydi+q; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 32si42435798pla.181.2019.08.05.09.32.10; Mon, 05 Aug 2019 09:32:24 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=YwSydi+q; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726779AbfHEQcJ (ORCPT + 99 others); Mon, 5 Aug 2019 12:32:09 -0400 Received: from mail.skyhub.de ([5.9.137.197]:39300 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726620AbfHEQcJ (ORCPT ); Mon, 5 Aug 2019 12:32:09 -0400 Received: from zn.tnic (p200300EC2F065B00683A29B48F14DC99.dip0.t-ipconnect.de [IPv6:2003:ec:2f06:5b00:683a:29b4:8f14:dc99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id A405F1EC0C31; Mon, 5 Aug 2019 18:32:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1565022728; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=g+cTmbSEFfoz2KUZz+uvRnfYrlj//AwDFvYHV2OvsKQ=; b=YwSydi+q2UAgpz8CC6RgebD3zV7GEPqVPv5pRN0M6jox/WccOZt9CR/6wdUcBGgHFie+wH jGJIrKZSCnOA/4dXXVZ8d+KRrEUpIJO9cO/h4qAWyis7lZ28NvwoVi/AS9506pyVZldV3P 1Z2Jbc3INpkKJPe/0i3ikL9HuH4XOog= Date: Mon, 5 Aug 2019 18:32:02 +0200 From: Borislav Petkov To: Thomas Garnier Cc: kernel-hardening@lists.openwall.com, kristen@linux.intel.com, keescook@chromium.org, Herbert Xu , "David S. Miller" , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v9 01/11] x86/crypto: Adapt assembly for PIE support Message-ID: <20190805163202.GD18785@zn.tnic> References: <20190730191303.206365-1-thgarnie@chromium.org> <20190730191303.206365-2-thgarnie@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190730191303.206365-2-thgarnie@chromium.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Tue, Jul 30, 2019 at 12:12:45PM -0700, Thomas Garnier wrote: > Change the assembly code to use only relative references of symbols for the > kernel to be PIE compatible. > > Position Independent Executable (PIE) support will allow to extend the > KASLR randomization range below 0xffffffff80000000. I believe in previous reviews I asked about why this sentence is being replicated in every commit message and now it is still in every commit message except in 2/11. Why do you need it everywhere and not once in the 0th mail? -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.