Received: by 2002:a25:b794:0:0:0:0:0 with SMTP id n20csp7778171ybh; Thu, 8 Aug 2019 23:19:10 -0700 (PDT) X-Google-Smtp-Source: APXvYqw/GaLtWrm2ndRN5gVIU6y9f3Hm86dxiMkrwJXHRW+y6ncpDUDTD4hmR7Gro/hJ2ROz65Z1 X-Received: by 2002:a65:52c5:: with SMTP id z5mr16145413pgp.118.1565331550734; Thu, 08 Aug 2019 23:19:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565331550; cv=none; d=google.com; s=arc-20160816; b=cREDWDYEgoUW9HUdCUZ3p3rRAxn6TsWfc2A/wI1ft0jRS7yXj7sz+f06HLvmsr+RFF OK0KXFsC1P6NPrU64ar0hmtYNTHCDmhH/ZE3ErQLuiiAJ7opQ9ZKVqE6yCne00SOdNo9 6wv+vI5W8XyU5ojmJx+nxpLj4GUS7G78c2Oale81a/Pk3OS/4WLIN2QxMq6t61Jc7XPW NhwlcHONko9R9Vm4kINpEcbdfc6fO88nOrrFuNiUv3onf+PyTXyUukIURlE8/T/d0gaW bPdqwwYOqOJJvpKkq565aUY9c9C2WH3nxDzzbe9ixfchsDaZ4CN/BMpmCc8IksnPTd93 LfJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=mtj5SQHrfeBQf+1HC0eGfRYmpV2s09Gj67hxj2WwM9c=; b=ZfLUFn3kn6c7/YPz3Hlv7Clwi9+CMM4iZPkzrtYbhMPuvNYc0scprOyK4DFT1urBBm 2MOsg5YC14fVsTfODboSja/HFxVhF/SY/xnp/Dieupy0ucoPl3J3cPn+3Y7gBObIdzct 9LHdLWoBE4vLEnjL61gMzdWLwMtgaWanhaUSktj1zzsHAeYsf6mI9mLLLcunfS1CL/ZH rKbsfsIDQezw3LpklXd/DF/Jb2Y/7vexxkZLLI2BjSH61oGYxbwBzowVKPQ9kIS8aYAW APyM8oAcXxgV9fNEXmMa0J3Hm6rT/EG7FvLz1ddUHJMwfQcYAz+mu8BfzgCxTfaE2/uQ eXwA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 7si53202566pga.439.2019.08.08.23.18.57; Thu, 08 Aug 2019 23:19:10 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729419AbfHIGSm (ORCPT + 99 others); Fri, 9 Aug 2019 02:18:42 -0400 Received: from helcar.hmeau.com ([216.24.177.18]:37396 "EHLO fornost.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725879AbfHIGSm (ORCPT ); Fri, 9 Aug 2019 02:18:42 -0400 Received: from gondolin.me.apana.org.au ([192.168.0.6] helo=gondolin.hengli.com.au) by fornost.hmeau.com with esmtps (Exim 4.89 #2 (Debian)) id 1hvyEN-0007HC-Fn; Fri, 09 Aug 2019 16:18:27 +1000 Received: from herbert by gondolin.hengli.com.au with local (Exim 4.80) (envelope-from ) id 1hvyEK-0002o3-9L; Fri, 09 Aug 2019 16:18:24 +1000 Date: Fri, 9 Aug 2019 16:18:24 +1000 From: Herbert Xu To: "Hook, Gary" Cc: "linux-crypto@vger.kernel.org" , "davem@davemloft.net" , "Lendacky, Thomas" Subject: Re: [PATCH v2] crypto:ccp - Clean up and exit correctly on allocation failure Message-ID: <20190809061824.GI10392@gondor.apana.org.au> References: <20190731000314.2839-1-gary.hook@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190731000314.2839-1-gary.hook@amd.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Wed, Jul 31, 2019 at 12:03:25AM +0000, Hook, Gary wrote: > From: Gary R Hook > > Return and fail driver initialization if a DMA pool or coherent memory > can't be allocated. Be sure to clean up allocated memory. > > Fixes: 4b394a232df7 ("crypto: ccp - Let a v5 CCP provide the same function as v3") > > Signed-off-by: Gary R Hook > --- > > Changes since v1: > - Switch to devm allocation where appropriate > > drivers/crypto/ccp/ccp-dev-v5.c | 14 ++++---------- > 1 file changed, 4 insertions(+), 10 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt