Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 15 Aug 2019 21:37:32 +1000
From:   Herbert Xu <herbert@gondor.apana.org.au>
To:     Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc:     "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" 
        <linux-crypto@vger.kernel.org>, Eric Biggers <ebiggers@kernel.org>,
        Horia =?utf-8?Q?Geant=C4=83?= <horia.geanta@nxp.com>
Subject: Re: [PATCH v4 06/30] crypto: caam/des - switch to new verification
 routines
Message-ID: <20190815113732.GB27723@gondor.apana.org.au>
References: <20190805170037.31330-1-ard.biesheuvel@linaro.org>
 <20190805170037.31330-7-ard.biesheuvel@linaro.org>
 <20190815045421.GA24765@gondor.apana.org.au>
 <CAKv+Gu93e1T0nzZYgzfvMdzQ6x=3WKHBTQ1vx7n+UHecQLVS6Q@mail.gmail.com>
 <CAKv+Gu8aX_QQ4WuydX6pu+GZeRzi8_vZ24Dp0dJddpNLfcTxfQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAKv+Gu8aX_QQ4WuydX6pu+GZeRzi8_vZ24Dp0dJddpNLfcTxfQ@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-crypto-owner@vger.kernel.org
Precedence: bulk

On Thu, Aug 15, 2019 at 08:43:38AM +0300, Ard Biesheuvel wrote:
>
> So I will end up with
> 
> static inline int verify_skcipher_des_key(struct crypto_skcipher *tfm,
>   const u8 *key)
> static inline int verify_skcipher_des3_key(struct crypto_skcipher *tfm,
>    const u8 *key)
> static inline int verify_ablkcipher_des_key(struct crypto_skcipher *tfm,
>     const u8 *key)
> static inline int verify_ablkcipher_des3_key(struct crypto_skcipher *tfm,
>      const u8 *key)
> static inline int verify_aead_des3_key(struct crypto_aead *tfm, const u8 *key,
>        int keylen)
> static inline int verify_aead_des_key(struct crypto_aead *tfm, const u8 *key,
>       int keylen)
> 
> Is that what you had in mind?

Yes and hopefully we will be able to get rid of ablkcipher at some
point.

As a rule we want to make the job as easy as possible for driver
authors so we should leave the burden of such trivial things with
the API.

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt