Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190815120313.GA29253@gondor.apana.org.au> <5D556981.2080309@hisilicon.com>
 <20190815224207.GA3047@gondor.apana.org.au>
In-Reply-To: <20190815224207.GA3047@gondor.apana.org.au>
From:   =?UTF-8?B?T25kcmVqIE1vc27DocSNZWs=?= <omosnacek@gmail.com>
Date:   Fri, 16 Aug 2019 09:02:27 +0200
Message-ID: <CAAUqJDsvG-c=svGzszE8nCXwjGSYUa9BB1Jj0srY+_rX0X-jyw@mail.gmail.com>
Subject: Re: crypto: hisilicon - Fix warning on printing %p with dma_addr_t
To:     Herbert Xu <herbert@gondor.apana.org.au>
Cc:     Zhou Wang <wangzhou1@hisilicon.com>, linux-crypto@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-crypto-owner@vger.kernel.org
Precedence: bulk

Hi Herbert,

pi 16. 8. 2019 o 1:52 Herbert Xu <herbert@gondor.apana.org.au> nap=C3=ADsal=
(a):
> On Thu, Aug 15, 2019 at 10:17:37PM +0800, Zhou Wang wrote:
> >
> > > -   dev_dbg(&qm->pdev->dev, "QM mailbox request to q%u: %u-%pad\n", q=
ueue,
> > > -           cmd, dma_addr);
> > > +   dev_dbg(&qm->pdev->dev, "QM mailbox request to q%u: %u-%#lxad\n",
> > > +           queue, cmd, (unsigned long)dma_addr);
> >
> > Thanks. However, to be honest I can't get why we fix it like this.
> > Can you give me a clue?
>
> dma_addr_t is not a pointer.  It's an integer type and therefore
> you need to print it out as such.

According to Documentation/core-api/printk-formats.rst, %pad is the
format specifier intended specifically for dma_addr_t [1], so perhaps
the kbuild robot warning was in fact bogus?

[1] https://www.kernel.org/doc/html/latest/core-api/printk-formats.html#dma=
-address-types-dma-addr-t

>
> Actually my patch is buggy too, on some architectures it can be
> a long long so we need to cast is such.
>
> Cheers,
> --
> Email: Herbert Xu <herbert@gondor.apana.org.au>
> Home Page: http://gondor.apana.org.au/~herbert/
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt