Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <1989109.29ScpdGMdu@positron.chronox.de>
In-Reply-To: <1989109.29ScpdGMdu@positron.chronox.de>
From:   Ard Biesheuvel <ard.biesheuvel@linaro.org>
Date:   Fri, 16 Aug 2019 12:52:33 +0300
Message-ID: <CAKv+Gu8ipTEJBB_sXmOcajp1NSkCJfOSi=kuqZhLekxJ1sn_Ug@mail.gmail.com>
Subject: Re: XTS self test fail
To:     =?UTF-8?Q?Stephan_M=C3=BCller?= <smueller@chronox.de>
Cc:     "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" 
        <linux-crypto@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-crypto-owner@vger.kernel.org
Precedence: bulk

On Fri, 16 Aug 2019 at 12:50, Stephan M=C3=BCller <smueller@chronox.de> wro=
te:
>
> Hi,
>
> with the current cryptodev-2.6 code, I get the following with fips=3D1:
>
> [   22.301826] alg: skcipher: xts-aes-aesni encryption failed on test vec=
tor
> "random: len=3D28 klen=3D64"; expected_error=3D0, actual_error=3D-22, cfg=
=3D"random:
> inplace may_sleep use_final src_divs=3D[<reimport>100.0%@+20] iv_offset=
=3D57"

This is currently being discussed: we are adding support for
ciphertext stealing (which is part of the XTS spec but currently
unimplemented)

Do you have CONFIG_CRYPTO_MANAGER_EXTRA_TESTS=3Dy enabled?

> [   22.304800] Kernel panic - not syncing: alg: self-tests for xts-aes-ae=
sni
> (xts(aes)) failed in fips mode!
> [   22.305709] CPU: 0 PID: 259 Comm: cryptomgr_test Not tainted 5.3.0-rc1=
+ #9
> [   22.305709] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIO=
S
> 1.12.0-2.fc30 04/01/2014
> [   22.305709] Call Trace:
> [   22.305709]  dump_stack+0x7c/0xc0
> [   22.305709]  panic+0x240/0x453
> [   22.305709]  ? add_taint.cold+0x11/0x11
> [   22.305709]  ? __atomic_notifier_call_chain+0x5/0x130
> [   22.305709]  ? notifier_call_chain+0x27/0xb0
> [   22.305709]  alg_test+0x789/0x8d0
> [   22.305709]  ? valid_testvec_config+0x1d0/0x1d0
> [   22.305709]  ? lock_downgrade+0x380/0x380
> [   22.305709]  ? lock_acquire+0xff/0x220
> [   22.305709]  ? __kthread_parkme+0x45/0xd0
> [   22.305709]  ? mark_held_locks+0x24/0x90
> [   22.305709]  ? _raw_spin_unlock_irqrestore+0x43/0x50
> [   22.305709]  ? lockdep_hardirqs_on+0x1a8/0x290
> [   22.305709]  cryptomgr_test+0x36/0x60
> [   22.305709]  kthread+0x1a8/0x200
> [   22.305709]  ? crypto_acomp_scomp_free_ctx+0x70/0x70
> [   22.305709]  ? kthread_create_on_node+0xd0/0xd0
> [   22.305709]  ret_from_fork+0x3a/0x50
> [   22.305709] Kernel Offset: 0x35000000 from 0xffffffff81000000 (relocat=
ion
> range: 0xffffffff80000000-0xffffffffbfffffff)
> [   22.305709] ---[ end Kernel panic - not syncing: alg: self-tests for x=
ts-
> aes-aesni (xts(aes)) failed in fips mode! ]---
>
> Ciao
> Stephan
>
>