Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH 2/2] crypto: s5p - use correct block size of 1 for
 ctr(aes)
To:     Ard Biesheuvel <ard.biesheuvel@linaro.org>,
        linux-crypto@vger.kernel.org
Cc:     herbert@gondor.apana.org.au, Krzysztof Kozlowski <krzk@kernel.org>,
        Vladimir Zapolskiy <vz@mleia.com>,
        linux-samsung-soc@vger.kernel.org
From:   Kamil Konieczny <k.konieczny@partner.samsung.com>
Message-ID: <f42c9a9f-b9a1-1858-e79f-e844b2d56bc5@partner.samsung.com>
Date:   Tue, 20 Aug 2019 11:51:47 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
        Thunderbird/60.8.0
MIME-Version: 1.0
In-Reply-To: <20190819142226.1703-3-ard.biesheuvel@linaro.org>
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 201P
References: <20190819142226.1703-1-ard.biesheuvel@linaro.org>
        <CGME20190819142413epcas2p379e5fa48cd9c2f437b041d5a1fdd1a50@epcas2p3.samsung.com>
        <20190819142226.1703-3-ard.biesheuvel@linaro.org>
Sender: linux-crypto-owner@vger.kernel.org
Precedence: bulk

On 19.08.2019 16:22, Ard Biesheuvel wrote:
> Align the s5p ctr(aes) implementation with other implementations
> of the same mode, by setting the block size to 1.
> 
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
>  drivers/crypto/s5p-sss.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/crypto/s5p-sss.c b/drivers/crypto/s5p-sss.c
> index ef90c58edb1f..010f1bb20dad 100644
> --- a/drivers/crypto/s5p-sss.c
> +++ b/drivers/crypto/s5p-sss.c
> @@ -2173,7 +2173,7 @@ static struct crypto_alg algs[] = {
>  		.cra_flags		= CRYPTO_ALG_TYPE_ABLKCIPHER |
>  					  CRYPTO_ALG_ASYNC |
>  					  CRYPTO_ALG_KERN_DRIVER_ONLY,
> -		.cra_blocksize		= AES_BLOCK_SIZE,
> +		.cra_blocksize		= 1,
>  		.cra_ctxsize		= sizeof(struct s5p_aes_ctx),
>  		.cra_alignmask		= 0x0f,
>  		.cra_type		= &crypto_ablkcipher_type,
> 

Acked-by: Kamil Konieczny <k.konieczny@partner.samsung.com>

-- 
Best regards,
Kamil Konieczny
Samsung R&D Institute Poland