Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp505634ybl; Thu, 22 Aug 2019 00:03:02 -0700 (PDT) X-Google-Smtp-Source: APXvYqwtaZ3r9t7YWPaWEfYvR1WWXZ+f6xmFhS18lAMMi588mYqHE5Zn8npWUWfwvVXoqJiQTrqV X-Received: by 2002:a65:430a:: with SMTP id j10mr33463196pgq.374.1566457382141; Thu, 22 Aug 2019 00:03:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566457382; cv=none; d=google.com; s=arc-20160816; b=cqMi9MQtoMQ2tx60rObD5Deu5S0RE6NNHBUvzRbUn5H0E1Y9V3GKE74KHPYLDtxJS6 50+Qy6utRAYq6R+TmD1RwbpCZscXrskTHHuOgZBkyTz7B7BmP2aFMk29ftYhZJ9XfVVK b37mNrD2uPVpAt8W2lA0yHrzFkEzK/WmbbIzTdHpTod+TXXYH+5IBXBdLHDvvgX3314u ls/tqRdotkCReVteFbJECwErZIunNXOKHlFb/bZAqFhpMlj7No5vRqCi7zU5xlWoShgV QK2+0ZENxVTcxadrKPv519BLkCHwyTMy8tDHTNjoXP3mPyOeM3cSEvm4PqCD62spfuFj t6+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=DJvrrg52CGHWPbLM+wOMx6dsrUCZZ5VA6LxocC5cJCI=; b=K9kVYKEwZfFOlFplJRRbyTvtO9d00Gu5kqi7tD+4Shq7b5639X3s1qIziPsmDhxwPG 5idhwA6BVP05/NumHZAhitzaQRQ0mZioyrioYVhM4DooeZowjvSEjD454gt6jmneb6O9 9yOwnPiYYF3VDNHe9nyb4NimBTH4z32NktLvOpTozhdeSe0zLXYBHjoply/vQAMf+ulM ODflrBzK6IUYKZ5VVTOI+pcfg1iBfekkqqEJQMOwrbOv1VaH8Gb+Hb1fAWc+MvUPLWXo 0JkJV3u8vegwQQaRUSGobrmliXB+i6FDqI1RNZPTMmwHZQJTGcI60IYmcsK2EQw9cJC1 fm4g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o2si16344585pgp.288.2019.08.22.00.02.48; Thu, 22 Aug 2019 00:03:01 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729854AbfHVFzL (ORCPT + 99 others); Thu, 22 Aug 2019 01:55:11 -0400 Received: from helcar.hmeau.com ([216.24.177.18]:58354 "EHLO fornost.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729690AbfHVFzK (ORCPT ); Thu, 22 Aug 2019 01:55:10 -0400 Received: from gondolin.me.apana.org.au ([192.168.0.6] helo=gondolin.hengli.com.au) by fornost.hmeau.com with esmtps (Exim 4.89 #2 (Debian)) id 1i0g3v-0002uy-7k; Thu, 22 Aug 2019 15:55:07 +1000 Received: from herbert by gondolin.hengli.com.au with local (Exim 4.80) (envelope-from ) id 1i0g3t-00010o-FU; Thu, 22 Aug 2019 15:55:05 +1000 Date: Thu, 22 Aug 2019 15:55:05 +1000 From: Herbert Xu To: "Hook, Gary" Cc: "linux-crypto@vger.kernel.org" , "davem@davemloft.net" , "Lendacky, Thomas" Subject: Re: [PATCH] crypto: ccp - Ignore unconfigured CCP device on suspend/resume Message-ID: <20190822055505.GA3860@gondor.apana.org.au> References: <20190819222315.61244-1-gary.hook@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190819222315.61244-1-gary.hook@amd.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Mon, Aug 19, 2019 at 10:23:27PM +0000, Hook, Gary wrote: > From: Gary R Hook > > If a CCP is unconfigured (e.g. there are no available queues) then > there will be no data structures allocated for the device. Thus, we > must check for validity of a pointer before trying to access structure > members. > > Fixes: 720419f01832f ("crypto: ccp - Introduce the AMD Secure Processor device") > > Signed-off-by: Gary R Hook > --- > drivers/crypto/ccp/ccp-dev.c | 8 ++++++++ > 1 file changed, 8 insertions(+) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt