Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp364200ybe; Wed, 4 Sep 2019 22:04:48 -0700 (PDT) X-Google-Smtp-Source: APXvYqxlNI0v0p7A5jdtas4tpr8NQ/LFf1bDr8Za0XS7E95lBJKUcsuHSgl8JtR9NNnycanxTDu0 X-Received: by 2002:a17:902:9001:: with SMTP id a1mr1449194plp.28.1567659888260; Wed, 04 Sep 2019 22:04:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1567659888; cv=none; d=google.com; s=arc-20160816; b=kE6mfZZ+VXTlic9WX7FdcXwCMTdXyY7vLGbdSjH976CbjjuO4RHF0BoYsF+s0BuIKf lNK/kKD4chJEr/3ub3hNU4v7Wf96k9Fw3geAHTAN5kGeQeLnzlihcI4ZBouVExe3hk2u nUXi8WPQZAdy5ECXQkc2Wg1nA1vEHLFUF3EAbuyQjhYp2xqKsq28h7wGn085hXeoPU7r D77ALTXlEm9WfpP2xtjOUcpu46J5sFL7EpP9jVyhhRBhsX78dsaLAjZ0OUSJtUDutqYt G35O8aJIB1OMy1dlS4jvyrtiuBDWhTuJwi66OZ+L6BfCyDma6u7ItP/5bqcXnoRaERde jhvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=/gYD2y6/nFNvRXttWCSSjZBqkW40KkNXlSNA4Zi0Ais=; b=qDx6aLaunzxcUi2/g/mSNkXAgA1ajZ1c6LVnmrhZacj1FBlR+1RSTYtuQPBmx3Z94X lFky1POwtRCWJsch622TBtDkGNCFkwq/grOnivtBU2Rti2tAmRG2358Md9RSjOQFm79/ neHpqjgaoFpBvidazJGoBVJCNj0BBRRdW3LLvX9Z42ZronqKQmIveChbpVqjJcdpmh5P 4tFsMVQ0i9TBbGOTPVVgQFt+2DZiH+F9Gw4DsgP1lpoDXBtre/YodONCm2lDR9mdv1Yb FY3s1RvB550w0GaSBUJUR+alIIQhcE+wyhFi13l0Yu8Qr8qzN6B+Ssh/COqbO/aDEV3T +4/Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w21si989018pjn.61.2019.09.04.22.04.34; Wed, 04 Sep 2019 22:04:48 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730042AbfIEE4P (ORCPT + 99 others); Thu, 5 Sep 2019 00:56:15 -0400 Received: from helcar.hmeau.com ([216.24.177.18]:60560 "EHLO fornost.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731099AbfIEE4P (ORCPT ); Thu, 5 Sep 2019 00:56:15 -0400 Received: from gwarestrin.arnor.me.apana.org.au ([192.168.0.7]) by fornost.hmeau.com with smtp (Exim 4.89 #2 (Debian)) id 1i5jnx-0006IZ-4w; Thu, 05 Sep 2019 14:55:34 +1000 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Thu, 05 Sep 2019 14:55:24 +1000 Date: Thu, 5 Sep 2019 14:55:24 +1000 From: Herbert Xu To: Hans de Goede Cc: "David S . Miller" , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H . Peter Anvin" , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Russell King , Catalin Marinas , Will Deacon , Gilad Ben-Yossef , Atul Gupta , Marc Zyngier , Eric Biggers , Andy Lutomirski , Ard Biesheuvel , linux-crypto@vger.kernel.org, x86@kernel.org, linux-s390@vger.kernel.org, linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 0/9] crypto: sha256 - Merge crypto/sha256.h into crypto/sha.h Message-ID: <20190905045524.GC32038@gondor.apana.org.au> References: <20190901203532.2615-1-hdegoede@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190901203532.2615-1-hdegoede@redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Sun, Sep 01, 2019 at 10:35:23PM +0200, Hans de Goede wrote: > Hi All, > > As promised here is a follow-up series to my earlier sha256 series. > > Note I have only compiled and tested this series on x86_64 !! > > All changes to architecture specific code on other archs have not even > been tested to compile! With that said most of these changes were done > using my editors search - replace function so things should be fine... > (and FWIW I did do a Kconfig hack to compile test the ccree change). > > The first patch in this series rename various file local functions / > arrays to avoid conflicts with the new include/crypto/sha256.h, followed > by a patch merging include/crypto/sha256.h into include/crypto/sha.h. > > The last patch makes use of this merging to remove a bit more code > duplication, making sha256_generic use sha256_init and sha224_init from > lib/crypto/sha256.c. An added advantage of this, is that this gives these > 2 functions coverage by the crypto selftests. All applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt