Received: by 2002:a25:c593:0:0:0:0:0 with SMTP id v141csp364203ybe; Wed, 4 Sep 2019 22:04:48 -0700 (PDT) X-Google-Smtp-Source: APXvYqz+U5K8HXF3+jdoaTVfQqsQ4w1Vf/+mseavn/3cW3wn/ICzanjC6Cl/zwzyyk7REKHV5T7Z X-Received: by 2002:a17:902:a418:: with SMTP id p24mr1416256plq.259.1567659888388; Wed, 04 Sep 2019 22:04:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1567659888; cv=none; d=google.com; s=arc-20160816; b=v1ZidUIRt7aMsmOfxhNwDzQ6BSkmnZ3zytBd7Gs3YK56itE644fJef+gk2xeMXNGPt n4lu/RDKBPgHDuFvGDghimt/pnes1T/A2Th8xOUE8d7Cj18p13RNn/S7LtsB8nGkwIdV GPAe4caifHZt/OrtdVhXstrroWLSBu+gQc70GLwz70+0qnTv8Q9UmUmYSLvnx+kZ3IdZ Xt44QRM0nV2ymkN6ZTB2q0Y+TvMa7PDgGZqQcUpHMOuFgbEVb0tgacGzBVrx++kbjPCr AGJU5Cb0cXsdYPeWcd95U7nnXI2wGDr3kFIer03EhQanMeAP6DEQ4YFmSCNaoup4aAa6 D+TQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=BN+g2BhIWcCKn50SFKWSH21QOWmhitmQqaU8X3cJlUo=; b=mT+nk24VZM3mXDvKV8SJ7+lUCg27wCMlY9FUOxGWTDyvJ1ucfq2pX2btskvEdkgqI8 g599iHq2bMTdi+PjFUK5bd9Q6LGiiNBzlfk84wOji/v5Xjocz5MDU8p9SeXMSarAq6NH MC0iURqK41Q8tXEOTU4WxjONYGeqa5+nG8Pc6cHV7Dh9ub/F1+UhGjX4Bss2hxyP2jVY nCLWXWYU1uV9b5rRVCoY7tfFybmNSdh0sd/uUsTqcueEMJpqrXi/Va0W8t687C5Gj4fK 2fMyEvREjhsnQSOLW88zoszh1H8lDjbJUEIhkph/q6CViwlm7P4x0A0wQnZPnBtZwP8K oQ+w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p190si1004394pfp.2.2019.09.04.22.04.35; Wed, 04 Sep 2019 22:04:48 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730780AbfIEEyN (ORCPT + 99 others); Thu, 5 Sep 2019 00:54:13 -0400 Received: from helcar.hmeau.com ([216.24.177.18]:60534 "EHLO fornost.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726042AbfIEEyN (ORCPT ); Thu, 5 Sep 2019 00:54:13 -0400 Received: from gwarestrin.arnor.me.apana.org.au ([192.168.0.7]) by fornost.hmeau.com with smtp (Exim 4.89 #2 (Debian)) id 1i5jmW-0006HY-4U; Thu, 05 Sep 2019 14:54:05 +1000 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Thu, 05 Sep 2019 14:54:00 +1000 Date: Thu, 5 Sep 2019 14:54:00 +1000 From: Herbert Xu To: Daniel Mack Cc: mpm@selenic.com, gregkh@linuxfoundation.org, linux-crypto@vger.kernel.org Subject: Re: [PATCH] hw_random: timeriomem_rng: relax check on memory resource size Message-ID: <20190905045400.GB32038@gondor.apana.org.au> References: <20190831115555.11708-1-daniel@zonque.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190831115555.11708-1-daniel@zonque.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Sat, Aug 31, 2019 at 01:55:55PM +0200, Daniel Mack wrote: > The timeriomem_rng driver only accesses the first 4 bytes of the given > memory area and currently, it also forces that memory resource to be > exactly 4 bytes in size. > > This, however, is problematic when used with device-trees that are > generated from things like FPGA toolchains, where the minimum size > of an exposed memory block may be something like 4k. > > Hence, let's only check for what's needed for the driver to operate > properly; namely that we have enough memory available to read the > random data from. > > Signed-off-by: Daniel Mack > --- > Documentation/devicetree/bindings/rng/timeriomem_rng.txt | 2 +- > drivers/char/hw_random/timeriomem-rng.c | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt