Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] crypto: talitos - fix missing break in switch statement
To:     "Gustavo A. R. Silva" <gustavo@embeddedor.com>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        "David S. Miller" <davem@davemloft.net>
Cc:     linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20190909052952.GA32131@embeddedor>
From:   Christophe Leroy <christophe.leroy@c-s.fr>
Message-ID: <b2c4faf9-9b10-882d-57db-bcbc3ed2a025@c-s.fr>
Date:   Tue, 10 Sep 2019 08:06:46 +0200
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.9.0
MIME-Version: 1.0
In-Reply-To: <20190909052952.GA32131@embeddedor>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: fr
Content-Transfer-Encoding: 8bit
Sender: linux-crypto-owner@vger.kernel.org
Precedence: bulk


Le 09/09/2019 à 07:29, Gustavo A. R. Silva a écrit :
> Add missing break statement in order to prevent the code from falling
> through to case CRYPTO_ALG_TYPE_AHASH.
> 
> Fixes: aeb4c132f33d ("crypto: talitos - Convert to new AEAD interface")
> Cc: stable@vger.kernel.org
> Reported-by: kbuild test robot <lkp@intel.com>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>

Reviewed-by: Christophe Leroy <christophe.leroy@c-s.fr>

> ---
>   drivers/crypto/talitos.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/crypto/talitos.c b/drivers/crypto/talitos.c
> index c9d686a0e805..4818ae427098 100644
> --- a/drivers/crypto/talitos.c
> +++ b/drivers/crypto/talitos.c
> @@ -3140,6 +3140,7 @@ static int talitos_remove(struct platform_device *ofdev)
>   			break;
>   		case CRYPTO_ALG_TYPE_AEAD:
>   			crypto_unregister_aead(&t_alg->algt.alg.aead);
> +			break;
>   		case CRYPTO_ALG_TYPE_AHASH:
>   			crypto_unregister_ahash(&t_alg->algt.alg.hash);
>   			break;
>