Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <1568383406-8009-1-git-send-email-pvanleeuwen@verimatrix.com>
 <1568383406-8009-2-git-send-email-pvanleeuwen@verimatrix.com>
 <CAKv+Gu_qMDxNDYnMOmV1mA4+JwX3eAB3B-4aC=YJ07oZrz+wCg@mail.gmail.com> <MN2PR20MB2973F80500C43C22E05B2332CAB30@MN2PR20MB2973.namprd20.prod.outlook.com>
In-Reply-To: <MN2PR20MB2973F80500C43C22E05B2332CAB30@MN2PR20MB2973.namprd20.prod.outlook.com>
From:   Ard Biesheuvel <ard.biesheuvel@linaro.org>
Date:   Fri, 13 Sep 2019 17:23:42 +0100
Message-ID: <CAKv+Gu9-r3bKae_YNkvhWEwwS-GRUhp9qJn6+Lsgug97iGqS+A@mail.gmail.com>
Subject: Re: [PATCH 1/3] crypto: inside-secure - Added support for authenc HMAC-SHA1/DES-CBC
To:     Pascal Van Leeuwen <pvanleeuwen@verimatrix.com>
Cc:     Pascal van Leeuwen <pascalvanl@gmail.com>,
        "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" 
        <linux-crypto@vger.kernel.org>,
        Antoine Tenart <antoine.tenart@bootlin.com>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        "David S. Miller" <davem@davemloft.net>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-crypto-owner@vger.kernel.org
Precedence: bulk

On Fri, 13 Sep 2019 at 17:17, Pascal Van Leeuwen
<pvanleeuwen@verimatrix.com> wrote:
>
> > -----Original Message-----
> > From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > Sent: Friday, September 13, 2019 5:27 PM
> > To: Pascal van Leeuwen <pascalvanl@gmail.com>
> > Cc: open list:HARDWARE RANDOM NUMBER GENERATOR CORE <linux-crypto@vger.kernel.org>;
> > Antoine Tenart <antoine.tenart@bootlin.com>; Herbert Xu <herbert@gondor.apana.org.au>;
> > David S. Miller <davem@davemloft.net>; Pascal Van Leeuwen <pvanleeuwen@verimatrix.com>
> > Subject: Re: [PATCH 1/3] crypto: inside-secure - Added support for authenc HMAC-
> > SHA1/DES-CBC
> >
> > On Fri, 13 Sep 2019 at 16:06, Pascal van Leeuwen <pascalvanl@gmail.com> wrote:
> > >
> > > This patch adds support for the authenc(hmac(sha1),cbc(des)) aead
> > >
> > > Signed-off-by: Pascal van Leeuwen <pvanleeuwen@verimatrix.com>
> >
> > Please make sure your code is based on cryptodev/master before sending
> > it to the list.
> >
> Looks like with this patchset and the previous (SHA3) patchset I forgot
> to add the disclaimer that it applies on top of the previous patchset.
> Mea culpa.
>
> So there you go: "Added support for authenc HMAC-SHA1/DES-CBC" applies
> on top of "Added (HMAC) SHA3 support", which applies on top of
> "Add support for SM4 ciphers".
>

Sorry if I wasn't clear, but that was not my point.

You should really base your code on cryptodev/master since some of the
DES helpers you are using don't exist anymore.