Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sat, 14 Sep 2019 10:59:13 -0700
From:   Tony Lindgren <tony@atomide.com>
To:     Sebastian Reichel <sre@kernel.org>
Cc:     Matt Mackall <mpm@selenic.com>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
        linux-crypto@vger.kernel.org, Aaro Koskinen <aaro.koskinen@iki.fi>,
        Adam Ford <aford173@gmail.com>,
        Pali =?utf-8?B?Um9ow6Fy?= <pali.rohar@gmail.com>,
        Rob Herring <robh+dt@kernel.org>,
        Tero Kristo <t-kristo@ti.com>, devicetree@vger.kernel.org
Subject: Re: [PATCH 0/6] Non-urgent fixes and improvments for omap3-rom-rng
Message-ID: <20190914175913.GW52127@atomide.com>
References: <20190913220922.29501-1-tony@atomide.com>
 <20190914130540.jvtxaame7pat7jph@earth.universe>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190914130540.jvtxaame7pat7jph@earth.universe>
User-Agent: Mutt/1.11.4 (2019-03-13)
Sender: linux-crypto-owner@vger.kernel.org
Precedence: bulk

* Sebastian Reichel <sre@kernel.org> [190914 13:06]:
> Hi,
> 
> On Fri, Sep 13, 2019 at 03:09:16PM -0700, Tony Lindgren wrote:
> > Here are fixes and improvments for omap3-rom-rng that's been broken for
> > a while.
> > 
> > The first four patches get it working, and then the last two patches add
> > support for runtime PM.
> 
> Nice cleanups, the series is
> 
> Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com>
> 
> Assuming you use clk_prepare_enable() in the runtime PM handler, I
> suggest to add another patch and go all the way to managed resources:
> devm_add_action() can be used for disabling runtime PM and
> devm_hwrng_register() can be used to register the hwrng device.

Sure good idea. I'll post a patch for that when I post v2 of
this set.

Regards,

Tony