Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190906152250.1450649-1-arnd@arndb.de> <20190906152250.1450649-2-arnd@arndb.de>
 <20190913091718.GA6382@gondor.apana.org.au> <5D833821.5000504@hisilicon.com> <20190919134813.GB29320@gondor.apana.org.au>
In-Reply-To: <20190919134813.GB29320@gondor.apana.org.au>
From:   Arnd Bergmann <arnd@arndb.de>
Date:   Thu, 19 Sep 2019 16:07:41 +0200
Message-ID: <CAK8P3a0gw0rZ-gfeh+VWL3t2qmj=a3aVV0s12tGw92fbUcfpxQ@mail.gmail.com>
Subject: Re: [PATCH 2/2] crypto: hisilicon - avoid unused function warning
To:     Herbert Xu <herbert@gondor.apana.org.au>
Cc:     Zhou Wang <wangzhou1@hisilicon.com>,
        "David S. Miller" <davem@davemloft.net>,
        Jonathan Cameron <Jonathan.Cameron@huawei.com>,
        Hao Fang <fanghao11@huawei.com>,
        Kenneth Lee <liguozhu@hisilicon.com>,
        "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" 
        <linux-crypto@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-crypto-owner@vger.kernel.org
Precedence: bulk

On Thu, Sep 19, 2019 at 3:48 PM Herbert Xu <herbert@gondor.apana.org.au> wrote:
>
> On Thu, Sep 19, 2019 at 04:11:13PM +0800, Zhou Wang wrote:
> > On 2019/9/13 17:17, Herbert Xu wrote:
> > > On Fri, Sep 06, 2019 at 05:22:30PM +0200, Arnd Bergmann wrote:
> > >> The only caller of hisi_zip_vf_q_assign() is hidden in an #ifdef,
> > >> so the function causes a warning when CONFIG_PCI_IOV is disabled:
> > >>
> > >> drivers/crypto/hisilicon/zip/zip_main.c:740:12: error: unused function 'hisi_zip_vf_q_assign' [-Werror,-Wunused-function]
> > >>
> > >> Move it into the same #ifdef.
> > >>
> > >> Fixes: 79e09f30eeba ("crypto: hisilicon - add SRIOV support for ZIP")
> > >> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > >> ---
> > >>  drivers/crypto/hisilicon/zip/zip_main.c | 2 ++
> > >>  1 file changed, 2 insertions(+)
> > >
> > > Please find a way to fix this warning without reducing compiler
> > > coverage.  I prefer to see any compile issues immediately rather
> > > than through automated build testing.
> > >
> > > Thanks,
> > >
> >
> > Sorry for missing this patch.
> >
> > Seems other drivers also do like using #ifdef. Do you mean something like this:
> > #ifdef CONFIG_PCI_IOV
> > sriov_enable()
> > ...
> > #else
> > /* stub */
> > sriov_enable()
> > ...
> > #endif
>
> For an unused warning the unused compiler attribute would seem
> to be the way to go.

I sent an update patch now that also removes the first #ifdef, plus one
that enables compile-testing on x86 (with some caveats).

      Arnd