Received: by 2002:a25:b323:0:0:0:0:0 with SMTP id l35csp126565ybj; Thu, 19 Sep 2019 11:43:43 -0700 (PDT) X-Google-Smtp-Source: APXvYqwS0mWc5NYMTl9DbWCJf6kibxun8bA/r15F2UWeGz8wmUwChaH3WcPXbvXodD5ubOEpi0is X-Received: by 2002:a50:95c1:: with SMTP id x1mr17336302eda.180.1568918623518; Thu, 19 Sep 2019 11:43:43 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1568918623; cv=pass; d=google.com; s=arc-20160816; b=xPgHpHkQRYVIvi2KPsTTTEAo7ROcw5zQsQwrZfx10i79ZVLrRi6tVToVGIh8YNg3HG XiBSqclq7Pqb6AbQGy4mk4tcnXDEzR9W1nsptZiDEU5DgRZQUTSME3VCOX5+EgTv4LLY a9NjMUdy6zZoFbiR6uucWhsHZWOf2yRE4YFZHuqYROsygM8JA7yNTVXPlgb9W3c/RPpX b3cfZZ45wjF98B8rP0RohSRhWRmYiaQ+8DB2K/bhatfir8PT0Zt2xUmTXhiHcI5Eeu6z ZO3uEIJNVh2JfKOFFwvcWyLD2AaHqk79ZT9VJuE52aRTy5J7inz2g5cVlfByFgRMX2CT hx5w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :content-id:content-language:accept-language:in-reply-to:references :message-id:date:thread-index:thread-topic:subject:cc:to:from :dkim-signature; bh=BUjG2l5IW6N5XsYmCFfZm0v9sn9nL1hn/SA3Iw6M/8s=; b=okWGUD6IVWNZs5dPmZHbW7FhRLuSXKRRcE5o8UhXdlxRq2vXFBnMVDELomzPnoyQkx wzmXyWpbWk/O3anf7/rwJ9QVrWWk8dX1IAfXh0fQpA98QWfvCom654Xo9qaIFexV7BCo Ma4Hhu/lwBUSzU6X0pdGnaB4w1PqgMRD1clFKlOaBGj9O7psqPn2tCHr8cSme+4K5MV5 9bYXFAl1ejO57ZynRTm68X8wRjtut+oWQsClfpUO+wOm77GD25yxqXDYXt+lBWmNfDCW AHEbjzDni2A52lZbCqt9fxG2/R9pIsl4ZbNDowzjZ0jhAHPE9SVPYOvn8fFHbt5fP+VJ yXHA== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amdcloud.onmicrosoft.com header.s=selector2-amdcloud-onmicrosoft-com header.b="xB/vMcdb"; arc=pass (i=1 spf=pass spfdomain=amd.com dkim=pass dkdomain=amd.com dmarc=pass fromdomain=amd.com); spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g13si4868584ejf.133.2019.09.19.11.43.18; Thu, 19 Sep 2019 11:43:43 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@amdcloud.onmicrosoft.com header.s=selector2-amdcloud-onmicrosoft-com header.b="xB/vMcdb"; arc=pass (i=1 spf=pass spfdomain=amd.com dkim=pass dkdomain=amd.com dmarc=pass fromdomain=amd.com); spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728230AbfISRAp (ORCPT + 99 others); Thu, 19 Sep 2019 13:00:45 -0400 Received: from mail-eopbgr820058.outbound.protection.outlook.com ([40.107.82.58]:22763 "EHLO NAM01-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726007AbfISRAp (ORCPT ); Thu, 19 Sep 2019 13:00:45 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Piq49f9N80pNwQjeafztVBS7JFmn5TN6rx7p8Xy6aEbnC+IbUGB3dSqV8KImYasPppsBw6591VRYVPMlmI3lw2n/EP9Pvn+I9UWI0YfmWtgWIafqgmGsmeqC7nCf+2KNqsiIHfgHfY6I8TCsJmyznZWIpF6/gXkGtkxoCUovFS7sqyY/EpYd9B0sKfZ+cxJSd8hSLW1pq/hLypom2Vf5ypSNyYJrWz9PtiicusZp1duYxc9WwkG3BXBwEnfzMUjbinb+lP+rViql62gVoKSvXn2aFgcla1aVf8ZJbmYyb7Ptqtq4k5hKIcgA4O+uiYua5vy9S2Ibo/RZ8/7oVpCi+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BUjG2l5IW6N5XsYmCFfZm0v9sn9nL1hn/SA3Iw6M/8s=; b=Zcy0Tb/FRebNFLUp2jDnKccPm1V2oI7Q3WHm7XdNG8YO/8uY5EKz06ZI7Es86MjMFLGWhLXRaDGb4YmsdR3ZLGZUHPMVEun3Y+uNPuACtgtuyP+Lv/nOKwlUYzZi6bjinF6V7Lg045fRtEC3YwFnvpCg3R0CPXV8jcwHfMdocxvo2OwDlEX7fs1GouRXWqCaLTSaFRyE9qK6j3GILJT45KlKEDO/iiRu35soNeC/xDjDJfcvZ2A6dRvq1z3q7XS0iaf7aa6Tk3+J9cxEc+NM3eIKpIeP3uisnsaJgmodgBcDiW1mq7id8fOUfUGfkX0lHNkoGVEIWcf6glRIM4qauQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector2-amdcloud-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BUjG2l5IW6N5XsYmCFfZm0v9sn9nL1hn/SA3Iw6M/8s=; b=xB/vMcdbDXwLqh6qbKWvlop/1rKFAvK7yWlNqi8C2GYKSHJqFZ8NxWLieTIJQIVi1kCa09TG7eynjjk8CYr3K35LwBGewqnpfRUwjxCed0J2D/eV/927pw0mthBI93R/zhV2ZL8PvxtMvYppsnJ2b8yiy/9MzM2w4pMZ2yDSrPA= Received: from MWHPR12MB1455.namprd12.prod.outlook.com (10.172.56.18) by MWHPR12MB1935.namprd12.prod.outlook.com (10.175.55.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2263.20; Thu, 19 Sep 2019 17:00:39 +0000 Received: from MWHPR12MB1455.namprd12.prod.outlook.com ([fe80::a872:70bf:908d:cfe4]) by MWHPR12MB1455.namprd12.prod.outlook.com ([fe80::a872:70bf:908d:cfe4%10]) with mapi id 15.20.2263.023; Thu, 19 Sep 2019 17:00:39 +0000 From: Gary R Hook To: Navid Emamdoost CC: "emamd001@umn.edu" , "smccaman@umn.edu" , "kjlu@umn.edu" , "Lendacky, Thomas" , "Hook, Gary" , Herbert Xu , "David S. Miller" , "linux-crypto@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v2] crypto: ccp - Release all allocated memory if sha type is invalid Thread-Topic: [PATCH v2] crypto: ccp - Release all allocated memory if sha type is invalid Thread-Index: AQHVbwP/iuwCAhY3XEu9GjXpPNVWj6czOXsA Date: Thu, 19 Sep 2019 17:00:39 +0000 Message-ID: References: <7ffc6a77-f4e3-7db9-4ec6-53d6e01d881d@amd.com> <20190919160449.4303-1-navid.emamdoost@gmail.com> In-Reply-To: <20190919160449.4303-1-navid.emamdoost@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: SN4PR0401CA0025.namprd04.prod.outlook.com (2603:10b6:803:2a::11) To MWHPR12MB1455.namprd12.prod.outlook.com (2603:10b6:301:10::18) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Gary.Hook@amd.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [165.204.77.1] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6d7e79f2-180f-42e5-f1d0-08d73d22e5b0 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(5600167)(711020)(4605104)(1401327)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7193020);SRVR:MWHPR12MB1935; x-ms-traffictypediagnostic: MWHPR12MB1935: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:497; x-forefront-prvs: 016572D96D x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(4636009)(136003)(366004)(39860400002)(346002)(396003)(376002)(189003)(199004)(6246003)(229853002)(5660300002)(6512007)(99286004)(102836004)(446003)(52116002)(6916009)(76176011)(26005)(71190400001)(71200400001)(53546011)(6506007)(386003)(486006)(14444005)(256004)(54906003)(316002)(11346002)(6486002)(186003)(2616005)(476003)(4744005)(6436002)(66556008)(66946007)(64756008)(81156014)(81166006)(8676002)(66066001)(4326008)(36756003)(66476007)(66446008)(14454004)(31686004)(31696002)(8936002)(2906002)(7736002)(305945005)(25786009)(478600001)(6116002)(3846002);DIR:OUT;SFP:1101;SCL:1;SRVR:MWHPR12MB1935;H:MWHPR12MB1455.namprd12.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: amd.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: WsvhbAshNfNW31Wnxz+h2r4sIfL+2xZMVrExSqtQ2dUe09j6LwiOCmDHm0Gj+KZFNEB9WlvvnLKF9qG4h+7JNLRsw9WBVFa9zV6uqZP0x/02tsOrumaXKLZ2cYSNSuRgYJ+p7qo29/hXzKQv+Md3fdm3OMuIkMtcs0AJLvl+SCCDuoIgkzBj0bvZ0vTPJ64+abR78gzF78GUU8x21f8+EU7Gd0S0vZ4eFQJs+FYLj3Yw3KE0GI6VxyRCts/Tmu2JzModTiD/xBgvfAbLfrRftpb9761ah3WBbgh6wBlPJgzz/blQs1jiS9utKe1Rd5XejFTVyEA9125zHcaSSTbHb/tkI2TwTwGXgga+5Se9b6Z265mGlIV60wX4hgE50BuFIa1ujpAj6F7UHN0k/xkFYneMneDvpbTq/6zV0E+wlZM= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6d7e79f2-180f-42e5-f1d0-08d73d22e5b0 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Sep 2019 17:00:39.1224 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: KbJ3nA/tk/8g6ysvheHFOcg79qiDmPAErakw32/rAuDDK+bveyXXTctcm1XUDTQA X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR12MB1935 Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org DQoNCk9uIDkvMTkvMTkgMTE6MDQgQU0sIE5hdmlkIEVtYW1kb29zdCB3cm90ZToNCj4gUmVsZWFz ZSBhbGwgYWxsb2NhdGVkIG1lbW9yeSBpZiBzaGEgdHlwZSBpcyBpbnZhbGlkOg0KPiBJbiBjY3Bf cnVuX3NoYV9jbWQsIGlmIHRoZSB0eXBlIG9mIHNoYSBpcyBpbnZhbGlkLCB0aGUgYWxsb2NhdGVk DQo+IGhtYWNfYnVmIHNob3VsZCBiZSByZWxlYXNlZC4NCj4NCj4gdjI6IGZpeCB0aGUgZ290by4N Cj4NCj4gU2lnbmVkLW9mZi1ieTogTmF2aWQgRW1hbWRvb3N0IDxuYXZpZC5lbWFtZG9vc3RAZ21h aWwuY29tPg0KDQpBY2tlZC1ieTogR2FyeSBSIEhvb2sgPGdhcnkuaG9va0BhbWQuY29tPg0KDQo+ IC0tLQ0KPiAgIGRyaXZlcnMvY3J5cHRvL2NjcC9jY3Atb3BzLmMgfCAzICsrLQ0KPiAgIDEgZmls ZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkNCj4NCj4gZGlmZiAtLWdp dCBhL2RyaXZlcnMvY3J5cHRvL2NjcC9jY3Atb3BzLmMgYi9kcml2ZXJzL2NyeXB0by9jY3AvY2Nw LW9wcy5jDQo+IGluZGV4IDliYzNjNjIxNTdkNy4uNDQwZGY5MjA4ZjhmIDEwMDY0NA0KPiAtLS0g YS9kcml2ZXJzL2NyeXB0by9jY3AvY2NwLW9wcy5jDQo+ICsrKyBiL2RyaXZlcnMvY3J5cHRvL2Nj cC9jY3Atb3BzLmMNCj4gQEAgLTE3ODIsOCArMTc4Miw5IEBAIHN0YXRpYyBpbnQgY2NwX3J1bl9z aGFfY21kKHN0cnVjdCBjY3BfY21kX3F1ZXVlICpjbWRfcSwgc3RydWN0IGNjcF9jbWQgKmNtZCkN Cj4gICAJCQkgICAgICAgTFNCX0lURU1fU0laRSk7DQo+ICAgCQkJYnJlYWs7DQo+ICAgCQlkZWZh dWx0Og0KPiArCQkJa2ZyZWUoaG1hY19idWYpOw0KPiAgIAkJCXJldCA9IC1FSU5WQUw7DQo+IC0J CQlnb3RvIGVfY3R4Ow0KPiArCQkJZ290byBlX2RhdGE7DQo+ICAgCQl9DQo+ICAgDQo+ICAgCQlt ZW1zZXQoJmhtYWNfY21kLCAwLCBzaXplb2YoaG1hY19jbWQpKTsNCg0K