Received: by 2002:a25:824b:0:0:0:0:0 with SMTP id d11csp1836688ybn; Thu, 26 Sep 2019 03:00:20 -0700 (PDT) X-Google-Smtp-Source: APXvYqzGBDL6jXBiWyH/21o4k4IBdkbTduOt4eEvOqel2c4u7PDqIsHxjI+umR9LH+6+TY35PzJ1 X-Received: by 2002:a05:6402:1251:: with SMTP id l17mr2577316edw.270.1569492020093; Thu, 26 Sep 2019 03:00:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569492020; cv=none; d=google.com; s=arc-20160816; b=OaXth10dxRGnSUa8zQeVVEyC8Sym8xDUH/iZxROHjbCTiVWV5wkXnuUQ4sy/zewcRV oTTKasAugiWWHehqdMWOD5XdEkLXSN3wg8GfNPrIrrONOpnEAxOgU+FR/L8BpQT67rS/ nHFdwUtHnnzVGCTfA161rgX0WMMhcfQH5p/9GzDkcvO+PC8+HbkXKCS7K7XlhE2HB7bI kn2asmeyZ2HE/K0eTDiybNUr1FHSdu73dCdvUgnnY36JRXkbP6gC2MHxSc/vv1JqTOvu dXZN5sNx7wj1I46hyFlVI0+JxvBVvOpnOx++ZdnUXb3/OWO3t9sptdf8zq0qkvUMDevn tQyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=Y4WwKMmfBss6jCT8sswdSW8XG9WNLoHbSfuw/zcQnv4=; b=ChlNMdOPVLpP++mibqvqnTSbJ6ZcLLlEqabvC3YqpL7nbsY5vH3hfauqGaUASZIt9M nSB4MZoYNbZeL+fF0D1CnRupMEm4SR/NeiuJ5QnXnbhEVCrjKWkiemw+0zsS0uFcvUeb uR2ri7FaIvYjM+7vINmq6sq7WEQQ9VnL8J8kMttOdEMxDFeGSVNMP0tSrbWYeFocOOxB 7ODdkooGuVFucsDwFuuLbuK0mi+YKQ5a6QWpgCToC60Q1v/XkIKyEK02BhRRRDrpj4bN 3fFXdBhvCU/trvpk+Kejkr6Yv4D5yTzIpQTLIIIGpcLzPU1Wh40ECpFk9QuA4S8GSAh4 N+HA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=google header.b=XSKk1k0m; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h19si902302edv.393.2019.09.26.02.59.55; Thu, 26 Sep 2019 03:00:20 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=google header.b=XSKk1k0m; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388187AbfIYVBy (ORCPT + 99 others); Wed, 25 Sep 2019 17:01:54 -0400 Received: from mail-lj1-f194.google.com ([209.85.208.194]:42972 "EHLO mail-lj1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726375AbfIYVBy (ORCPT ); Wed, 25 Sep 2019 17:01:54 -0400 Received: by mail-lj1-f194.google.com with SMTP id y23so7152979lje.9 for ; Wed, 25 Sep 2019 14:01:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Y4WwKMmfBss6jCT8sswdSW8XG9WNLoHbSfuw/zcQnv4=; b=XSKk1k0mpU0UMH+Zcok2JKeL1jHtU9jXhTOXZTQLNoPC/tSNq4KHOihGeNblVsloZw Tjqp4BgW8O21/Z9FlMga7c8GZcxgjFqu+MgvyTCRXh18WIAGOjsbAeQjSInnJzj0uqdh C1lWhBJiJ/IwD3KYacmToe044cXx+wZjlPIXE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Y4WwKMmfBss6jCT8sswdSW8XG9WNLoHbSfuw/zcQnv4=; b=O1wGuxOukZA4PNZoBJNSzxLx0bm/HWttCByoCpoot4Uw4tqM+auSrXc/0Ot8g10A1V 247t0WAOPj+wdY5W4FixyqqCcwa7ChOuEoo5eVEAUl591KEELUbounRV+bCU3YHerJvq qlodzttwiMGz7bodNSFxELxFH4HtFhbA0nhgrY61Ta/10yPmcCHEoJ/4qHzsiUdQ8LwH AuiWAsR3zPDl6ZCh+S7esURi2qvJhKFhPvSXpVVvnqpW8KHtv6czmZYyrdiSe3BCV199 2gI1RrCA+6pxHijcE61IUbAKgFWhg9KQwx4MNm2qC4f3JldWJvfz2lTvfeM++13EDcO3 mYNA== X-Gm-Message-State: APjAAAXln8B7j8Yf+Vwl+gCfS87CX9puQeeXkIz8YXkJ+cl80gJNfx78 lYWIGCR7GzdvbFDlSvC08SpQwWiWFBc= X-Received: by 2002:a2e:4243:: with SMTP id p64mr176807lja.213.1569445311221; Wed, 25 Sep 2019 14:01:51 -0700 (PDT) Received: from mail-lj1-f169.google.com (mail-lj1-f169.google.com. [209.85.208.169]) by smtp.gmail.com with ESMTPSA id c15sm56133ljf.1.2019.09.25.14.01.49 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 Sep 2019 14:01:50 -0700 (PDT) Received: by mail-lj1-f169.google.com with SMTP id e17so7143381ljf.13 for ; Wed, 25 Sep 2019 14:01:49 -0700 (PDT) X-Received: by 2002:a2e:9854:: with SMTP id e20mr218041ljj.72.1569445309746; Wed, 25 Sep 2019 14:01:49 -0700 (PDT) MIME-Version: 1.0 References: <20190925161255.1871-1-ard.biesheuvel@linaro.org> <20190925161255.1871-12-ard.biesheuvel@linaro.org> In-Reply-To: <20190925161255.1871-12-ard.biesheuvel@linaro.org> From: Linus Torvalds Date: Wed, 25 Sep 2019 14:01:33 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC PATCH 11/18] int128: move __uint128_t compiler test to Kconfig To: Ard Biesheuvel Cc: Linux Crypto Mailing List , Linux ARM , Herbert Xu , David Miller , Greg KH , "Jason A . Donenfeld" , Samuel Neves , Dan Carpenter , Arnd Bergmann , Eric Biggers , Andy Lutomirski , Will Deacon , Marc Zyngier , Catalin Marinas Content-Type: text/plain; charset="UTF-8" Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Wed, Sep 25, 2019 at 9:14 AM Ard Biesheuvel wrote: > > config ARCH_SUPPORTS_INT128 > bool > + depends on !$(cc-option,-D__SIZEOF_INT128__=0) Hmm. Does this actually work? If that "depends on" now ends up being 'n', afaik the people who _enable_ it just do a select ARCH_SUPPORTS_INT128 and now you'll end up with the Kconfig erroring out with WARNING: unmet direct dependencies detected for ARCH_SUPPORTS_INT128 and then you end up with CONFIG_ARCH_SUPPORTS_INT128 anyway, instead of the behavior you _want_ to get, which is to not get that CONFIG defined at all. So I heartily agree with your intent, but I don't think that model works. I think you need to change the cases that currently do select ARCH_SUPPORTS_INT128 to instead have that cc-option test. And take all the above with a pinch of salt. Maybe what you are doing works, and I am just missing some piece of the puzzle. But I _think_ it's broken, and you didn't test with a compiler that doesn't support that thing properly. Linus