Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Horia Geanta <horia.geanta@nxp.com>
To:     Iuliana Prodan <iuliana.prodan@nxp.com>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        Aymen Sghaier <aymen.sghaier@nxp.com>
CC:     "David S. Miller" <davem@davemloft.net>,
        "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        dl-linux-imx <linux-imx@nxp.com>
Subject: Re: [PATCH] crypto: caam - use mapped_{src,dst}_nents for descriptor
Thread-Topic: [PATCH] crypto: caam - use mapped_{src,dst}_nents for descriptor
Thread-Index: AQHVc6HU9i9GulTWykOrXicA04oXkw==
Date:   Thu, 26 Sep 2019 07:17:28 +0000
Message-ID: <VI1PR0402MB348551336691838632965ADA98860@VI1PR0402MB3485.eurprd04.prod.outlook.com>
References: <1569416676-21810-1-git-send-email-iuliana.prodan@nxp.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: fe0bb9f6-bce5-472d-db0a-08d7425196e6
X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Sep 2019 07:17:28.6171
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 6nHszJG2elqD06cBE+I634zlZfZCD7RR0T0Q3BrX23ZQEJ7i1eHGgMheZQX/JX2wghiDh1Bti8WU1c04gB50bQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB2749
Sender: linux-crypto-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

On 9/25/2019 4:04 PM, Iuliana Prodan wrote:=0A=
> @@ -428,17 +433,18 @@ static int set_rsa_priv_f1_pdb(struct akcipher_requ=
est *req,=0A=
>  		return -ENOMEM;=0A=
>  	}=0A=
>  =0A=
> -	if (edesc->src_nents > 1) {=0A=
> +	if (edesc->mapped_src_nents > 1) {=0A=
>  		pdb->sgf |=3D RSA_PRIV_PDB_SGF_G;=0A=
>  		pdb->g_dma =3D edesc->sec4_sg_dma;=0A=
> -		sec4_sg_index +=3D edesc->src_nents;=0A=
> +		sec4_sg_index +=3D edesc->mapped_src_nents;=0A=
> +=0A=
>  	} else {=0A=
>  		struct caam_rsa_req_ctx *req_ctx =3D akcipher_request_ctx(req);=0A=
>  =0A=
>  		pdb->g_dma =3D sg_dma_address(req_ctx->fixup_src);=0A=
>  	}=0A=
>  =0A=
> -	if (edesc->dst_nents > 1) {=0A=
> +	if (edesc->mapped_dst_nents > 1) {=0A=
>  		pdb->sgf |=3D RSA_PRIV_PDB_SGF_F;=0A=
>  		pdb->f_dma =3D edesc->sec4_sg_dma +=0A=
>  			     sec4_sg_index * sizeof(struct sec4_sg_entry);=0A=
AFAICS there are a few other places besides set_rsa_priv_f1_pdb=0A=
that should be updated:=0A=
	set_rsa_pub_pdb=0A=
	set_rsa_priv_f2_pdb=0A=
	set_rsa_priv_f3_pdb=0A=
=0A=
Horia=0A=