Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 2 Oct 2019 16:30:50 +0200
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc:     linux-crypto@vger.kernel.org,
        Herbert Xu <herbert@gondor.apana.org.au>,
        David Miller <davem@davemloft.net>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        "Jason A . Donenfeld" <Jason@zx2c4.com>,
        Samuel Neves <sneves@dei.uc.pt>,
        Dan Carpenter <dan.carpenter@oracle.com>,
        Arnd Bergmann <arnd@arndb.de>,
        Eric Biggers <ebiggers@google.com>,
        Andy Lutomirski <luto@kernel.org>,
        Will Deacon <will@kernel.org>, Marc Zyngier <maz@kernel.org>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Martin Willi <martin@strongswan.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Josh Poimboeuf <jpoimboe@redhat.com>
Subject: Re: [PATCH v2 01/20] crypto: chacha - move existing library code
 into lib/crypto
Message-ID: <20191002143050.GA1743118@kroah.com>
References: <20191002141713.31189-1-ard.biesheuvel@linaro.org>
 <20191002141713.31189-2-ard.biesheuvel@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20191002141713.31189-2-ard.biesheuvel@linaro.org>
User-Agent: Mutt/1.12.2 (2019-09-21)
Sender: linux-crypto-owner@vger.kernel.org
Precedence: bulk

On Wed, Oct 02, 2019 at 04:16:54PM +0200, Ard Biesheuvel wrote:
> Move the existing shared ChaCha code into lib/crypto, and at the
> same time, split the support header into a public version, and an
> internal version that is only intended for consumption by crypto
> implementations.
> 
> At the same time, refactor the generic implementation so it only gets
> exposed as the chacha_crypt() library function if the architecture does
> not override it with its own implementation, potentially falling back
> to the generic routine if needed.

That's a _lot_ to do all in one patch.

And you are saying _what_ you are doing, but not _why_.

Why move all this around and do these changes?  What's wrong with the
code as-is in the current location?  Is all of the crc and other
"crypto" code going to be moved into lib/crypto/ as well?

thanks,

greg k-h