Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp1042965ybp; Fri, 4 Oct 2019 08:44:53 -0700 (PDT) X-Google-Smtp-Source: APXvYqyVrcsxAsqc5w9OxCVUEoEOWqNJkBGOC+FPQj/Fz0VYw41WDVihUZEXH20cqkxzdSI5HzKp X-Received: by 2002:a17:906:3486:: with SMTP id g6mr3243399ejb.262.1570203893130; Fri, 04 Oct 2019 08:44:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570203893; cv=none; d=google.com; s=arc-20160816; b=A1hlI3tvXpeNWgsT1qDCniMYj/UxGg+JX4K+KvpVmQFS61t9zf8GEynSbfcydPPVmf zGW9sS7kf2qcchSrUxx1GqKc7Zotsnv6hCRpDMrWIkjsP4zciZPI1ii9XG1S7UuMgDQq znuwBLQqJuzwCVH/wXB7TMxnZjcWszQkW8LsN0RNl5rp3Wog++u6kONSDfB6mrcohD/U H/u3QLwRsTa8+XmCRnY1cZFO7WcAvUTP8BBhgupkhSZ/5rBoqVPI3zsd9BvFFDQXg3Nk Dh1KmbS6S+m/Um/5ZtZBX5pSppvdKi74nlH6EU9U3oJ2zdLzdMvSbQKdCk3OjPRQWg3j S1Dw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:message-id:subject:cc:to:from:date; bh=kuJ48QzkZCnrxCRRU47UWs6TcOk5hvBAc8uB4zcdsQ0=; b=WdUIkgOGJMgivRTpsRNzk/AhmKULVMGifidgwYH+ozIn4op27tQHYMVFkThbgqBqhP uZEYBkmKVxSd/gXl5UJXHDA4LQ9I1fG1rvUpSEoeT6Wj+XtxFEJCV/he23/IbfmNRCSw 9S2Ajj5I2dWknmRT3MBHtDohmsFkT8WU68gEnuRpOXNgJnyshBy+0v6jQnke99jIYdxx IYsyBXaIkbQlRqewdYZxET9puDseYT25KB7sv9Lgbh/IL6WtYS1hIS2g9VrGNCD3TPAA AqzXccPkCctLR+zCizdPD0eYqY0GEoEeO92cDQ+H/GtdR83aLzc5e0zM87w+SvASEMB5 IDZQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id bo22si3083688ejb.369.2019.10.04.08.44.27; Fri, 04 Oct 2019 08:44:53 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389869AbfJDPns (ORCPT + 99 others); Fri, 4 Oct 2019 11:43:48 -0400 Received: from helcar.hmeau.com ([216.24.177.18]:42542 "EHLO fornost.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389131AbfJDPnr (ORCPT ); Fri, 4 Oct 2019 11:43:47 -0400 Received: from gwarestrin.arnor.me.apana.org.au ([192.168.0.7]) by fornost.hmeau.com with smtp (Exim 4.89 #2 (Debian)) id 1iGPj9-0001MW-HZ; Sat, 05 Oct 2019 01:42:44 +1000 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Sat, 05 Oct 2019 01:42:42 +1000 Date: Sat, 5 Oct 2019 01:42:42 +1000 From: Herbert Xu To: "Alexander E. Patrakov" Cc: linux-crypto@vger.kernel.org, smueller@chronox.de, patrakov@gmail.com Subject: Re: [PATCH] jitterentropy: fix comments Message-ID: <20191004154242.GA7330@gondor.apana.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190918072849.6749-1-patrakov@gmail.com> X-Newsgroups: apana.lists.os.linux.cryptoapi User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Alexander E. Patrakov wrote: > One should not say "ec can be NULL" and then dereference it. > One cannot talk about the return value if the function returns void. > > Signed-off-by: Alexander E. Patrakov > --- > crypto/jitterentropy.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt