Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Pascal Van Leeuwen <pvanleeuwen@verimatrix.com>
To:     YueHaibing <yuehaibing@huawei.com>,
        "herbert@gondor.apana.org.au" <herbert@gondor.apana.org.au>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "pascalvanl@gmail.com" <pascalvanl@gmail.com>,
        "antoine.tenart@bootlin.com" <antoine.tenart@bootlin.com>
CC:     "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH -next] crypto: inside-secure - Fix randbuild error
Thread-Topic: [PATCH -next] crypto: inside-secure - Fix randbuild error
Thread-Index: AQHVfagq9QgwAxh3xk6Yw1cHeAjlcqdQWBng
Date:   Tue, 8 Oct 2019 07:32:36 +0000
Message-ID: <MN2PR20MB297342D98080781DB5DC7BABCA9A0@MN2PR20MB2973.namprd20.prod.outlook.com>
References: <20191008071503.55772-1-yuehaibing@huawei.com>
In-Reply-To: <20191008071503.55772-1-yuehaibing@huawei.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: verimatrix.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="Windows-1252"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 8794216e-f80a-4aa3-93a6-08d74bc1b141
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Oct 2019 07:32:36.7172
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: dcb260f9-022d-4495-8602-eae51035a0d0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: GQuga7WVYi8ivjg9GRdnjtzGaJ6/HtIizWxkEitxhSQvbpoXBoOPK/hsPGOpQtFtpCA0bXQtPsmbPTMaRwgtZAJhiCAa8JIt0+2BA7G3mcU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR20MB2590
Sender: linux-crypto-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

> -----Original Message-----
> From: linux-crypto-owner@vger.kernel.org <linux-crypto-owner@vger.kernel.=
org> On Behalf Of
> YueHaibing
> Sent: Tuesday, October 8, 2019 9:15 AM
> To: herbert@gondor.apana.org.au; davem@davemloft.net; pascalvanl@gmail.co=
m;
> antoine.tenart@bootlin.com
> Cc: linux-crypto@vger.kernel.org; linux-kernel@vger.kernel.org; YueHaibin=
g
> <yuehaibing@huawei.com>
> Subject: [PATCH -next] crypto: inside-secure - Fix randbuild error
>=20
> If CRYPTO_DEV_SAFEXCEL is y but CRYPTO_SM3 is m,
> building fails:
>=20
> drivers/crypto/inside-secure/safexcel_hash.o: In function `safexcel_ahash=
_final':
> safexcel_hash.c:(.text+0xbc0): undefined reference to `sm3_zero_message_h=
ash'
>=20
> Select CRYPTO_SM3 to fix this.
>=20
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Fixes: 0f2bc13181ce ("crypto: inside-secure - Added support for basic SM3=
 ahash")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
>  drivers/crypto/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>=20
> diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig
> index 3e51bae..5af17db 100644
> --- a/drivers/crypto/Kconfig
> +++ b/drivers/crypto/Kconfig
> @@ -751,6 +751,7 @@ config CRYPTO_DEV_SAFEXCEL
>  	select CRYPTO_SHA512
>  	select CRYPTO_CHACHA20POLY1305
>  	select CRYPTO_SHA3
> +	select CRYPTO_SM3
>  	help
>  	  This driver interfaces with the SafeXcel EIP-97 and EIP-197 cryptogra=
phic
>  	  engines designed by Inside Secure. It currently accelerates DES, 3DES=
 and
> --
> 2.7.4
>=20
But ... I don't really want to build SM3 into the kernel for all Inside
Secure drivers, since in the majority of cases, the HW will not actually
support SM3 and I don't want to bloat the kernel image in that case.

So maybe it's better to #ifdef out the failing part of the driver if
CONFIG_SM3 is not set?

Regards,
Pascal van Leeuwen
Silicon IP Architect, Multi-Protocol Engines @ Verimatrix
www.insidesecure.com