Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Pascal Van Leeuwen <pvanleeuwen@verimatrix.com>
To:     Joe Perches <joe@perches.com>,
        Colin King <colin.king@canonical.com>,
        Antoine Tenart <antoine.tenart@bootlin.com>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        "David S . Miller" <davem@davemloft.net>,
        "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>
CC:     "kernel-janitors@vger.kernel.org" <kernel-janitors@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH][next] crypto: inside-secure: fix spelling mistake
 "algorithmn" -> "algorithm"
Thread-Topic: [PATCH][next] crypto: inside-secure: fix spelling mistake
 "algorithmn" -> "algorithm"
Thread-Index: AQHVfbBiWkZb4mCzbk2SwbBbsORNa6dQZX5AgAAD7YCAAAB/4A==
Date:   Tue, 8 Oct 2019 08:33:34 +0000
Message-ID: <MN2PR20MB297358121F5F6D5B4B07ED13CA9A0@MN2PR20MB2973.namprd20.prod.outlook.com>
References: <20191008081410.18857-1-colin.king@canonical.com>
         <MN2PR20MB29735A64971670E9CE56821ECA9A0@MN2PR20MB2973.namprd20.prod.outlook.com>
 <f7fada8a8afce542e5ac08f804df8d5c8d8a726b.camel@perches.com>
In-Reply-To: <f7fada8a8afce542e5ac08f804df8d5c8d8a726b.camel@perches.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: verimatrix.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="Windows-1252"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: a7f58ca6-91c5-41a5-c12c-08d74bca359a
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Oct 2019 08:33:35.0066
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: dcb260f9-022d-4495-8602-eae51035a0d0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 0ogOlx220Vl6DEhaL2NriDIZFvgz3kZ0x+NN/UGLl/WG76clpfkg47u9qfxtNmkKyP5OxmKE42UgKEtVSkru6O0wm+/5Wi4vYeioJPbydVg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR20MB3136
Sender: linux-crypto-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

> -----Original Message-----
> From: Joe Perches <joe@perches.com>
> Sent: Tuesday, October 8, 2019 10:29 AM
> To: Pascal Van Leeuwen <pvanleeuwen@verimatrix.com>; Colin King <colin.ki=
ng@canonical.com>;
> Antoine Tenart <antoine.tenart@bootlin.com>; Herbert Xu <herbert@gondor.a=
pana.org.au>; David S .
> Miller <davem@davemloft.net>; linux-crypto@vger.kernel.org
> Cc: kernel-janitors@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH][next] crypto: inside-secure: fix spelling mistake "a=
lgorithmn" ->
> "algorithm"
>=20
> On Tue, 2019-10-08 at 08:15 +0000, Pascal Van Leeuwen wrote:
> > > There is a spelling mistake in a dev_err message. Fix it.
> []
> > > diff --git a/drivers/crypto/inside-secure/safexcel_cipher.c b/drivers=
/crypto/inside-
> []
> > > @@ -437,7 +437,7 @@ static int safexcel_aead_setkey(struct crypto_aea=
d *ctfm, const u8 *key,
> > >  			goto badkey;
> > >  		break;
> > >  	default:
> > > -		dev_err(priv->dev, "aead: unsupported hash algorithmn");
> > > +		dev_err(priv->dev, "aead: unsupported hash algorithm");
> > >  		goto badkey;
> > >  	}
> []
> > Actually, the typing error is well spotted, but the fix is not correct.
> > What actually happened here is that a \ got accidentally deleted,
> > there should have been a "\n" at the end of the line ...
>=20
> Other missing newlines in the same file:
> ---
>  drivers/crypto/inside-secure/safexcel_cipher.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>=20
> diff --git a/drivers/crypto/inside-secure/safexcel_cipher.c b/drivers/cry=
pto/inside-
> secure/safexcel_cipher.c
> index cecc56073337..47fec8a0a4e1 100644
> --- a/drivers/crypto/inside-secure/safexcel_cipher.c
> +++ b/drivers/crypto/inside-secure/safexcel_cipher.c
> @@ -695,21 +695,21 @@ static int safexcel_send_req(struct crypto_async_re=
quest *base, int ring,
>  		sreq->nr_dst =3D sreq->nr_src;
>  		if (unlikely((totlen_src || totlen_dst) &&
>  		    (sreq->nr_src <=3D 0))) {
> -			dev_err(priv->dev, "In-place buffer not large enough (need %d bytes)!=
",
> +			dev_err(priv->dev, "In-place buffer not large enough (need %d bytes)!=
\n",
>  				max(totlen_src, totlen_dst));
>  			return -EINVAL;
>  		}
>  		dma_map_sg(priv->dev, src, sreq->nr_src, DMA_BIDIRECTIONAL);
>  	} else {
>  		if (unlikely(totlen_src && (sreq->nr_src <=3D 0))) {
> -			dev_err(priv->dev, "Source buffer not large enough (need %d bytes)!",
> +			dev_err(priv->dev, "Source buffer not large enough (need %d bytes)!\n=
",
>  				totlen_src);
>  			return -EINVAL;
>  		}
>  		dma_map_sg(priv->dev, src, sreq->nr_src, DMA_TO_DEVICE);
>=20
>  		if (unlikely(totlen_dst && (sreq->nr_dst <=3D 0))) {
> -			dev_err(priv->dev, "Dest buffer not large enough (need %d bytes)!",
> +			dev_err(priv->dev, "Dest buffer not large enough (need %d bytes)!\n",
>  				totlen_dst);
>  			dma_unmap_sg(priv->dev, src, sreq->nr_src,
>  				     DMA_TO_DEVICE);

Yes, thanks!

Acked-by: Pascal van Leeuwen <pvanleeuwen@verimatrix.com>

Regards,
Pascal van Leeuwen
Silicon IP Architect, Multi-Protocol Engines @ Verimatrix
www.insidesecure.com